summaryrefslogtreecommitdiffstats
path: root/Lib
diff options
context:
space:
mode:
authorMartin v. Löwis <martin@v.loewis.de>2005-03-03 23:12:42 (GMT)
committerMartin v. Löwis <martin@v.loewis.de>2005-03-03 23:12:42 (GMT)
commit637431bf145a4e35458219c18db843a054e0adf3 (patch)
tree4e8279725ed34c2fe1db28010f52142fccd5faf3 /Lib
parentc9f852512c221ebd377233e1ed92364d9dd0aecf (diff)
downloadcpython-637431bf145a4e35458219c18db843a054e0adf3.zip
cpython-637431bf145a4e35458219c18db843a054e0adf3.tar.gz
cpython-637431bf145a4e35458219c18db843a054e0adf3.tar.bz2
Patch #1103407: Properly deal with tarfile iterators when untarring
symbolic links on Windows. Fixes #1100429. Will backport to 2.4.
Diffstat (limited to 'Lib')
-rw-r--r--Lib/tarfile.py19
1 files changed, 15 insertions, 4 deletions
diff --git a/Lib/tarfile.py b/Lib/tarfile.py
index 9bfad25..06f3ab3 100644
--- a/Lib/tarfile.py
+++ b/Lib/tarfile.py
@@ -1851,6 +1851,7 @@ class TarIter:
"""Construct a TarIter object.
"""
self.tarfile = tarfile
+ self.index = 0
def __iter__(self):
"""Return iterator object.
"""
@@ -1859,10 +1860,20 @@ class TarIter:
"""Return the next item using TarFile's next() method.
When all members have been read, set TarFile as _loaded.
"""
- tarinfo = self.tarfile.next()
- if not tarinfo:
- self.tarfile._loaded = True
- raise StopIteration
+ # Fix for SF #1100429: Under rare circumstances it can
+ # happen that getmembers() is called during iteration,
+ # which will cause TarIter to stop prematurely.
+ if not self.tarfile._loaded:
+ tarinfo = self.tarfile.next()
+ if not tarinfo:
+ self.tarfile._loaded = True
+ raise StopIteration
+ else:
+ try:
+ tarinfo = self.tarfile.members[self.index]
+ except IndexError:
+ raise StopIteration
+ self.index += 1
return tarinfo
# Helper classes for sparse file support