diff options
author | Dima Ryazanov <dima@bucket.xxx> | 2024-12-24 15:56:42 (GMT) |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-12-24 15:56:42 (GMT) |
commit | 7ed6c5c6961d0849f163d4d449fb36bae312b6bc (patch) | |
tree | 555479da4b66f1418174199ef03207189b7c968f /Lib | |
parent | 9fce90682553e2cfe93e98e2ae5948bf9c7c4456 (diff) | |
download | cpython-7ed6c5c6961d0849f163d4d449fb36bae312b6bc.zip cpython-7ed6c5c6961d0849f163d4d449fb36bae312b6bc.tar.gz cpython-7ed6c5c6961d0849f163d4d449fb36bae312b6bc.tar.bz2 |
gh-127847: Fix position in the special-cased zipfile seek (#127856)
---------
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
Diffstat (limited to 'Lib')
-rw-r--r-- | Lib/test/test_zipfile/test_core.py | 12 | ||||
-rw-r--r-- | Lib/zipfile/__init__.py | 5 |
2 files changed, 16 insertions, 1 deletions
diff --git a/Lib/test/test_zipfile/test_core.py b/Lib/test/test_zipfile/test_core.py index c36228c..124e088 100644 --- a/Lib/test/test_zipfile/test_core.py +++ b/Lib/test/test_zipfile/test_core.py @@ -2333,6 +2333,18 @@ class OtherTests(unittest.TestCase): fp.seek(1, os.SEEK_CUR) self.assertEqual(fp.read(-1), b'men!') + def test_uncompressed_interleaved_seek_read(self): + # gh-127847: Make sure the position in the archive is correct + # in the special case of seeking in a ZIP_STORED entry. + with zipfile.ZipFile(TESTFN, "w") as zipf: + zipf.writestr("a.txt", "123") + zipf.writestr("b.txt", "456") + with zipfile.ZipFile(TESTFN, "r") as zipf: + with zipf.open("a.txt", "r") as a, zipf.open("b.txt", "r") as b: + self.assertEqual(a.read(1), b"1") + self.assertEqual(b.seek(1), 1) + self.assertEqual(b.read(1), b"5") + @requires_bz2() def test_decompress_without_3rd_party_library(self): data = b'PK\x05\x06\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00' diff --git a/Lib/zipfile/__init__.py b/Lib/zipfile/__init__.py index 6907ae6..f4d396a 100644 --- a/Lib/zipfile/__init__.py +++ b/Lib/zipfile/__init__.py @@ -819,7 +819,10 @@ class _SharedFile: raise ValueError("Can't reposition in the ZIP file while " "there is an open writing handle on it. " "Close the writing handle before trying to read.") - self._file.seek(offset, whence) + if whence == os.SEEK_CUR: + self._file.seek(self._pos + offset) + else: + self._file.seek(offset, whence) self._pos = self._file.tell() return self._pos |