summaryrefslogtreecommitdiffstats
path: root/Lib
diff options
context:
space:
mode:
authorSenthil Kumaran <orsenthil@gmail.com>2010-07-28 16:35:35 (GMT)
committerSenthil Kumaran <orsenthil@gmail.com>2010-07-28 16:35:35 (GMT)
commita4f79f97db7920387d6c7704a2b212d6b1503d9d (patch)
treec2ba4db2d64510712e0dd6ccf51c49d342e87634 /Lib
parent946963fdc563835da3734d12a947a014c9abd066 (diff)
downloadcpython-a4f79f97db7920387d6c7704a2b212d6b1503d9d.zip
cpython-a4f79f97db7920387d6c7704a2b212d6b1503d9d.tar.gz
cpython-a4f79f97db7920387d6c7704a2b212d6b1503d9d.tar.bz2
Merged revisions 83209 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k ........ r83209 | senthil.kumaran | 2010-07-28 21:57:56 +0530 (Wed, 28 Jul 2010) | 3 lines Fix Issue6325 - robotparse to honor urls with query strings. ........
Diffstat (limited to 'Lib')
-rw-r--r--Lib/robotparser.py7
-rw-r--r--Lib/test/test_robotparser.py11
2 files changed, 17 insertions, 1 deletions
diff --git a/Lib/robotparser.py b/Lib/robotparser.py
index 447563f..730426f 100644
--- a/Lib/robotparser.py
+++ b/Lib/robotparser.py
@@ -131,7 +131,12 @@ class RobotFileParser:
return True
# search for given user agent matches
# the first match counts
- url = urllib.quote(urlparse.urlparse(urllib.unquote(url))[2]) or "/"
+ parsed_url = urlparse.urlparse(urllib.unquote(url))
+ url = urlparse.urlunparse(('', '', parsed_url.path,
+ parsed_url.params, parsed_url.query, parsed_url.fragment))
+ url = urllib.quote(url)
+ if not url:
+ url = "/"
for entry in self.entries:
if entry.applies_to(useragent):
return entry.allowance(url)
diff --git a/Lib/test/test_robotparser.py b/Lib/test/test_robotparser.py
index 405d517..0415884 100644
--- a/Lib/test/test_robotparser.py
+++ b/Lib/test/test_robotparser.py
@@ -202,6 +202,17 @@ bad = ['/folder1/anotherfile.html']
RobotTest(13, doc, good, bad, agent="googlebot")
+# 14. For issue #6325 (query string support)
+doc = """
+User-agent: *
+Disallow: /some/path?name=value
+"""
+
+good = ['/some/path']
+bad = ['/some/path?name=value']
+
+RobotTest(14, doc, good, bad)
+
class NetworkTestCase(unittest.TestCase):