diff options
author | Lars Gustäbel <lars@gustaebel.de> | 2010-04-29 15:37:02 (GMT) |
---|---|---|
committer | Lars Gustäbel <lars@gustaebel.de> | 2010-04-29 15:37:02 (GMT) |
commit | d6eb70b7b4569cfd16f5deb42c748c439c63a008 (patch) | |
tree | 8caf490097ef53dd23205feb5bb047f0fd488b05 /Lib | |
parent | ffa155ad83ac40c3eeb55cbe8fe16a304a23cfe1 (diff) | |
download | cpython-d6eb70b7b4569cfd16f5deb42c748c439c63a008.zip cpython-d6eb70b7b4569cfd16f5deb42c748c439c63a008.tar.gz cpython-d6eb70b7b4569cfd16f5deb42c748c439c63a008.tar.bz2 |
Merged revisions 80616 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/trunk
........
r80616 | lars.gustaebel | 2010-04-29 17:23:38 +0200 (Thu, 29 Apr 2010) | 4 lines
Issue #8464: tarfile.open(name, mode="w|") no longer creates
files with execute permissions set.
........
Diffstat (limited to 'Lib')
-rw-r--r-- | Lib/tarfile.py | 2 | ||||
-rw-r--r-- | Lib/test/test_tarfile.py | 18 |
2 files changed, 19 insertions, 1 deletions
diff --git a/Lib/tarfile.py b/Lib/tarfile.py index 8684493..9ca8494 100644 --- a/Lib/tarfile.py +++ b/Lib/tarfile.py @@ -359,7 +359,7 @@ class _LowLevelFile: }[mode] if hasattr(os, "O_BINARY"): mode |= os.O_BINARY - self.fd = os.open(name, mode) + self.fd = os.open(name, mode, 0o666) def close(self): os.close(self.fd) diff --git a/Lib/test/test_tarfile.py b/Lib/test/test_tarfile.py index ff04ef8..43527ef 100644 --- a/Lib/test/test_tarfile.py +++ b/Lib/test/test_tarfile.py @@ -846,6 +846,24 @@ class StreamWriteTest(WriteTestBase): self.assertTrue(data.count(b"\0") == tarfile.RECORDSIZE, "incorrect zero padding") + def test_file_mode(self): + # Test for issue #8464: Create files with correct + # permissions. + if sys.platform == "win32" or not hasattr(os, "umask"): + return + + if os.path.exists(tmpname): + os.remove(tmpname) + + original_umask = os.umask(0o022) + try: + tar = tarfile.open(tmpname, self.mode) + tar.close() + mode = os.stat(tmpname).st_mode & 0o777 + self.assertEqual(mode, 0o644, "wrong file permissions") + finally: + os.umask(original_umask) + class GNUWriteTest(unittest.TestCase): # This testcase checks for correct creation of GNU Longname |