diff options
| author | Serhiy Storchaka <storchaka@gmail.com> | 2015-09-07 16:58:23 (GMT) |
|---|---|---|
| committer | Serhiy Storchaka <storchaka@gmail.com> | 2015-09-07 16:58:23 (GMT) |
| commit | eba8feedfa0d62b042ad0ecabf6cab733528dbd6 (patch) | |
| tree | 05191658e5348d5e10158fe31838aed3255d2e20 /Lib | |
| parent | a091a8221e78eb4005ebd8e32f8fcb998f7b19c8 (diff) | |
| download | cpython-eba8feedfa0d62b042ad0ecabf6cab733528dbd6.zip cpython-eba8feedfa0d62b042ad0ecabf6cab733528dbd6.tar.gz cpython-eba8feedfa0d62b042ad0ecabf6cab733528dbd6.tar.bz2 | |
Issue #25018: Fixed testing shutil.make_archive() with relative base_name on
Windows. The test now makes sense on non-Windows. Added similar test for
zip format.
Diffstat (limited to 'Lib')
| -rw-r--r-- | Lib/test/test_shutil.py | 28 |
1 files changed, 19 insertions, 9 deletions
diff --git a/Lib/test/test_shutil.py b/Lib/test/test_shutil.py index cdc059b..b9ec313 100644 --- a/Lib/test/test_shutil.py +++ b/Lib/test/test_shutil.py @@ -968,13 +968,13 @@ class TestShutil(unittest.TestCase): tmpdir2 = self.mkdtemp() # force shutil to create the directory os.rmdir(tmpdir2) - unittest.skipUnless(splitdrive(root_dir)[0] == splitdrive(tmpdir2)[0], - "source and target should be on same drive") + # working with relative paths + work_dir = os.path.dirname(tmpdir2) + rel_base_name = os.path.join(os.path.basename(tmpdir2), 'archive') + base_name = os.path.join(work_dir, rel_base_name) - base_name = os.path.join(tmpdir2, 'archive') - - # working with relative paths to avoid tar warnings - tarball = make_archive(splitdrive(base_name)[1], 'gztar', root_dir, '.') + with support.change_cwd(work_dir): + tarball = make_archive(rel_base_name, 'gztar', root_dir, '.') # check if the compressed tarball was created self.assertEqual(tarball, base_name + '.tar.gz') @@ -986,7 +986,8 @@ class TestShutil(unittest.TestCase): './file1', './file2', './sub/file3']) # trying an uncompressed one - tarball = make_archive(splitdrive(base_name)[1], 'tar', root_dir, '.') + with support.change_cwd(work_dir): + tarball = make_archive(rel_base_name, 'tar', root_dir, '.') self.assertEqual(tarball, base_name + '.tar') self.assertTrue(os.path.isfile(tarball)) self.assertTrue(tarfile.is_tarfile(tarball)) @@ -1053,8 +1054,17 @@ class TestShutil(unittest.TestCase): def test_make_zipfile(self): # creating something to zip root_dir, base_dir = self._create_files() - base_name = os.path.join(self.mkdtemp(), 'archive') - res = make_archive(base_name, 'zip', root_dir, 'dist') + + tmpdir2 = self.mkdtemp() + # force shutil to create the directory + os.rmdir(tmpdir2) + # working with relative paths + work_dir = os.path.dirname(tmpdir2) + rel_base_name = os.path.join(os.path.basename(tmpdir2), 'archive') + base_name = os.path.join(work_dir, rel_base_name) + + with support.change_cwd(work_dir): + res = make_archive(rel_base_name, 'zip', root_dir, 'dist') self.assertEqual(res, base_name + '.zip') self.assertTrue(os.path.isfile(res)) |