summaryrefslogtreecommitdiffstats
path: root/Lib
diff options
context:
space:
mode:
authorCollin Winter <collinw@gmail.com>2007-05-09 04:14:36 (GMT)
committerCollin Winter <collinw@gmail.com>2007-05-09 04:14:36 (GMT)
commitfa9be8c289a963bbd626c452b7c0a2ddde12a7ef (patch)
treee2d4819cbe6d3e41d7e5b126caecd6b1d475bd25 /Lib
parentabe1d48d2068ef0fea36a9b370a8b159ab267430 (diff)
downloadcpython-fa9be8c289a963bbd626c452b7c0a2ddde12a7ef.zip
cpython-fa9be8c289a963bbd626c452b7c0a2ddde12a7ef.tar.gz
cpython-fa9be8c289a963bbd626c452b7c0a2ddde12a7ef.tar.bz2
Fix a bug in test.test_support.open_urlresource().
If the call to requires() doesn't precede the filesystem check, we get the following situation: 1. ./python Lib/test/regrtest.py test_foo # test needs urlfetch, not enabled, so skipped 2. ./python Lib/test/regrtest.py -u urlfetch test_foo # test runs 3. ./python Lib/test/regrtest.py test_foo # test runs (!) By moving the call to requires() *before* the filesystem check, the fact that fetched files are cached on the local disk becomes an implementation detail, rather than a semantics-changing point of note.
Diffstat (limited to 'Lib')
-rw-r--r--Lib/test/test_support.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/Lib/test/test_support.py b/Lib/test/test_support.py
index 1ac9a22..cdaee92 100644
--- a/Lib/test/test_support.py
+++ b/Lib/test/test_support.py
@@ -259,6 +259,7 @@ def check_syntax_error(testcase, statement):
def open_urlresource(url):
import urllib, urlparse
+ requires('urlfetch')
filename = urlparse.urlparse(url)[2].split('/')[-1] # '/': it's URL!
for path in [os.path.curdir, os.path.pardir]:
@@ -266,7 +267,6 @@ def open_urlresource(url):
if os.path.exists(fn):
return open(fn)
- requires('urlfetch')
print >> get_original_stdout(), '\tfetching %s ...' % url
fn, _ = urllib.urlretrieve(url, filename)
return open(fn)