diff options
| author | Ned Deily <nad@python.org> | 2018-12-23 20:32:48 (GMT) |
|---|---|---|
| committer | Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> | 2018-12-23 20:32:48 (GMT) |
| commit | 44a3ee07e30e18d83e2730c093d8b0e930f0a06c (patch) | |
| tree | d935c43b5877cd324fd0f42f9382bcd2b2714df3 /Makefile.pre.in | |
| parent | 284b787612af2fde74713ade8e6b6a2807d34011 (diff) | |
| download | cpython-44a3ee07e30e18d83e2730c093d8b0e930f0a06c.zip cpython-44a3ee07e30e18d83e2730c093d8b0e930f0a06c.tar.gz cpython-44a3ee07e30e18d83e2730c093d8b0e930f0a06c.tar.bz2 | |
bpo-35257: fix broken BLDSHARED - needs LDFLAGS too (GH-11297)
`BLDSHARED` needs to have both `LDFLAGS` and `LDFLAGS_NODIST`, not just `LDFLAGS_NODIST`; `PY_CORE_LDFLAGS` provides both. For example, as it stands now with just `LDFLAGS_NODIST`, macOS universal builds are broken as the necessary `-arch` flags are no longer passed to the standard library extension module link step from `setup.py` resulting in extension modules being single architecture only.
https://bugs.python.org/issue35257
Diffstat (limited to 'Makefile.pre.in')
| -rw-r--r-- | Makefile.pre.in | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Makefile.pre.in b/Makefile.pre.in index 04312e1..3c77a0e 100644 --- a/Makefile.pre.in +++ b/Makefile.pre.in @@ -153,7 +153,7 @@ CONFINCLUDEPY= $(CONFINCLUDEDIR)/python$(LDVERSION) SHLIB_SUFFIX= @SHLIB_SUFFIX@ EXT_SUFFIX= @EXT_SUFFIX@ LDSHARED= @LDSHARED@ $(PY_LDFLAGS) -BLDSHARED= @BLDSHARED@ $(PY_LDFLAGS_NODIST) +BLDSHARED= @BLDSHARED@ $(PY_CORE_LDFLAGS) LDCXXSHARED= @LDCXXSHARED@ DESTSHARED= $(BINLIBDEST)/lib-dynload |