diff options
| author | Artem Khramov <akhramov@pm.me> | 2019-08-14 21:21:48 (GMT) |
|---|---|---|
| committer | Victor Stinner <vstinner@redhat.com> | 2019-08-14 21:21:48 (GMT) |
| commit | 28146206578ebe1b84b48e6f255738a227058c04 (patch) | |
| tree | 9d6e5c90cba99c1ec804d8999e0dd0b7b2e84b48 /Misc/ACKS | |
| parent | dcfe111eb5602333135b8776996332a8dcf59392 (diff) | |
| download | cpython-28146206578ebe1b84b48e6f255738a227058c04.zip cpython-28146206578ebe1b84b48e6f255738a227058c04.tar.gz cpython-28146206578ebe1b84b48e6f255738a227058c04.tar.bz2 | |
bpo-37811: FreeBSD, OSX: fix poll(2) usage in sockets module (GH-15202)
FreeBSD implementation of poll(2) restricts the timeout argument to be
either zero, or positive, or equal to INFTIM (-1).
Unless otherwise overridden, socket timeout defaults to -1. This value
is then converted to milliseconds (-1000) and used as argument to the
poll syscall. poll returns EINVAL (22), and the connection fails.
This bug was discovered during the EINTR handling testing, and the
reproduction code can be found in
https://bugs.python.org/issue23618 (see connect_eintr.py,
attached). On GNU/Linux, the example runs as expected.
This change is trivial:
If the supplied timeout value is negative, truncate it to -1.
Diffstat (limited to 'Misc/ACKS')
| -rw-r--r-- | Misc/ACKS | 1 |
1 files changed, 1 insertions, 0 deletions
@@ -837,6 +837,7 @@ Lawrence Kesteloot Garvit Khatri Vivek Khera Dhiru Kholia +Artem Khramov Akshit Khurana Sanyam Khurana Mads Kiilerich |