diff options
| author | Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> | 2019-06-14 11:53:13 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-06-14 11:53:13 (GMT) |
| commit | 8b66dbb212d7dffbf9fb545dad2a3400aead1461 (patch) | |
| tree | 2b191066fa4542f584330faf9f36c6b45e371d89 /Misc | |
| parent | 7cd581a6bf82309b3c9b9251c54067d442732485 (diff) | |
| download | cpython-8b66dbb212d7dffbf9fb545dad2a3400aead1461.zip cpython-8b66dbb212d7dffbf9fb545dad2a3400aead1461.tar.gz cpython-8b66dbb212d7dffbf9fb545dad2a3400aead1461.tar.bz2 | |
bpo-37278: Fix test_asyncio ProactorLoopCtrlC (GH-14074)
Join the thread to prevent leaking a running thread and leaking a
reference.
Cleanup also the test:
* asyncioWindowsProactorEventLoopPolicy became the default policy,
there is no need to set it manually.
* Only start the thread once the loop is running.
* Use a shorter sleep in the thread (100 ms rather than 1 sec).
* Use close_loop(loop) rather than loop.close().
* Use longer variable names.
(cherry picked from commit 07559450b2d9179e4c99e0af088ce7550e549f94)
Co-authored-by: Victor Stinner <vstinner@redhat.com>
Diffstat (limited to 'Misc')
| -rw-r--r-- | Misc/NEWS.d/next/Tests/2019-06-14-12-21-47.bpo-37278.z0HUOr.rst | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/Misc/NEWS.d/next/Tests/2019-06-14-12-21-47.bpo-37278.z0HUOr.rst b/Misc/NEWS.d/next/Tests/2019-06-14-12-21-47.bpo-37278.z0HUOr.rst new file mode 100644 index 0000000..3d3011b --- /dev/null +++ b/Misc/NEWS.d/next/Tests/2019-06-14-12-21-47.bpo-37278.z0HUOr.rst @@ -0,0 +1,2 @@ +Fix test_asyncio ProactorLoopCtrlC: join the thread to prevent leaking a +running thread and leaking a reference. |