diff options
| author | Benjamin Peterson <benjamin@python.org> | 2018-07-07 03:41:06 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-07-07 03:41:06 (GMT) |
| commit | b0274f2cddd36b49fe5080efbe160277ef546471 (patch) | |
| tree | 6a13b9a5c333d79953a0d14af161c9b278c3b78c /Misc | |
| parent | e25399b40cd15620e77c9ad2ed24549006ae9b47 (diff) | |
| download | cpython-b0274f2cddd36b49fe5080efbe160277ef546471.zip cpython-b0274f2cddd36b49fe5080efbe160277ef546471.tar.gz cpython-b0274f2cddd36b49fe5080efbe160277ef546471.tar.bz2 | |
closes bpo-34056: Always return bytes from _HackedGetData.get_data(). (GH-8130)
* Always return bytes from _HackedGetData.get_data().
Ensure the imp.load_source shim always returns bytes by reopening the file in
binary mode if needed. Hash-based pycs have to receive the source code in bytes.
It's tempting to change imp.get_suffixes() to always return 'rb' as a mode, but
that breaks some stdlib tests and likely 3rdparty code, too.
Diffstat (limited to 'Misc')
| -rw-r--r-- | Misc/NEWS.d/next/Library/2018-07-05-22-45-46.bpo-34056.86isrU.rst | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/Misc/NEWS.d/next/Library/2018-07-05-22-45-46.bpo-34056.86isrU.rst b/Misc/NEWS.d/next/Library/2018-07-05-22-45-46.bpo-34056.86isrU.rst new file mode 100644 index 0000000..edc0135 --- /dev/null +++ b/Misc/NEWS.d/next/Library/2018-07-05-22-45-46.bpo-34056.86isrU.rst @@ -0,0 +1,3 @@ +Ensure the loader shim created by ``imp.load_module`` always returns bytes +from its ``get_data()`` function. This fixes using ``imp.load_module`` with +:pep:`552` hash-based pycs. |