summaryrefslogtreecommitdiffstats
path: root/Modules/_io
diff options
context:
space:
mode:
authorCharles-François Natali <neologix@free.fr>2011-10-05 17:53:43 (GMT)
committerCharles-François Natali <neologix@free.fr>2011-10-05 17:53:43 (GMT)
commit42c28cdd1dbebbf241c1828ffceabf7978ddf566 (patch)
treef0a0e094b0039c4092dc30090a85b8993a6d74fe /Modules/_io
parent1b7da519b09d8885272d323af982d36675419075 (diff)
downloadcpython-42c28cdd1dbebbf241c1828ffceabf7978ddf566.zip
cpython-42c28cdd1dbebbf241c1828ffceabf7978ddf566.tar.gz
cpython-42c28cdd1dbebbf241c1828ffceabf7978ddf566.tar.bz2
Issue #13070: Fix a crash when a TextIOWrapper caught in a reference cycle
would be finalized after the reference to its underlying BufferedRWPair's writer got cleared by the GC.
Diffstat (limited to 'Modules/_io')
-rw-r--r--Modules/_io/bufferedio.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/Modules/_io/bufferedio.c b/Modules/_io/bufferedio.c
index bd1aae5..c979ac2 100644
--- a/Modules/_io/bufferedio.c
+++ b/Modules/_io/bufferedio.c
@@ -2212,6 +2212,11 @@ bufferedrwpair_isatty(rwpair *self, PyObject *args)
static PyObject *
bufferedrwpair_closed_get(rwpair *self, void *context)
{
+ if (self->writer == NULL) {
+ PyErr_SetString(PyExc_RuntimeError,
+ "the BufferedRWPair object is being garbage-collected");
+ return NULL;
+ }
return PyObject_GetAttr((PyObject *) self->writer, _PyIO_str_closed);
}