summaryrefslogtreecommitdiffstats
path: root/Modules/_zstd/compressor.c
diff options
context:
space:
mode:
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>2025-05-23 22:18:08 (GMT)
committerGitHub <noreply@github.com>2025-05-23 22:18:08 (GMT)
commitf301af627ea5138726a85b5d34ea92bf6198bcad (patch)
treee94129cb4b2656c6715ae42a53f6851310ed3384 /Modules/_zstd/compressor.c
parent7476f90af2cf9207c792c0dc3ee9a5ca7b4fabfa (diff)
downloadcpython-f301af627ea5138726a85b5d34ea92bf6198bcad.zip
cpython-f301af627ea5138726a85b5d34ea92bf6198bcad.tar.gz
cpython-f301af627ea5138726a85b5d34ea92bf6198bcad.tar.bz2
[3.14] gh-132983: Slightly tweak error messages for _zstd compressor/decompressor options dict (GH-134601) (#134602)
gh-132983: Slightly tweak error messages for _zstd compressor/decompressor options dict (GH-134601) Slightly tweak error messages for options dict (cherry picked from commit f478331f98930d94f7efc741f3bed4b693d5cec1) Co-authored-by: Emma Smith <emma@emmatyping.dev>
Diffstat (limited to 'Modules/_zstd/compressor.c')
-rw-r--r--Modules/_zstd/compressor.c11
1 files changed, 5 insertions, 6 deletions
diff --git a/Modules/_zstd/compressor.c b/Modules/_zstd/compressor.c
index 8f93485..0f2967b 100644
--- a/Modules/_zstd/compressor.c
+++ b/Modules/_zstd/compressor.c
@@ -93,24 +93,23 @@ _zstd_set_c_parameters(ZstdCompressor *self, PyObject *level_or_options,
/* Check key type */
if (Py_TYPE(key) == mod_state->DParameter_type) {
PyErr_SetString(PyExc_TypeError,
- "Key of compression option dict should "
- "NOT be DecompressionParameter.");
+ "Key of compression options dict should "
+ "NOT be a DecompressionParameter attribute.");
return -1;
}
int key_v = PyLong_AsInt(key);
if (key_v == -1 && PyErr_Occurred()) {
PyErr_SetString(PyExc_ValueError,
- "Key of options dict should be a CompressionParameter attribute.");
+ "Key of options dict should be either a "
+ "CompressionParameter attribute or an int.");
return -1;
}
- // TODO(emmatyping): check bounds when there is a value error here for better
- // error message?
int value_v = PyLong_AsInt(value);
if (value_v == -1 && PyErr_Occurred()) {
PyErr_SetString(PyExc_ValueError,
- "Value of option dict should be an int.");
+ "Value of options dict should be an int.");
return -1;
}