summaryrefslogtreecommitdiffstats
path: root/Modules/cPickle.c
diff options
context:
space:
mode:
authorTim Peters <tim.peters@gmail.com>2003-02-02 17:26:40 (GMT)
committerTim Peters <tim.peters@gmail.com>2003-02-02 17:26:40 (GMT)
commit70b02d79f90cbe6524291b01c4828d37523cde97 (patch)
tree9e483d6cf82757e350cd321d851ad3922b62d337 /Modules/cPickle.c
parent6c54ef6884b00f6bcc23fe4beff0419ba94a2a75 (diff)
downloadcpython-70b02d79f90cbe6524291b01c4828d37523cde97.zip
cpython-70b02d79f90cbe6524291b01c4828d37523cde97.tar.gz
cpython-70b02d79f90cbe6524291b01c4828d37523cde97.tar.bz2
Beefed up the tests by putting in more "for proto in protocols:" outer
loops. Renamed DATA and BINDATA to DATA0 and DATA1. Included disassemblies, but noted why we can't test them. Added XXX comment to cPickle about a mysterious comment, where pickle and cPickle diverge in how they number PUT indices.
Diffstat (limited to 'Modules/cPickle.c')
-rw-r--r--Modules/cPickle.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/Modules/cPickle.c b/Modules/cPickle.c
index 00e6829..c284056 100644
--- a/Modules/cPickle.c
+++ b/Modules/cPickle.c
@@ -719,6 +719,11 @@ put2(Picklerobject *self, PyObject *ob)
goto finally;
/* Make sure memo keys are positive! */
+ /* XXX Why?
+ * XXX And does "positive" really mean non-negative?
+ * XXX pickle.py starts with PUT index 0, not 1. This makes for
+ * XXX gratuitous differences between the pickling modules.
+ */
p++;
if (!( py_ob_id = PyLong_FromVoidPtr(ob)))