diff options
author | Neal Norwitz <nnorwitz@gmail.com> | 2002-09-05 21:48:07 (GMT) |
---|---|---|
committer | Neal Norwitz <nnorwitz@gmail.com> | 2002-09-05 21:48:07 (GMT) |
commit | b567392bbf3c595a47b86ea4d6038af0ec28b383 (patch) | |
tree | d339de20d02348c0dbe03e0d40869997ddc505c0 /Modules/mmapmodule.c | |
parent | 7165af23e67d81607ee6dd3191a79001e7a8a4e0 (diff) | |
download | cpython-b567392bbf3c595a47b86ea4d6038af0ec28b383.zip cpython-b567392bbf3c595a47b86ea4d6038af0ec28b383.tar.gz cpython-b567392bbf3c595a47b86ea4d6038af0ec28b383.tar.bz2 |
SF bug # 585792, Invalid mmap crashes Python interpreter
Raise ValueError if user passes a size to mmap which is larger
than the file.
Diffstat (limited to 'Modules/mmapmodule.c')
-rw-r--r-- | Modules/mmapmodule.c | 12 |
1 files changed, 11 insertions, 1 deletions
diff --git a/Modules/mmapmodule.c b/Modules/mmapmodule.c index 2bb6edc..cff3c14 100644 --- a/Modules/mmapmodule.c +++ b/Modules/mmapmodule.c @@ -850,6 +850,9 @@ _GetMapSize(PyObject *o) static PyObject * new_mmap_object(PyObject *self, PyObject *args, PyObject *kwdict) { +#ifdef HAVE_FSTAT + struct stat st; +#endif mmap_object *m_obj; PyObject *map_size_obj = NULL; int map_size; @@ -890,7 +893,14 @@ new_mmap_object(PyObject *self, PyObject *args, PyObject *kwdict) return PyErr_Format(PyExc_ValueError, "mmap invalid access parameter."); } - + +#ifdef HAVE_FSTAT + if (fstat(fd, &st) == 0 && (size_t)map_size > st.st_size) { + PyErr_SetString(PyExc_ValueError, + "mmap length is greater than file size"); + return NULL; + } +#endif m_obj = PyObject_New (mmap_object, &mmap_object_type); if (m_obj == NULL) {return NULL;} m_obj->size = (size_t) map_size; |