diff options
| author | Ned Deily <nad@python.org> | 2016-02-15 05:51:24 (GMT) |
|---|---|---|
| committer | Ned Deily <nad@python.org> | 2016-02-15 05:51:24 (GMT) |
| commit | 1c2a7b59390911994694ba027c9579747d592f1b (patch) | |
| tree | fb75281b31e79ae73c7448271596fb0840e7201c /Modules | |
| parent | fdb959b8a30b24544386c6015fd1d63ba2f5d214 (diff) | |
| download | cpython-1c2a7b59390911994694ba027c9579747d592f1b.zip cpython-1c2a7b59390911994694ba027c9579747d592f1b.tar.gz cpython-1c2a7b59390911994694ba027c9579747d592f1b.tar.bz2 | |
Issue #25924: Avoid unnecessary serialization of getaddrinfo(3) calls on OS X
versions 10.5 or higher. Original patch by A. Jesse Jiryu Davis.
Diffstat (limited to 'Modules')
| -rw-r--r-- | Modules/socketmodule.c | 20 |
1 files changed, 18 insertions, 2 deletions
diff --git a/Modules/socketmodule.c b/Modules/socketmodule.c index ced9343..c02c5d9 100644 --- a/Modules/socketmodule.c +++ b/Modules/socketmodule.c @@ -82,6 +82,11 @@ Local naming conventions: */ #ifdef __APPLE__ +#include <AvailabilityMacros.h> +/* for getaddrinfo thread safety test on old versions of OS X */ +#ifndef MAC_OS_X_VERSION_10_5 +#define MAC_OS_X_VERSION_10_5 1050 +#endif /* * inet_aton is not available on OSX 10.3, yet we want to use a binary * that was build on 10.4 or later to work on that release, weak linking @@ -183,8 +188,19 @@ shutdown(how) -- shut down traffic in one or both directions\n\ #include <sys/param.h> #endif /* On systems on which getaddrinfo() is believed to not be thread-safe, - (this includes the getaddrinfo emulation) protect access with a lock. */ -#if defined(WITH_THREAD) && (defined(__APPLE__) || \ + (this includes the getaddrinfo emulation) protect access with a lock. + + getaddrinfo is thread-safe on Mac OS X 10.5 and later. Originally it was + a mix of code including an unsafe implementation from an old BSD's + libresolv. In 10.5 Apple reimplemented it as a safe IPC call to the + mDNSResponder process. 10.5 is the first be UNIX '03 certified, which + includes the requirement that getaddrinfo be thread-safe. + + See issue #25924 for details. + */ +#if defined(WITH_THREAD) && ( \ + (defined(__APPLE__) && \ + MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_X_VERSION_10_5) || \ (defined(__FreeBSD__) && __FreeBSD_version+0 < 503000) || \ defined(__OpenBSD__) || defined(__NetBSD__) || \ defined(__VMS) || !defined(HAVE_GETADDRINFO)) |