summaryrefslogtreecommitdiffstats
path: root/Modules
diff options
context:
space:
mode:
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>2022-03-20 14:51:11 (GMT)
committerGitHub <noreply@github.com>2022-03-20 14:51:11 (GMT)
commit4352ca234e979ad1c7158981addf899b119cd448 (patch)
tree5de0c4ac29404d4c35e8303646b1626b0578282f /Modules
parent87b3e202d46cdeb0a6b1ef041579a5ebc7c826a9 (diff)
downloadcpython-4352ca234e979ad1c7158981addf899b119cd448.zip
cpython-4352ca234e979ad1c7158981addf899b119cd448.tar.gz
cpython-4352ca234e979ad1c7158981addf899b119cd448.tar.bz2
bpo-42369: Fix thread safety of zipfile._SharedFile.tell (GH-26974)
The `_SharedFile` tracks its own virtual position into the file as `self._pos` and updates it after reading or seeking. `tell()` should return this position instead of calling into the underlying file object, since if multiple `_SharedFile` instances are being used concurrently on the same file, another one may have moved the real file position. Additionally, calling into the underlying `tell` may expose thread safety issues in the underlying file object because it was called without taking the lock. (cherry picked from commit e730ae7effe4f13b24f1b5fb1fca005709c86acb) Co-authored-by: Kevin Mehall <km@kevinmehall.net>
Diffstat (limited to 'Modules')
0 files changed, 0 insertions, 0 deletions