diff options
| author | Antoine Pitrou <solipsis@pitrou.net> | 2009-01-21 00:45:36 (GMT) |
|---|---|---|
| committer | Antoine Pitrou <solipsis@pitrou.net> | 2009-01-21 00:45:36 (GMT) |
| commit | e741cc607c226c76fef473bf772d42fc63269b9b (patch) | |
| tree | c7914f5e141059584cfc3ebea80b01009bb0ad3d /Modules | |
| parent | acdc84abcf106e4178d18363b899d0f4218008f4 (diff) | |
| download | cpython-e741cc607c226c76fef473bf772d42fc63269b9b.zip cpython-e741cc607c226c76fef473bf772d42fc63269b9b.tar.gz cpython-e741cc607c226c76fef473bf772d42fc63269b9b.tar.bz2 | |
Issue #5008: When a file is opened in append mode with the new IO library,
do an explicit seek to the end of file (so that e.g. tell() returns the
file size rather than 0). This is consistent with the behaviour of the
traditional 2.x file object.
Diffstat (limited to 'Modules')
| -rw-r--r-- | Modules/_fileio.c | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/Modules/_fileio.c b/Modules/_fileio.c index 2a86e07..2fc6de8 100644 --- a/Modules/_fileio.c +++ b/Modules/_fileio.c @@ -41,6 +41,9 @@ PyTypeObject PyFileIO_Type; #define PyFileIO_Check(op) (PyObject_TypeCheck((op), &PyFileIO_Type)) +static PyObject * +portable_lseek(int fd, PyObject *posobj, int whence); + /* Returns 0 on success, errno (which is < 0) on failure. */ static int internal_close(PyFileIOObject *self) @@ -296,6 +299,16 @@ fileio_init(PyObject *oself, PyObject *args, PyObject *kwds) goto error; } + if (append) { + /* For consistent behaviour, we explicitly seek to the + end of file (otherwise, it might be done only on the + first write()). */ + PyObject *pos = portable_lseek(self->fd, NULL, 2); + if (pos == NULL) + goto error; + Py_DECREF(pos); + } + goto done; error: |