diff options
| author | Victor Stinner <victor.stinner@gmail.com> | 2017-01-19 11:45:06 (GMT) |
|---|---|---|
| committer | Victor Stinner <victor.stinner@gmail.com> | 2017-01-19 11:45:06 (GMT) |
| commit | 91f0d4aa2fae249479e5ecdc76aee6f5c13d0994 (patch) | |
| tree | 0f1bb37047427be233dd1df8d6b3d2951c242ac2 /Objects/dictobject.c | |
| parent | 7dc6a5f50aa47d32a75941dcb091eabe7958b2a1 (diff) | |
| download | cpython-91f0d4aa2fae249479e5ecdc76aee6f5c13d0994.zip cpython-91f0d4aa2fae249479e5ecdc76aee6f5c13d0994.tar.gz cpython-91f0d4aa2fae249479e5ecdc76aee6f5c13d0994.tar.bz2 | |
Add a note explaining why dict_update() doesn't use METH_FASTCALL
Issue #29312.
Diffstat (limited to 'Objects/dictobject.c')
| -rw-r--r-- | Objects/dictobject.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/Objects/dictobject.c b/Objects/dictobject.c index 1a6eedd..f941486 100644 --- a/Objects/dictobject.c +++ b/Objects/dictobject.c @@ -2347,6 +2347,9 @@ dict_update_common(PyObject *self, PyObject *args, PyObject *kwds, return result; } +/* Note: dict.update() uses the METH_VARARGS|METH_KEYWORDS calling convention. + Using METH_FASTCALL would make dict.update(**dict2) calls slower, see the + issue #29312. */ static PyObject * dict_update(PyObject *self, PyObject *args, PyObject *kwds) { |