diff options
author | Sam Gross <colesbury@gmail.com> | 2024-05-09 18:52:27 (GMT) |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-05-09 18:52:27 (GMT) |
commit | 2402715e10d00ef60fad2948d8461559d084eb36 (patch) | |
tree | d51f944413b662d75594bbbe9cbcb0e0c0db6f22 /Objects/listobject.c | |
parent | 82abe75e77129bebb3c13d807e8040f6924194f6 (diff) | |
download | cpython-2402715e10d00ef60fad2948d8461559d084eb36.zip cpython-2402715e10d00ef60fad2948d8461559d084eb36.tar.gz cpython-2402715e10d00ef60fad2948d8461559d084eb36.tar.bz2 |
gh-118561: Fix crash involving list.extend in free-threaded build (#118723)
The `list_preallocate_exact` function did not zero initialize array
contents. In the free-threaded build, this could expose uninitialized
memory to concurrent readers between the call to
`list_preallocate_exact` and the filling of the array contents with
items.
Diffstat (limited to 'Objects/listobject.c')
-rw-r--r-- | Objects/listobject.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/Objects/listobject.c b/Objects/listobject.c index 3c4e2d2..7070165 100644 --- a/Objects/listobject.c +++ b/Objects/listobject.c @@ -192,6 +192,7 @@ list_preallocate_exact(PyListObject *self, Py_ssize_t size) return -1; } items = array->ob_item; + memset(items, 0, size * sizeof(PyObject *)); #else items = PyMem_New(PyObject*, size); if (items == NULL) { @@ -199,7 +200,7 @@ list_preallocate_exact(PyListObject *self, Py_ssize_t size) return -1; } #endif - self->ob_item = items; + FT_ATOMIC_STORE_PTR_RELEASE(self->ob_item, items); self->allocated = size; return 0; } |