diff options
author | scoder <stefan_ml@behnel.de> | 2023-11-03 11:02:39 (GMT) |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-11-03 11:02:39 (GMT) |
commit | 24ddaee5ca112063b460e72d31b3da551a02bf0a (patch) | |
tree | 24407ff8b7373cba709e1656900d3f53b5be2d24 /Objects/listobject.c | |
parent | d49aba5a7a3c695213810a9f82715809c6332df2 (diff) | |
download | cpython-24ddaee5ca112063b460e72d31b3da551a02bf0a.zip cpython-24ddaee5ca112063b460e72d31b3da551a02bf0a.tar.gz cpython-24ddaee5ca112063b460e72d31b3da551a02bf0a.tar.bz2 |
gh-106168: Revert the "size before item" setting (#111683)
gh-106168: Update the size only after setting the item, to avoid temporary inconsistencies.
Also remove the "what's new" sentence regarding the size setting since tuples cannot grow after allocation.
Diffstat (limited to 'Objects/listobject.c')
-rw-r--r-- | Objects/listobject.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Objects/listobject.c b/Objects/listobject.c index ad1840b..af006ef 100644 --- a/Objects/listobject.c +++ b/Objects/listobject.c @@ -956,8 +956,8 @@ list_extend(PyListObject *self, PyObject *iterable) if (Py_SIZE(self) < self->allocated) { /* steals ref */ Py_ssize_t len = Py_SIZE(self); - Py_SET_SIZE(self, len + 1); PyList_SET_ITEM(self, len, item); + Py_SET_SIZE(self, len + 1); } else { if (_PyList_AppendTakeRef(self, item) < 0) |