summaryrefslogtreecommitdiffstats
path: root/Objects/object.c
diff options
context:
space:
mode:
authorSerhiy Storchaka <storchaka@gmail.com>2017-12-03 20:12:11 (GMT)
committerGitHub <noreply@github.com>2017-12-03 20:12:11 (GMT)
commit1fb72d2ad243c965d4432b4e93884064001a2607 (patch)
tree00296a976e5e386a94c0bb6f8ed535b1c30621f5 /Objects/object.c
parenteea3cc1ef0dec0af193eedb4c1164263fbdfd8cc (diff)
downloadcpython-1fb72d2ad243c965d4432b4e93884064001a2607.zip
cpython-1fb72d2ad243c965d4432b4e93884064001a2607.tar.gz
cpython-1fb72d2ad243c965d4432b4e93884064001a2607.tar.bz2
bpo-32137: The repr of deeply nested dict now raises a RecursionError (#4570)
instead of crashing due to a stack overflow. This perhaps will fix similar problems in other extension types.
Diffstat (limited to 'Objects/object.c')
-rw-r--r--Objects/object.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/Objects/object.c b/Objects/object.c
index 674180d..a0d651d 100644
--- a/Objects/object.c
+++ b/Objects/object.c
@@ -463,7 +463,12 @@ PyObject_Repr(PyObject *v)
assert(!PyErr_Occurred());
#endif
+ /* It is possible for a type to have a tp_repr representation that loops
+ infinitely. */
+ if (Py_EnterRecursiveCall(" while getting the repr of an object"))
+ return NULL;
res = (*v->ob_type->tp_repr)(v);
+ Py_LeaveRecursiveCall();
if (res == NULL)
return NULL;
if (!PyUnicode_Check(res)) {