summaryrefslogtreecommitdiffstats
path: root/Objects/obmalloc.c
diff options
context:
space:
mode:
authorT. Wouters <thomas@python.org>2017-04-02 03:20:24 (GMT)
committerGitHub <noreply@github.com>2017-04-02 03:20:24 (GMT)
commit553275d125478a6563dde7523f4f28c92f1861b4 (patch)
tree1f2c8282fcf7a3cb821d281befbd2bb38fde971d /Objects/obmalloc.c
parent51fc7e3d6a29de7b3142e51f8caf4d31f7ac72a0 (diff)
downloadcpython-553275d125478a6563dde7523f4f28c92f1861b4.zip
cpython-553275d125478a6563dde7523f4f28c92f1861b4.tar.gz
cpython-553275d125478a6563dde7523f4f28c92f1861b4.tar.bz2
bpo-29941: Assert fixes (#886) (#956)
Make a non-Py_DEBUG, asserts-enabled build of CPython possible. This means making sure helper functions are defined when NDEBUG is not defined, not just when Py_DEBUG is defined. Also fix a division-by-zero in obmalloc.c that went unnoticed because in Py_DEBUG mode, elsize is never zero. (cherry picked from commit a00c3fd12d421e41b769debd7df717d17b0deed5 and 06bb4873d6a9ac303701d08a851d6cd9a51e02a3)
Diffstat (limited to 'Objects/obmalloc.c')
-rw-r--r--Objects/obmalloc.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/Objects/obmalloc.c b/Objects/obmalloc.c
index 7cc889f..9dd8421 100644
--- a/Objects/obmalloc.c
+++ b/Objects/obmalloc.c
@@ -1176,7 +1176,7 @@ _PyObject_Alloc(int use_calloc, void *ctx, size_t nelem, size_t elsize)
_Py_AllocatedBlocks++;
- assert(nelem <= PY_SSIZE_T_MAX / elsize);
+ assert(elsize == 0 || nelem <= PY_SSIZE_T_MAX / elsize);
nbytes = nelem * elsize;
#ifdef WITH_VALGRIND
@@ -2233,7 +2233,9 @@ _PyObject_DebugMallocStats(FILE *out)
if (p->ref.count == 0) {
/* currently unused */
+#ifdef Py_DEBUG
assert(pool_is_in_list(p, arenas[i].freepools));
+#endif
continue;
}
++numpools[sz];