summaryrefslogtreecommitdiffstats
path: root/Objects
diff options
context:
space:
mode:
authorBenjamin Peterson <benjamin@python.org>2010-10-12 22:57:59 (GMT)
committerBenjamin Peterson <benjamin@python.org>2010-10-12 22:57:59 (GMT)
commit5c4bfc4af070c5c62f76cf3c2d23a19e7c794c4e (patch)
treebf62941930ba384c45a44d598e24566caa24e070 /Objects
parent11b1f3dac14f72d7406c96fd7b749ebd8cc16bc9 (diff)
downloadcpython-5c4bfc4af070c5c62f76cf3c2d23a19e7c794c4e.zip
cpython-5c4bfc4af070c5c62f76cf3c2d23a19e7c794c4e.tar.gz
cpython-5c4bfc4af070c5c62f76cf3c2d23a19e7c794c4e.tar.bz2
prefer clearing global objects to obscure module.__dict__ bugs #10068
Diffstat (limited to 'Objects')
-rw-r--r--Objects/moduleobject.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/Objects/moduleobject.c b/Objects/moduleobject.c
index 3a95261..1e3349d 100644
--- a/Objects/moduleobject.c
+++ b/Objects/moduleobject.c
@@ -335,10 +335,7 @@ module_dealloc(PyModuleObject *m)
if (m->md_def && m->md_def->m_free)
m->md_def->m_free(m);
if (m->md_dict != NULL) {
- /* If we are the only ones holding a reference, we can clear
- the dictionary. */
- if (Py_REFCNT(m->md_dict) == 1)
- _PyModule_Clear((PyObject *)m);
+ _PyModule_Clear((PyObject *)m);
Py_DECREF(m->md_dict);
}
if (m->md_state != NULL)