diff options
author | Barry Warsaw <barry@python.org> | 2016-01-11 19:44:59 (GMT) |
---|---|---|
committer | Barry Warsaw <barry@python.org> | 2016-01-11 19:44:59 (GMT) |
commit | 607965eb7e11b9405e23175d1f8aee3647425a80 (patch) | |
tree | 8b8ee72c4065b46dd8a58c164d7fb1b0ceb398e6 /Objects | |
parent | f65395c8c27170e3ce7b161ec43cf9947bb7f5fe (diff) | |
download | cpython-607965eb7e11b9405e23175d1f8aee3647425a80.zip cpython-607965eb7e11b9405e23175d1f8aee3647425a80.tar.gz cpython-607965eb7e11b9405e23175d1f8aee3647425a80.tar.bz2 |
Comment out two tests that won't pass now after reverting the typeobject.c
change. Also, as per further discussion, we'll just remove the regressing
code in typeobject.c
Diffstat (limited to 'Objects')
-rw-r--r-- | Objects/typeobject.c | 24 |
1 files changed, 0 insertions, 24 deletions
diff --git a/Objects/typeobject.c b/Objects/typeobject.c index 1ddcc59..8a5623f 100644 --- a/Objects/typeobject.c +++ b/Objects/typeobject.c @@ -3279,30 +3279,6 @@ reduce_2(PyObject *obj) if (names == NULL) goto end; assert(names == Py_None || PyList_Check(names)); -#if 0 - /* 2016-01-11 barry - This clause breaks at least three packages which - rely on Cython: kivy, pysam, and s3ql. Cython may be doing - something funny under the hood, but as this is clearly a regression - and the rationale for this prohibition is suspect, I am commenting - this out. Perhaps it should just be removed. See issue #22995 for - details. - */ - if (required_state) { - Py_ssize_t basicsize = PyBaseObject_Type.tp_basicsize; - if (obj->ob_type->tp_dictoffset) - basicsize += sizeof(PyObject *); - if (obj->ob_type->tp_weaklistoffset) - basicsize += sizeof(PyObject *); - if (names != Py_None) - basicsize += sizeof(PyObject *) * Py_SIZE(names); - if (obj->ob_type->tp_basicsize > basicsize) { - PyErr_Format(PyExc_TypeError, - "can't pickle %.200s objects", - Py_TYPE(obj)->tp_name); - goto end; - } - } -#endif if (names != Py_None) { slots = PyDict_New(); |