diff options
author | Greg Price <gnprice@gmail.com> | 2019-09-10 09:29:26 (GMT) |
---|---|---|
committer | Benjamin Peterson <benjamin@python.org> | 2019-09-10 09:29:26 (GMT) |
commit | 1ad0c776cb640be9f19c8019bbf34bb4aba312ad (patch) | |
tree | 8a8b417f7ccc6761385b95227dcd883519111241 /PCbuild | |
parent | 5b00dd8fa8e28acbf1ad7ce6da52464f33dbf991 (diff) | |
download | cpython-1ad0c776cb640be9f19c8019bbf34bb4aba312ad.zip cpython-1ad0c776cb640be9f19c8019bbf34bb4aba312ad.tar.gz cpython-1ad0c776cb640be9f19c8019bbf34bb4aba312ad.tar.bz2 |
bpo-38043: Move unicodedata.normalize tests into test_unicodedata. (GH-15712)
Having these in a separate file from the one that's named after the
module in the usual way makes it very easy to miss them when looking
for tests for these two functions.
(In fact when working recently on is_normalized, I'd been surprised to
see no tests for it here and concluded the function had evaded being
tested at all. I'd gone as far as to write up some tests myself
before I spotted this other file.)
Mostly this just means moving all the one file's code into the other,
and moving code from the module toplevel to inside the test class to
keep it tidily separate from the rest of the file's code.
There's one substantive change, which reduces by a bit the amount of
code to be moved: we drop the `x > sys.maxunicode` conditional and all
the `RangeError` logic behind it. Now if that condition ever occurs
it will cause an error at `chr(x)`, and a test failure. That's the
right result because, since PEP 393 in Python 3.3, there is no longer
such a thing as an "unsupported character".
Diffstat (limited to 'PCbuild')
-rw-r--r-- | PCbuild/lib.pyproj | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/PCbuild/lib.pyproj b/PCbuild/lib.pyproj index 0ddeef3..401e207 100644 --- a/PCbuild/lib.pyproj +++ b/PCbuild/lib.pyproj @@ -1191,7 +1191,6 @@ <Compile Include="test\test_netrc.py" /> <Compile Include="test\test_nis.py" /> <Compile Include="test\test_nntplib.py" /> - <Compile Include="test\test_normalization.py" /> <Compile Include="test\test_ntpath.py" /> <Compile Include="test\test_numeric_tower.py" /> <Compile Include="test\test_opcodes.py" /> |