summaryrefslogtreecommitdiffstats
path: root/Python/compile.c
diff options
context:
space:
mode:
authorShantanu <12621235+hauntsaninja@users.noreply.github.com>2022-12-21 03:29:02 (GMT)
committerGitHub <noreply@github.com>2022-12-21 03:29:02 (GMT)
commit79311cbfe718f17c89bab67d7f89da3931bfa2ac (patch)
tree7135bc6630fb49f9e7cb5c173c39283626acc808 /Python/compile.c
parentc615286e8576f2555d4380f38a966c300805b1a5 (diff)
downloadcpython-79311cbfe718f17c89bab67d7f89da3931bfa2ac.zip
cpython-79311cbfe718f17c89bab67d7f89da3931bfa2ac.tar.gz
cpython-79311cbfe718f17c89bab67d7f89da3931bfa2ac.tar.bz2
gh-85267: Improvements to inspect.signature __text_signature__ handling (#98796)
This makes a couple related changes to inspect.signature's behaviour when parsing a signature from `__text_signature__`. First, `inspect.signature` is documented as only raising ValueError or TypeError. However, in some cases, we could raise RuntimeError. This PR changes that, thereby fixing #83685. (Note that the new ValueErrors in RewriteSymbolics are caught and then reraised with a message) Second, `inspect.signature` could randomly drop parameters that it didn't understand (corresponding to `return None` in the `p` function). This is the core issue in #85267. I think this is very surprising behaviour and it seems better to fail outright. Third, adding this new failure broke a couple tests. To fix them (and to e.g. allow `inspect.signature(select.epoll.register)` as in #85267), I add constant folding of a couple binary operations to RewriteSymbolics. (There's some discussion of making signature expression evaluation arbitrary powerful in #68155. I think that's out of scope. The additional constant folding here is pretty straightforward, useful, and not much of a slippery slope) Fourth, while #85267 is incorrect about the cause of the issue, it turns out if you had consecutive newlines in __text_signature__, you'd get `tokenize.TokenError`. Finally, the `if name is invalid:` code path was dead, since `parse_name` never returned `invalid`.
Diffstat (limited to 'Python/compile.c')
0 files changed, 0 insertions, 0 deletions