diff options
| author | Eric Snow <ericsnowcurrently@gmail.com> | 2017-09-14 18:18:12 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-09-14 18:18:12 (GMT) |
| commit | d393c1b227f22fb9af66040b2b367c99a4d1fa9a (patch) | |
| tree | 2bb1bb4f8b59d3c6ffa8dabbc43dc30357e2b25f /Python/importdl.c | |
| parent | 8dcf22f442320e4c1a5408e67b4c9002ad105f17 (diff) | |
| download | cpython-d393c1b227f22fb9af66040b2b367c99a4d1fa9a.zip cpython-d393c1b227f22fb9af66040b2b367c99a4d1fa9a.tar.gz cpython-d393c1b227f22fb9af66040b2b367c99a4d1fa9a.tar.bz2 | |
bpo-28411: Isolate PyInterpreterState.modules (#3575)
A bunch of code currently uses PyInterpreterState.modules directly instead of PyImport_GetModuleDict(). This complicates efforts to make changes relative to sys.modules. This patch switches to using PyImport_GetModuleDict() uniformly. Also, a number of related uses of sys.modules are updated for uniformity for the same reason.
Note that this code was already reviewed and merged as part of #1638. I reverted that and am now splitting it up into more focused parts.
Diffstat (limited to 'Python/importdl.c')
| -rw-r--r-- | Python/importdl.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/Python/importdl.c b/Python/importdl.c index d8656b9..32fb7e1 100644 --- a/Python/importdl.c +++ b/Python/importdl.c @@ -215,7 +215,8 @@ _PyImport_LoadDynamicModuleWithSpec(PyObject *spec, FILE *fp) else Py_INCREF(path); - if (_PyImport_FixupExtensionObject(m, name_unicode, path) < 0) + PyObject *modules = PyImport_GetModuleDict(); + if (_PyImport_FixupExtensionObject(m, name_unicode, path, modules) < 0) goto error; Py_DECREF(name_unicode); |