diff options
| author | Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> | 2018-12-08 14:39:37 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-12-08 14:39:37 (GMT) |
| commit | 25555e0fbed15f809a247c7e16ab9d0a0088f806 (patch) | |
| tree | ea790ba8966889dc230ebe1f22c0321ea331e605 /Python/sysmodule.c | |
| parent | 12b9fb603eea9298c835bae5b8742db4fa52892e (diff) | |
| download | cpython-25555e0fbed15f809a247c7e16ab9d0a0088f806.zip cpython-25555e0fbed15f809a247c7e16ab9d0a0088f806.tar.gz cpython-25555e0fbed15f809a247c7e16ab9d0a0088f806.tar.bz2 | |
bpo-35441: Remove dead and buggy code related to PyList_SetItem(). (GH-11033)
In _localemodule.c and selectmodule.c, remove dead code that would
cause double decrefs if run.
In addition, replace PyList_SetItem() with PyList_SET_ITEM() in cases
where a new list is populated and there is no possibility of an error.
In addition, check if the list changed size in the loop in array_array_fromlist().
(cherry picked from commit 99d56b53560b3867844472ae381fb3f858760621)
Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Diffstat (limited to 'Python/sysmodule.c')
| -rw-r--r-- | Python/sysmodule.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Python/sysmodule.c b/Python/sysmodule.c index b09268b..7d1493c 100644 --- a/Python/sysmodule.c +++ b/Python/sysmodule.c @@ -2109,7 +2109,7 @@ makepathobject(const wchar_t *path, wchar_t delim) Py_DECREF(v); return NULL; } - PyList_SetItem(v, i, w); + PyList_SET_ITEM(v, i, w); if (*p == '\0') break; path = p+1; |