summaryrefslogtreecommitdiffstats
path: root/Python
diff options
context:
space:
mode:
authorEric Snow <ericsnowcurrently@gmail.com>2024-06-14 19:29:09 (GMT)
committerGitHub <noreply@github.com>2024-06-14 19:29:09 (GMT)
commitb2e71ff4f8fa5b7d8117dd8125137aee3d01f015 (patch)
tree76ffcadb4db306b4776329e3cf197fe0cd7894bc /Python
parent05df063ad80becc1ba6bd07d67b55b5965f32375 (diff)
downloadcpython-b2e71ff4f8fa5b7d8117dd8125137aee3d01f015.zip
cpython-b2e71ff4f8fa5b7d8117dd8125137aee3d01f015.tar.gz
cpython-b2e71ff4f8fa5b7d8117dd8125137aee3d01f015.tar.bz2
gh-120161: Fix a Crash in the _datetime Module (gh-120182)
In gh-120009 I used an atexit hook to finalize the _datetime module's static types at interpreter shutdown. However, atexit hooks are executed very early in finalization, which is a problem in the few cases where a subclass of one of those static types is still alive until the final GC collection. The static builtin types don't have this probably because they are finalized toward the end, after the final GC collection. To avoid the problem for _datetime, I have applied a similar approach here. Also, credit goes to @mgorny and @neonene for the new tests. FYI, I would have liked to take a slightly cleaner approach with managed static types, but wanted to get a smaller fix in first for the sake of backporting. I'll circle back to the cleaner approach with a future change on the main branch.
Diffstat (limited to 'Python')
-rw-r--r--Python/pylifecycle.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/Python/pylifecycle.c b/Python/pylifecycle.c
index cbdf5c1..3639cf6 100644
--- a/Python/pylifecycle.c
+++ b/Python/pylifecycle.c
@@ -1818,6 +1818,7 @@ flush_std_files(void)
static void
finalize_interp_types(PyInterpreterState *interp)
{
+ _PyTypes_FiniExtTypes(interp);
_PyUnicode_FiniTypes(interp);
_PySys_FiniTypes(interp);
_PyXI_FiniTypes(interp);