summaryrefslogtreecommitdiffstats
path: root/Python
diff options
context:
space:
mode:
authorMark Shannon <mark@hotpy.org>2024-03-26 09:35:11 (GMT)
committerGitHub <noreply@github.com>2024-03-26 09:35:11 (GMT)
commitbf82f77957a31c3731b4ec470c406f5708ca9ba3 (patch)
tree89b5e94311e0ae020754155b243be49607af4bf4 /Python
parent61599a48f52e951d8813877ee311d2a830ba2cd8 (diff)
downloadcpython-bf82f77957a31c3731b4ec470c406f5708ca9ba3.zip
cpython-bf82f77957a31c3731b4ec470c406f5708ca9ba3.tar.gz
cpython-bf82f77957a31c3731b4ec470c406f5708ca9ba3.tar.bz2
GH-116422: Tier2 hot/cold splitting (GH-116813)
Splits the "cold" path, deopts and exits, from the "hot" path, reducing the size of most jitted instructions, at the cost of slower exits.
Diffstat (limited to 'Python')
-rw-r--r--Python/bytecodes.c139
-rw-r--r--Python/ceval.c57
-rw-r--r--Python/ceval_macros.h6
-rw-r--r--Python/executor_cases.c.h738
-rw-r--r--Python/generated_cases.c.h122
-rw-r--r--Python/jit.c37
-rw-r--r--Python/optimizer.c379
-rw-r--r--Python/optimizer_analysis.c50
-rw-r--r--Python/optimizer_cases.c.h57
9 files changed, 834 insertions, 751 deletions
diff --git a/Python/bytecodes.c b/Python/bytecodes.c
index 476975d..5cd9db9 100644
--- a/Python/bytecodes.c
+++ b/Python/bytecodes.c
@@ -179,7 +179,7 @@ dummy_func(
uintptr_t code_version = _PyFrame_GetCode(frame)->_co_instrumentation_version;
if (code_version != global_version) {
if (_Py_Instrument(_PyFrame_GetCode(frame), tstate->interp)) {
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
next_instr = this_instr;
}
@@ -206,7 +206,13 @@ dummy_func(
inst(LOAD_FAST_CHECK, (-- value)) {
value = GETLOCAL(oparg);
- ERROR_IF(value == NULL, unbound_local_error);
+ if (value == NULL) {
+ _PyEval_FormatExcCheckArg(tstate, PyExc_UnboundLocalError,
+ UNBOUNDLOCAL_ERROR_MSG,
+ PyTuple_GetItem(_PyFrame_GetCode(frame)->co_localsplusnames, oparg)
+ );
+ ERROR_IF(1, error);
+ }
Py_INCREF(value);
}
@@ -275,7 +281,7 @@ dummy_func(
if (PyGen_Check(receiver)) {
PyErr_SetObject(PyExc_StopIteration, value);
if (monitor_stop_iteration(tstate, frame, this_instr)) {
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
PyErr_SetRaisedException(NULL);
}
@@ -290,7 +296,7 @@ dummy_func(
if (PyGen_Check(receiver) || PyCoro_CheckExact(receiver)) {
PyErr_SetObject(PyExc_StopIteration, value);
if (monitor_stop_iteration(tstate, frame, this_instr)) {
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
PyErr_SetRaisedException(NULL);
}
@@ -826,7 +832,7 @@ dummy_func(
int err = _Py_call_instrumentation_arg(
tstate, PY_MONITORING_EVENT_PY_RETURN,
frame, this_instr, retval);
- if (err) GOTO_ERROR(error);
+ if (err) ERROR_NO_POP();
STACK_SHRINK(1);
assert(EMPTY());
_PyFrame_SetStackPointer(frame, stack_pointer);
@@ -850,7 +856,7 @@ dummy_func(
int err = _Py_call_instrumentation_arg(
tstate, PY_MONITORING_EVENT_PY_RETURN,
frame, this_instr, retval);
- if (err) GOTO_ERROR(error);
+ if (err) ERROR_NO_POP();
Py_INCREF(retval);
assert(EMPTY());
_PyFrame_SetStackPointer(frame, stack_pointer);
@@ -906,7 +912,7 @@ dummy_func(
if (PyAsyncGen_CheckExact(aiter)) {
awaitable = type->tp_as_async->am_anext(aiter);
if (awaitable == NULL) {
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
} else {
if (type->tp_as_async != NULL){
@@ -916,7 +922,7 @@ dummy_func(
if (getter != NULL) {
next_iter = (*getter)(aiter);
if (next_iter == NULL) {
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
}
else {
@@ -924,7 +930,7 @@ dummy_func(
"'async for' requires an iterator with "
"__anext__ method, got %.100s",
type->tp_name);
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
awaitable = _PyCoro_GetAwaitableIter(next_iter);
@@ -936,7 +942,7 @@ dummy_func(
Py_TYPE(next_iter)->tp_name);
Py_DECREF(next_iter);
- GOTO_ERROR(error);
+ ERROR_NO_POP();
} else {
Py_DECREF(next_iter);
}
@@ -1018,7 +1024,7 @@ dummy_func(
JUMPBY(oparg);
}
else {
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
}
Py_DECREF(v);
@@ -1054,7 +1060,7 @@ dummy_func(
int err = _Py_call_instrumentation_arg(
tstate, PY_MONITORING_EVENT_PY_YIELD,
frame, this_instr, retval);
- if (err) GOTO_ERROR(error);
+ if (err) ERROR_NO_POP();
tstate->exc_info = gen->gi_exc_state.previous_item;
gen->gi_exc_state.previous_item = NULL;
_Py_LeaveRecursiveCallPy(tstate);
@@ -1108,7 +1114,7 @@ dummy_func(
else {
assert(PyLong_Check(lasti));
_PyErr_SetString(tstate, PyExc_SystemError, "lasti is not an int");
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
}
assert(exc && PyExceptionInstance_Check(exc));
@@ -1184,7 +1190,7 @@ dummy_func(
if (ns == NULL) {
_PyErr_Format(tstate, PyExc_SystemError,
"no locals when deleting %R", name);
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
err = PyObject_DelItem(ns, name);
// Can't use ERROR_IF here.
@@ -1192,7 +1198,7 @@ dummy_func(
_PyEval_FormatExcCheckArg(tstate, PyExc_NameError,
NAME_ERROR_MSG,
name);
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
}
@@ -1312,12 +1318,12 @@ dummy_func(
int err = PyDict_Pop(GLOBALS(), name, NULL);
// Can't use ERROR_IF here.
if (err < 0) {
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
if (err == 0) {
_PyEval_FormatExcCheckArg(tstate, PyExc_NameError,
NAME_ERROR_MSG, name);
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
}
@@ -1334,21 +1340,21 @@ dummy_func(
inst(LOAD_FROM_DICT_OR_GLOBALS, (mod_or_class_dict -- v)) {
PyObject *name = GETITEM(FRAME_CO_NAMES, oparg);
if (PyMapping_GetOptionalItem(mod_or_class_dict, name, &v) < 0) {
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
if (v == NULL) {
if (PyDict_GetItemRef(GLOBALS(), name, &v) < 0) {
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
if (v == NULL) {
if (PyMapping_GetOptionalItem(BUILTINS(), name, &v) < 0) {
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
if (v == NULL) {
_PyEval_FormatExcCheckArg(
tstate, PyExc_NameError,
NAME_ERROR_MSG, name);
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
}
}
@@ -1364,21 +1370,21 @@ dummy_func(
}
PyObject *name = GETITEM(FRAME_CO_NAMES, oparg);
if (PyMapping_GetOptionalItem(mod_or_class_dict, name, &v) < 0) {
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
if (v == NULL) {
if (PyDict_GetItemRef(GLOBALS(), name, &v) < 0) {
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
if (v == NULL) {
if (PyMapping_GetOptionalItem(BUILTINS(), name, &v) < 0) {
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
if (v == NULL) {
_PyEval_FormatExcCheckArg(
tstate, PyExc_NameError,
NAME_ERROR_MSG, name);
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
}
}
@@ -1494,7 +1500,13 @@ dummy_func(
inst(DELETE_FAST, (--)) {
PyObject *v = GETLOCAL(oparg);
- ERROR_IF(v == NULL, unbound_local_error);
+ if (v == NULL) {
+ _PyEval_FormatExcCheckArg(tstate, PyExc_UnboundLocalError,
+ UNBOUNDLOCAL_ERROR_MSG,
+ PyTuple_GetItem(_PyFrame_GetCode(frame)->co_localsplusnames, oparg)
+ );
+ ERROR_IF(1, error);
+ }
SETLOCAL(oparg, NULL);
}
@@ -1504,7 +1516,7 @@ dummy_func(
PyObject *initial = GETLOCAL(oparg);
PyObject *cell = PyCell_New(initial);
if (cell == NULL) {
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
SETLOCAL(oparg, cell);
}
@@ -1516,7 +1528,7 @@ dummy_func(
// Fortunately we don't need its superpower.
if (oldobj == NULL) {
_PyEval_FormatExcUnbound(tstate, _PyFrame_GetCode(frame), oparg);
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
PyCell_SET(cell, NULL);
Py_DECREF(oldobj);
@@ -1528,14 +1540,14 @@ dummy_func(
assert(oparg >= 0 && oparg < _PyFrame_GetCode(frame)->co_nlocalsplus);
name = PyTuple_GET_ITEM(_PyFrame_GetCode(frame)->co_localsplusnames, oparg);
if (PyMapping_GetOptionalItem(class_dict, name, &value) < 0) {
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
if (!value) {
PyObject *cell = GETLOCAL(oparg);
value = PyCell_GET(cell);
if (value == NULL) {
_PyEval_FormatExcUnbound(tstate, _PyFrame_GetCode(frame), oparg);
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
Py_INCREF(value);
}
@@ -1615,7 +1627,7 @@ dummy_func(
inst(BUILD_SET, (values[oparg] -- set)) {
set = PySet_New(NULL);
if (set == NULL)
- GOTO_ERROR(error);
+ ERROR_NO_POP();
int err = 0;
for (int i = 0; i < oparg; i++) {
PyObject *item = values[i];
@@ -1662,12 +1674,8 @@ dummy_func(
}
inst(BUILD_CONST_KEY_MAP, (values[oparg], keys -- map)) {
- if (!PyTuple_CheckExact(keys) ||
- PyTuple_GET_SIZE(keys) != (Py_ssize_t)oparg) {
- _PyErr_SetString(tstate, PyExc_SystemError,
- "bad BUILD_CONST_KEY_MAP keys argument");
- GOTO_ERROR(error); // Pop the keys and values.
- }
+ assert(PyTuple_CheckExact(keys));
+ assert(PyTuple_GET_SIZE(keys) == (Py_ssize_t)oparg);
map = _PyDict_FromItems(
&PyTuple_GET_ITEM(keys, 0), 1,
values, 1, oparg);
@@ -2502,7 +2510,7 @@ dummy_func(
_PyErr_SetString(tstate, PyExc_TypeError,
"cannot 'yield from' a coroutine object "
"in a non-coroutine generator");
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
iter = iterable;
}
@@ -2513,7 +2521,7 @@ dummy_func(
/* `iterable` is not a generator. */
iter = PyObject_GetIter(iterable);
if (iter == NULL) {
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
DECREF_INPUTS();
}
@@ -2550,7 +2558,7 @@ dummy_func(
if (next == NULL) {
if (_PyErr_Occurred(tstate)) {
if (!_PyErr_ExceptionMatches(tstate, PyExc_StopIteration)) {
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
monitor_raise(tstate, frame, this_instr);
_PyErr_Clear(tstate);
@@ -2573,7 +2581,7 @@ dummy_func(
if (next == NULL) {
if (_PyErr_Occurred(tstate)) {
if (!_PyErr_ExceptionMatches(tstate, PyExc_StopIteration)) {
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
_PyErr_Clear(tstate);
}
@@ -2599,7 +2607,7 @@ dummy_func(
else {
if (_PyErr_Occurred(tstate)) {
if (!_PyErr_ExceptionMatches(tstate, PyExc_StopIteration)) {
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
monitor_raise(tstate, frame, this_instr);
_PyErr_Clear(tstate);
@@ -2779,7 +2787,7 @@ dummy_func(
"asynchronous context manager protocol",
Py_TYPE(mgr)->tp_name);
}
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
exit = _PyObject_LookupSpecial(mgr, &_Py_ID(__aexit__));
if (exit == NULL) {
@@ -2791,7 +2799,7 @@ dummy_func(
Py_TYPE(mgr)->tp_name);
}
Py_DECREF(enter);
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
DECREF_INPUTS();
res = PyObject_CallNoArgs(enter);
@@ -2814,7 +2822,7 @@ dummy_func(
"context manager protocol",
Py_TYPE(mgr)->tp_name);
}
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
exit = _PyObject_LookupSpecial(mgr, &_Py_ID(__exit__));
if (exit == NULL) {
@@ -2826,7 +2834,7 @@ dummy_func(
Py_TYPE(mgr)->tp_name);
}
Py_DECREF(enter);
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
DECREF_INPUTS();
res = PyObject_CallNoArgs(enter);
@@ -3075,7 +3083,7 @@ dummy_func(
// The frame has stolen all the arguments from the stack,
// so there is no need to clean them up.
if (new_frame == NULL) {
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
frame->return_offset = (uint16_t)(next_instr - this_instr);
DISPATCH_INLINED(new_frame);
@@ -3298,7 +3306,7 @@ dummy_func(
STAT_INC(CALL, hit);
PyObject *self = _PyType_NewManagedObject(tp);
if (self == NULL) {
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
Py_DECREF(tp);
_PyInterpreterFrame *shim = _PyFrame_PushTrampolineUnchecked(
@@ -3335,7 +3343,7 @@ dummy_func(
PyErr_Format(PyExc_TypeError,
"__init__() should return None, not '%.200s'",
Py_TYPE(should_be_none)->tp_name);
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
}
@@ -3472,7 +3480,7 @@ dummy_func(
PyObject *arg = args[0];
Py_ssize_t len_i = PyObject_Length(arg);
if (len_i < 0) {
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
res = PyLong_FromSsize_t(len_i);
assert((res != NULL) ^ (_PyErr_Occurred(tstate) != NULL));
@@ -3498,7 +3506,7 @@ dummy_func(
PyObject *inst = args[0];
int retval = PyObject_IsInstance(inst, cls);
if (retval < 0) {
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
res = PyBool_FromLong(retval);
assert((res != NULL) ^ (_PyErr_Occurred(tstate) != NULL));
@@ -3712,7 +3720,7 @@ dummy_func(
// The frame has stolen all the arguments from the stack,
// so there is no need to clean them up.
if (new_frame == NULL) {
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
assert(next_instr - this_instr == 1);
frame->return_offset = 1;
@@ -3760,11 +3768,11 @@ dummy_func(
assert(kwargs == NULL || PyDict_CheckExact(kwargs));
if (!PyTuple_CheckExact(callargs)) {
if (check_args_iterable(tstate, func, callargs) < 0) {
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
PyObject *tuple = PySequence_Tuple(callargs);
if (tuple == NULL) {
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
Py_SETREF(callargs, tuple);
}
@@ -3776,7 +3784,7 @@ dummy_func(
int err = _Py_call_instrumentation_2args(
tstate, PY_MONITORING_EVENT_CALL,
frame, this_instr, func, arg);
- if (err) GOTO_ERROR(error);
+ if (err) ERROR_NO_POP();
result = PyObject_Call(func, callargs, kwargs);
if (!PyFunction_Check(func) && !PyMethod_Check(func)) {
@@ -3810,7 +3818,7 @@ dummy_func(
// Need to manually shrink the stack since we exit with DISPATCH_INLINED.
STACK_SHRINK(oparg + 3);
if (new_frame == NULL) {
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
assert(next_instr - this_instr == 1);
frame->return_offset = 1;
@@ -3831,7 +3839,7 @@ dummy_func(
Py_DECREF(codeobj);
if (func_obj == NULL) {
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
_PyFunction_SetVersion(
@@ -3871,7 +3879,7 @@ dummy_func(
PyFunctionObject *func = (PyFunctionObject *)frame->f_funcobj;
PyGenObject *gen = (PyGenObject *)_Py_MakeCoro(func);
if (gen == NULL) {
- GOTO_ERROR(error);
+ ERROR_NO_POP();
}
assert(EMPTY());
_PyFrame_SetStackPointer(frame, stack_pointer);
@@ -4169,7 +4177,7 @@ dummy_func(
if (optimized < 0) {
Py_DECREF(previous);
tstate->previous_executor = Py_None;
- ERROR_IF(1, error);
+ GOTO_UNWIND();
}
GOTO_TIER_ONE(target);
}
@@ -4199,6 +4207,19 @@ dummy_func(
frame->instr_ptr = (_Py_CODEUNIT *)instr_ptr;
}
+ tier2 op(_DEOPT, (--)) {
+ EXIT_TO_TIER1();
+ }
+
+ tier2 op(_SIDE_EXIT, (--)) {
+ EXIT_TO_TRACE();
+ }
+
+ tier2 op(_ERROR_POP_N, (unused[oparg] --)) {
+ SYNC_SP();
+ GOTO_UNWIND();
+ }
+
// END BYTECODES //
}
diff --git a/Python/ceval.c b/Python/ceval.c
index b35a321..cd51011 100644
--- a/Python/ceval.c
+++ b/Python/ceval.c
@@ -642,7 +642,6 @@ int _Py_CheckRecursiveCallPy(
return 0;
}
-
static const _Py_CODEUNIT _Py_INTERPRETER_TRAMPOLINE_INSTRUCTIONS[] = {
/* Put a NOP at the start, so that the IP points into
* the code, rather than before it */
@@ -850,15 +849,6 @@ resume_frame:
or goto error. */
Py_UNREACHABLE();
-unbound_local_error:
- {
- _PyEval_FormatExcCheckArg(tstate, PyExc_UnboundLocalError,
- UNBOUNDLOCAL_ERROR_MSG,
- PyTuple_GetItem(_PyFrame_GetCode(frame)->co_localsplusnames, oparg)
- );
- goto error;
- }
-
pop_4_error:
STACK_SHRINK(1);
pop_3_error:
@@ -980,12 +970,6 @@ enter_tier_two:
#undef GOTO_ERROR
#define GOTO_ERROR(LABEL) goto LABEL ## _tier_two
-#undef DEOPT_IF
-#define DEOPT_IF(COND, INSTNAME) \
- if ((COND)) { \
- goto deoptimize;\
- }
-
#ifdef Py_STATS
// Disable these macros that apply to Tier 1 stats when we are in Tier 2
#undef STAT_INC
@@ -1013,6 +997,7 @@ enter_tier_two:
#endif
assert(next_uop->opcode == _START_EXECUTOR || next_uop->opcode == _COLD_EXIT);
+tier2_dispatch:
for (;;) {
uopcode = next_uop->opcode;
#ifdef Py_DEBUG
@@ -1054,24 +1039,7 @@ enter_tier_two:
}
}
-// Jump here from ERROR_IF(..., unbound_local_error)
-unbound_local_error_tier_two:
- _PyEval_FormatExcCheckArg(tstate, PyExc_UnboundLocalError,
- UNBOUNDLOCAL_ERROR_MSG,
- PyTuple_GetItem(_PyFrame_GetCode(frame)->co_localsplusnames, oparg)
- );
- goto error_tier_two;
-
-// JUMP to any of these from ERROR_IF(..., error)
-pop_4_error_tier_two:
- STACK_SHRINK(1);
-pop_3_error_tier_two:
- STACK_SHRINK(1);
-pop_2_error_tier_two:
- STACK_SHRINK(1);
-pop_1_error_tier_two:
- STACK_SHRINK(1);
-error_tier_two:
+jump_to_error_target:
#ifdef Py_DEBUG
if (lltrace >= 2) {
printf("Error: [UOp ");
@@ -1081,15 +1049,28 @@ error_tier_two:
_PyOpcode_OpName[frame->instr_ptr->op.code]);
}
#endif
+ assert (next_uop[-1].format == UOP_FORMAT_JUMP);
+ uint16_t target = uop_get_error_target(&next_uop[-1]);
+ next_uop = current_executor->trace + target;
+ goto tier2_dispatch;
+
+error_tier_two:
OPT_HIST(trace_uop_execution_counter, trace_run_length_hist);
+ assert(next_uop[-1].format == UOP_FORMAT_TARGET);
frame->return_offset = 0; // Don't leave this random
_PyFrame_SetStackPointer(frame, stack_pointer);
Py_DECREF(current_executor);
tstate->previous_executor = NULL;
goto resume_with_error;
-// Jump here from DEOPT_IF()
-deoptimize:
+jump_to_jump_target:
+ assert(next_uop[-1].format == UOP_FORMAT_JUMP);
+ target = uop_get_jump_target(&next_uop[-1]);
+ next_uop = current_executor->trace + target;
+ goto tier2_dispatch;
+
+exit_to_tier1:
+ assert(next_uop[-1].format == UOP_FORMAT_TARGET);
next_instr = next_uop[-1].target + _PyCode_CODE(_PyFrame_GetCode(frame));
#ifdef Py_DEBUG
if (lltrace >= 2) {
@@ -1105,8 +1086,8 @@ deoptimize:
tstate->previous_executor = NULL;
DISPATCH();
-// Jump here from EXIT_IF()
-side_exit:
+exit_to_trace:
+ assert(next_uop[-1].format == UOP_FORMAT_EXIT);
OPT_HIST(trace_uop_execution_counter, trace_run_length_hist);
UOP_STAT_INC(uopcode, miss);
uint32_t exit_index = next_uop[-1].exit_index;
diff --git a/Python/ceval_macros.h b/Python/ceval_macros.h
index 22992aa..f2536ed 100644
--- a/Python/ceval_macros.h
+++ b/Python/ceval_macros.h
@@ -423,3 +423,9 @@ do { \
#define CURRENT_OPARG() (next_uop[-1].oparg)
#define CURRENT_OPERAND() (next_uop[-1].operand)
+
+#define JUMP_TO_JUMP_TARGET() goto jump_to_jump_target
+#define JUMP_TO_ERROR() goto jump_to_error_target
+#define GOTO_UNWIND() goto error_tier_two
+#define EXIT_TO_TRACE() goto exit_to_trace
+#define EXIT_TO_TIER1() goto exit_to_tier1
diff --git a/Python/executor_cases.c.h b/Python/executor_cases.c.h
index a55daa2..224b600 100644
--- a/Python/executor_cases.c.h
+++ b/Python/executor_cases.c.h
@@ -14,23 +14,29 @@
case _RESUME_CHECK: {
#if defined(__EMSCRIPTEN__)
- if (_Py_emscripten_signal_clock == 0) goto deoptimize;
+ if (_Py_emscripten_signal_clock == 0) JUMP_TO_JUMP_TARGET();
_Py_emscripten_signal_clock -= Py_EMSCRIPTEN_SIGNAL_HANDLING;
#endif
uintptr_t eval_breaker = _Py_atomic_load_uintptr_relaxed(&tstate->eval_breaker);
uintptr_t version = _PyFrame_GetCode(frame)->_co_instrumentation_version;
assert((version & _PY_EVAL_EVENTS_MASK) == 0);
- if (eval_breaker != version) goto deoptimize;
+ if (eval_breaker != version) JUMP_TO_JUMP_TARGET();
break;
}
- /* _INSTRUMENTED_RESUME is not a viable micro-op for tier 2 */
+ /* _INSTRUMENTED_RESUME is not a viable micro-op for tier 2 because it is instrumented */
case _LOAD_FAST_CHECK: {
PyObject *value;
oparg = CURRENT_OPARG();
value = GETLOCAL(oparg);
- if (value == NULL) goto unbound_local_error_tier_two;
+ if (value == NULL) {
+ _PyEval_FormatExcCheckArg(tstate, PyExc_UnboundLocalError,
+ UNBOUNDLOCAL_ERROR_MSG,
+ PyTuple_GetItem(_PyFrame_GetCode(frame)->co_localsplusnames, oparg)
+ );
+ if (1) JUMP_TO_ERROR();
+ }
Py_INCREF(value);
stack_pointer[0] = value;
stack_pointer += 1;
@@ -287,7 +293,7 @@
value = stack_pointer[-1];
res = PyNumber_Negative(value);
Py_DECREF(value);
- if (res == NULL) goto pop_1_error_tier_two;
+ if (res == NULL) JUMP_TO_ERROR();
stack_pointer[-1] = res;
break;
}
@@ -308,7 +314,7 @@
value = stack_pointer[-1];
int err = PyObject_IsTrue(value);
Py_DECREF(value);
- if (err < 0) goto pop_1_error_tier_two;
+ if (err < 0) JUMP_TO_ERROR();
res = err ? Py_True : Py_False;
stack_pointer[-1] = res;
break;
@@ -317,7 +323,7 @@
case _TO_BOOL_BOOL: {
PyObject *value;
value = stack_pointer[-1];
- if (!PyBool_Check(value)) goto side_exit;
+ if (!PyBool_Check(value)) JUMP_TO_JUMP_TARGET();
STAT_INC(TO_BOOL, hit);
break;
}
@@ -326,7 +332,7 @@
PyObject *value;
PyObject *res;
value = stack_pointer[-1];
- if (!PyLong_CheckExact(value)) goto side_exit;
+ if (!PyLong_CheckExact(value)) JUMP_TO_JUMP_TARGET();
STAT_INC(TO_BOOL, hit);
if (_PyLong_IsZero((PyLongObject *)value)) {
assert(_Py_IsImmortal(value));
@@ -344,7 +350,7 @@
PyObject *value;
PyObject *res;
value = stack_pointer[-1];
- if (!PyList_CheckExact(value)) goto side_exit;
+ if (!PyList_CheckExact(value)) JUMP_TO_JUMP_TARGET();
STAT_INC(TO_BOOL, hit);
res = Py_SIZE(value) ? Py_True : Py_False;
Py_DECREF(value);
@@ -357,7 +363,7 @@
PyObject *res;
value = stack_pointer[-1];
// This one is a bit weird, because we expect *some* failures:
- if (!Py_IsNone(value)) goto side_exit;
+ if (!Py_IsNone(value)) JUMP_TO_JUMP_TARGET();
STAT_INC(TO_BOOL, hit);
res = Py_False;
stack_pointer[-1] = res;
@@ -368,7 +374,7 @@
PyObject *value;
PyObject *res;
value = stack_pointer[-1];
- if (!PyUnicode_CheckExact(value)) goto side_exit;
+ if (!PyUnicode_CheckExact(value)) JUMP_TO_JUMP_TARGET();
STAT_INC(TO_BOOL, hit);
if (value == &_Py_STR(empty)) {
assert(_Py_IsImmortal(value));
@@ -399,7 +405,7 @@
value = stack_pointer[-1];
res = PyNumber_Invert(value);
Py_DECREF(value);
- if (res == NULL) goto pop_1_error_tier_two;
+ if (res == NULL) JUMP_TO_ERROR();
stack_pointer[-1] = res;
break;
}
@@ -409,8 +415,8 @@
PyObject *left;
right = stack_pointer[-1];
left = stack_pointer[-2];
- if (!PyLong_CheckExact(left)) goto side_exit;
- if (!PyLong_CheckExact(right)) goto side_exit;
+ if (!PyLong_CheckExact(left)) JUMP_TO_JUMP_TARGET();
+ if (!PyLong_CheckExact(right)) JUMP_TO_JUMP_TARGET();
break;
}
@@ -424,7 +430,7 @@
res = _PyLong_Multiply((PyLongObject *)left, (PyLongObject *)right);
_Py_DECREF_SPECIALIZED(right, (destructor)PyObject_Free);
_Py_DECREF_SPECIALIZED(left, (destructor)PyObject_Free);
- if (res == NULL) goto pop_2_error_tier_two;
+ if (res == NULL) JUMP_TO_ERROR();
stack_pointer[-2] = res;
stack_pointer += -1;
break;
@@ -440,7 +446,7 @@
res = _PyLong_Add((PyLongObject *)left, (PyLongObject *)right);
_Py_DECREF_SPECIALIZED(right, (destructor)PyObject_Free);
_Py_DECREF_SPECIALIZED(left, (destructor)PyObject_Free);
- if (res == NULL) goto pop_2_error_tier_two;
+ if (res == NULL) JUMP_TO_ERROR();
stack_pointer[-2] = res;
stack_pointer += -1;
break;
@@ -456,7 +462,7 @@
res = _PyLong_Subtract((PyLongObject *)left, (PyLongObject *)right);
_Py_DECREF_SPECIALIZED(right, (destructor)PyObject_Free);
_Py_DECREF_SPECIALIZED(left, (destructor)PyObject_Free);
- if (res == NULL) goto pop_2_error_tier_two;
+ if (res == NULL) JUMP_TO_ERROR();
stack_pointer[-2] = res;
stack_pointer += -1;
break;
@@ -467,8 +473,8 @@
PyObject *left;
right = stack_pointer[-1];
left = stack_pointer[-2];
- if (!PyFloat_CheckExact(left)) goto side_exit;
- if (!PyFloat_CheckExact(right)) goto side_exit;
+ if (!PyFloat_CheckExact(left)) JUMP_TO_JUMP_TARGET();
+ if (!PyFloat_CheckExact(right)) JUMP_TO_JUMP_TARGET();
break;
}
@@ -525,8 +531,8 @@
PyObject *left;
right = stack_pointer[-1];
left = stack_pointer[-2];
- if (!PyUnicode_CheckExact(left)) goto side_exit;
- if (!PyUnicode_CheckExact(right)) goto side_exit;
+ if (!PyUnicode_CheckExact(left)) JUMP_TO_JUMP_TARGET();
+ if (!PyUnicode_CheckExact(right)) JUMP_TO_JUMP_TARGET();
break;
}
@@ -540,7 +546,7 @@
res = PyUnicode_Concat(left, right);
_Py_DECREF_SPECIALIZED(left, _PyUnicode_ExactDealloc);
_Py_DECREF_SPECIALIZED(right, _PyUnicode_ExactDealloc);
- if (res == NULL) goto pop_2_error_tier_two;
+ if (res == NULL) JUMP_TO_ERROR();
stack_pointer[-2] = res;
stack_pointer += -1;
break;
@@ -555,7 +561,7 @@
res = PyObject_GetItem(container, sub);
Py_DECREF(container);
Py_DECREF(sub);
- if (res == NULL) goto pop_2_error_tier_two;
+ if (res == NULL) JUMP_TO_ERROR();
stack_pointer[-2] = res;
stack_pointer += -1;
break;
@@ -580,7 +586,7 @@
Py_DECREF(slice);
}
Py_DECREF(container);
- if (res == NULL) goto pop_3_error_tier_two;
+ if (res == NULL) JUMP_TO_ERROR();
stack_pointer[-3] = res;
stack_pointer += -2;
break;
@@ -606,7 +612,7 @@
}
Py_DECREF(v);
Py_DECREF(container);
- if (err) goto pop_4_error_tier_two;
+ if (err) JUMP_TO_ERROR();
stack_pointer += -4;
break;
}
@@ -617,12 +623,12 @@
PyObject *res;
sub = stack_pointer[-1];
list = stack_pointer[-2];
- if (!PyLong_CheckExact(sub)) goto deoptimize;
- if (!PyList_CheckExact(list)) goto deoptimize;
+ if (!PyLong_CheckExact(sub)) JUMP_TO_JUMP_TARGET();
+ if (!PyList_CheckExact(list)) JUMP_TO_JUMP_TARGET();
// Deopt unless 0 <= sub < PyList_Size(list)
- if (!_PyLong_IsNonNegativeCompact((PyLongObject *)sub)) goto deoptimize;
+ if (!_PyLong_IsNonNegativeCompact((PyLongObject *)sub)) JUMP_TO_JUMP_TARGET();
Py_ssize_t index = ((PyLongObject*)sub)->long_value.ob_digit[0];
- if (index >= PyList_GET_SIZE(list)) goto deoptimize;
+ if (index >= PyList_GET_SIZE(list)) JUMP_TO_JUMP_TARGET();
STAT_INC(BINARY_SUBSCR, hit);
res = PyList_GET_ITEM(list, index);
assert(res != NULL);
@@ -640,14 +646,14 @@
PyObject *res;
sub = stack_pointer[-1];
str = stack_pointer[-2];
- if (!PyLong_CheckExact(sub)) goto deoptimize;
- if (!PyUnicode_CheckExact(str)) goto deoptimize;
- if (!_PyLong_IsNonNegativeCompact((PyLongObject *)sub)) goto deoptimize;
+ if (!PyLong_CheckExact(sub)) JUMP_TO_JUMP_TARGET();
+ if (!PyUnicode_CheckExact(str)) JUMP_TO_JUMP_TARGET();
+ if (!_PyLong_IsNonNegativeCompact((PyLongObject *)sub)) JUMP_TO_JUMP_TARGET();
Py_ssize_t index = ((PyLongObject*)sub)->long_value.ob_digit[0];
- if (PyUnicode_GET_LENGTH(str) <= index) goto deoptimize;
+ if (PyUnicode_GET_LENGTH(str) <= index) JUMP_TO_JUMP_TARGET();
// Specialize for reading an ASCII character from any string:
Py_UCS4 c = PyUnicode_READ_CHAR(str, index);
- if (Py_ARRAY_LENGTH(_Py_SINGLETON(strings).ascii) <= c) goto deoptimize;
+ if (Py_ARRAY_LENGTH(_Py_SINGLETON(strings).ascii) <= c) JUMP_TO_JUMP_TARGET();
STAT_INC(BINARY_SUBSCR, hit);
res = (PyObject*)&_Py_SINGLETON(strings).ascii[c];
_Py_DECREF_SPECIALIZED(sub, (destructor)PyObject_Free);
@@ -663,12 +669,12 @@
PyObject *res;
sub = stack_pointer[-1];
tuple = stack_pointer[-2];
- if (!PyLong_CheckExact(sub)) goto deoptimize;
- if (!PyTuple_CheckExact(tuple)) goto deoptimize;
+ if (!PyLong_CheckExact(sub)) JUMP_TO_JUMP_TARGET();
+ if (!PyTuple_CheckExact(tuple)) JUMP_TO_JUMP_TARGET();
// Deopt unless 0 <= sub < PyTuple_Size(list)
- if (!_PyLong_IsNonNegativeCompact((PyLongObject *)sub)) goto deoptimize;
+ if (!_PyLong_IsNonNegativeCompact((PyLongObject *)sub)) JUMP_TO_JUMP_TARGET();
Py_ssize_t index = ((PyLongObject*)sub)->long_value.ob_digit[0];
- if (index >= PyTuple_GET_SIZE(tuple)) goto deoptimize;
+ if (index >= PyTuple_GET_SIZE(tuple)) JUMP_TO_JUMP_TARGET();
STAT_INC(BINARY_SUBSCR, hit);
res = PyTuple_GET_ITEM(tuple, index);
assert(res != NULL);
@@ -686,7 +692,7 @@
PyObject *res;
sub = stack_pointer[-1];
dict = stack_pointer[-2];
- if (!PyDict_CheckExact(dict)) goto deoptimize;
+ if (!PyDict_CheckExact(dict)) JUMP_TO_JUMP_TARGET();
STAT_INC(BINARY_SUBSCR, hit);
int rc = PyDict_GetItemRef(dict, sub, &res);
if (rc == 0) {
@@ -694,14 +700,14 @@
}
Py_DECREF(dict);
Py_DECREF(sub);
- if (rc <= 0) goto pop_2_error_tier_two;
+ if (rc <= 0) JUMP_TO_ERROR();
// not found or error
stack_pointer[-2] = res;
stack_pointer += -1;
break;
}
- /* _BINARY_SUBSCR_GETITEM is not a viable micro-op for tier 2 */
+ /* _BINARY_SUBSCR_GETITEM is not a viable micro-op for tier 2 because it uses the 'this_instr' variable */
case _LIST_APPEND: {
PyObject *v;
@@ -709,7 +715,7 @@
oparg = CURRENT_OPARG();
v = stack_pointer[-1];
list = stack_pointer[-2 - (oparg-1)];
- if (_PyList_AppendTakeRef((PyListObject *)list, v) < 0) goto pop_1_error_tier_two;
+ if (_PyList_AppendTakeRef((PyListObject *)list, v) < 0) JUMP_TO_ERROR();
stack_pointer += -1;
break;
}
@@ -722,7 +728,7 @@
set = stack_pointer[-2 - (oparg-1)];
int err = PySet_Add(set, v);
Py_DECREF(v);
- if (err) goto pop_1_error_tier_two;
+ if (err) JUMP_TO_ERROR();
stack_pointer += -1;
break;
}
@@ -739,7 +745,7 @@
Py_DECREF(v);
Py_DECREF(container);
Py_DECREF(sub);
- if (err) goto pop_3_error_tier_two;
+ if (err) JUMP_TO_ERROR();
stack_pointer += -3;
break;
}
@@ -751,13 +757,13 @@
sub = stack_pointer[-1];
list = stack_pointer[-2];
value = stack_pointer[-3];
- if (!PyLong_CheckExact(sub)) goto deoptimize;
- if (!PyList_CheckExact(list)) goto deoptimize;
+ if (!PyLong_CheckExact(sub)) JUMP_TO_JUMP_TARGET();
+ if (!PyList_CheckExact(list)) JUMP_TO_JUMP_TARGET();
// Ensure nonnegative, zero-or-one-digit ints.
- if (!_PyLong_IsNonNegativeCompact((PyLongObject *)sub)) goto deoptimize;
+ if (!_PyLong_IsNonNegativeCompact((PyLongObject *)sub)) JUMP_TO_JUMP_TARGET();
Py_ssize_t index = ((PyLongObject*)sub)->long_value.ob_digit[0];
// Ensure index < len(list)
- if (index >= PyList_GET_SIZE(list)) goto deoptimize;
+ if (index >= PyList_GET_SIZE(list)) JUMP_TO_JUMP_TARGET();
STAT_INC(STORE_SUBSCR, hit);
PyObject *old_value = PyList_GET_ITEM(list, index);
PyList_SET_ITEM(list, index, value);
@@ -776,11 +782,11 @@
sub = stack_pointer[-1];
dict = stack_pointer[-2];
value = stack_pointer[-3];
- if (!PyDict_CheckExact(dict)) goto deoptimize;
+ if (!PyDict_CheckExact(dict)) JUMP_TO_JUMP_TARGET();
STAT_INC(STORE_SUBSCR, hit);
int err = _PyDict_SetItem_Take2((PyDictObject *)dict, sub, value);
Py_DECREF(dict);
- if (err) goto pop_3_error_tier_two;
+ if (err) JUMP_TO_ERROR();
stack_pointer += -3;
break;
}
@@ -794,7 +800,7 @@
int err = PyObject_DelItem(container, sub);
Py_DECREF(container);
Py_DECREF(sub);
- if (err) goto pop_2_error_tier_two;
+ if (err) JUMP_TO_ERROR();
stack_pointer += -2;
break;
}
@@ -807,7 +813,7 @@
assert(oparg <= MAX_INTRINSIC_1);
res = _PyIntrinsics_UnaryFunctions[oparg].func(tstate, value);
Py_DECREF(value);
- if (res == NULL) goto pop_1_error_tier_two;
+ if (res == NULL) JUMP_TO_ERROR();
stack_pointer[-1] = res;
break;
}
@@ -823,7 +829,7 @@
res = _PyIntrinsics_BinaryFunctions[oparg].func(tstate, value2, value1);
Py_DECREF(value2);
Py_DECREF(value1);
- if (res == NULL) goto pop_2_error_tier_two;
+ if (res == NULL) JUMP_TO_ERROR();
stack_pointer[-2] = res;
stack_pointer += -1;
break;
@@ -855,9 +861,9 @@
break;
}
- /* _INSTRUMENTED_RETURN_VALUE is not a viable micro-op for tier 2 */
+ /* _INSTRUMENTED_RETURN_VALUE is not a viable micro-op for tier 2 because it is instrumented */
- /* _INSTRUMENTED_RETURN_CONST is not a viable micro-op for tier 2 */
+ /* _INSTRUMENTED_RETURN_CONST is not a viable micro-op for tier 2 because it is instrumented */
case _GET_AITER: {
PyObject *obj;
@@ -874,11 +880,11 @@
"__aiter__ method, got %.100s",
type->tp_name);
Py_DECREF(obj);
- if (true) goto pop_1_error_tier_two;
+ if (true) JUMP_TO_ERROR();
}
iter = (*getter)(obj);
Py_DECREF(obj);
- if (iter == NULL) goto pop_1_error_tier_two;
+ if (iter == NULL) JUMP_TO_ERROR();
if (Py_TYPE(iter)->tp_as_async == NULL ||
Py_TYPE(iter)->tp_as_async->am_anext == NULL) {
_PyErr_Format(tstate, PyExc_TypeError,
@@ -886,7 +892,7 @@
"that does not implement __anext__: %.100s",
Py_TYPE(iter)->tp_name);
Py_DECREF(iter);
- if (true) goto pop_1_error_tier_two;
+ if (true) JUMP_TO_ERROR();
}
stack_pointer[-1] = iter;
break;
@@ -902,7 +908,7 @@
if (PyAsyncGen_CheckExact(aiter)) {
awaitable = type->tp_as_async->am_anext(aiter);
if (awaitable == NULL) {
- GOTO_ERROR(error);
+ JUMP_TO_ERROR();
}
} else {
if (type->tp_as_async != NULL){
@@ -911,7 +917,7 @@
if (getter != NULL) {
next_iter = (*getter)(aiter);
if (next_iter == NULL) {
- GOTO_ERROR(error);
+ JUMP_TO_ERROR();
}
}
else {
@@ -919,7 +925,7 @@
"'async for' requires an iterator with "
"__anext__ method, got %.100s",
type->tp_name);
- GOTO_ERROR(error);
+ JUMP_TO_ERROR();
}
awaitable = _PyCoro_GetAwaitableIter(next_iter);
if (awaitable == NULL) {
@@ -929,7 +935,7 @@
"from __anext__: %.100s",
Py_TYPE(next_iter)->tp_name);
Py_DECREF(next_iter);
- GOTO_ERROR(error);
+ JUMP_TO_ERROR();
} else {
Py_DECREF(next_iter);
}
@@ -962,16 +968,16 @@
/* The code below jumps to `error` if `iter` is NULL. */
}
}
- if (iter == NULL) goto pop_1_error_tier_two;
+ if (iter == NULL) JUMP_TO_ERROR();
stack_pointer[-1] = iter;
break;
}
- /* _SEND is not a viable micro-op for tier 2 */
+ /* _SEND is not a viable micro-op for tier 2 because it uses the 'this_instr' variable */
- /* _SEND_GEN is not a viable micro-op for tier 2 */
+ /* _SEND_GEN is not a viable micro-op for tier 2 because it uses the 'this_instr' variable */
- /* _INSTRUMENTED_YIELD_VALUE is not a viable micro-op for tier 2 */
+ /* _INSTRUMENTED_YIELD_VALUE is not a viable micro-op for tier 2 because it is instrumented */
case _POP_EXCEPT: {
PyObject *exc_value;
@@ -992,11 +998,11 @@
case _LOAD_BUILD_CLASS: {
PyObject *bc;
- if (PyMapping_GetOptionalItem(BUILTINS(), &_Py_ID(__build_class__), &bc) < 0) goto error_tier_two;
+ if (PyMapping_GetOptionalItem(BUILTINS(), &_Py_ID(__build_class__), &bc) < 0) JUMP_TO_ERROR();
if (bc == NULL) {
_PyErr_SetString(tstate, PyExc_NameError,
"__build_class__ not found");
- if (true) goto error_tier_two;
+ if (true) JUMP_TO_ERROR();
}
stack_pointer[0] = bc;
stack_pointer += 1;
@@ -1014,14 +1020,14 @@
_PyErr_Format(tstate, PyExc_SystemError,
"no locals found when storing %R", name);
Py_DECREF(v);
- if (true) goto pop_1_error_tier_two;
+ if (true) JUMP_TO_ERROR();
}
if (PyDict_CheckExact(ns))
err = PyDict_SetItem(ns, name, v);
else
err = PyObject_SetItem(ns, name, v);
Py_DECREF(v);
- if (err) goto pop_1_error_tier_two;
+ if (err) JUMP_TO_ERROR();
stack_pointer += -1;
break;
}
@@ -1034,7 +1040,7 @@
if (ns == NULL) {
_PyErr_Format(tstate, PyExc_SystemError,
"no locals when deleting %R", name);
- GOTO_ERROR(error);
+ JUMP_TO_ERROR();
}
err = PyObject_DelItem(ns, name);
// Can't use ERROR_IF here.
@@ -1042,7 +1048,7 @@
_PyEval_FormatExcCheckArg(tstate, PyExc_NameError,
NAME_ERROR_MSG,
name);
- GOTO_ERROR(error);
+ JUMP_TO_ERROR();
}
break;
}
@@ -1054,7 +1060,7 @@
PyObject **top = stack_pointer + oparg - 1;
int res = _PyEval_UnpackIterable(tstate, seq, oparg, -1, top);
Py_DECREF(seq);
- if (res == 0) goto pop_1_error_tier_two;
+ if (res == 0) JUMP_TO_ERROR();
stack_pointer += -1 + oparg;
break;
}
@@ -1066,8 +1072,8 @@
oparg = CURRENT_OPARG();
seq = stack_pointer[-1];
assert(oparg == 2);
- if (!PyTuple_CheckExact(seq)) goto deoptimize;
- if (PyTuple_GET_SIZE(seq) != 2) goto deoptimize;
+ if (!PyTuple_CheckExact(seq)) JUMP_TO_JUMP_TARGET();
+ if (PyTuple_GET_SIZE(seq) != 2) JUMP_TO_JUMP_TARGET();
STAT_INC(UNPACK_SEQUENCE, hit);
val0 = Py_NewRef(PyTuple_GET_ITEM(seq, 0));
val1 = Py_NewRef(PyTuple_GET_ITEM(seq, 1));
@@ -1084,8 +1090,8 @@
oparg = CURRENT_OPARG();
seq = stack_pointer[-1];
values = &stack_pointer[-1];
- if (!PyTuple_CheckExact(seq)) goto deoptimize;
- if (PyTuple_GET_SIZE(seq) != oparg) goto deoptimize;
+ if (!PyTuple_CheckExact(seq)) JUMP_TO_JUMP_TARGET();
+ if (PyTuple_GET_SIZE(seq) != oparg) JUMP_TO_JUMP_TARGET();
STAT_INC(UNPACK_SEQUENCE, hit);
PyObject **items = _PyTuple_ITEMS(seq);
for (int i = oparg; --i >= 0; ) {
@@ -1102,8 +1108,8 @@
oparg = CURRENT_OPARG();
seq = stack_pointer[-1];
values = &stack_pointer[-1];
- if (!PyList_CheckExact(seq)) goto deoptimize;
- if (PyList_GET_SIZE(seq) != oparg) goto deoptimize;
+ if (!PyList_CheckExact(seq)) JUMP_TO_JUMP_TARGET();
+ if (PyList_GET_SIZE(seq) != oparg) JUMP_TO_JUMP_TARGET();
STAT_INC(UNPACK_SEQUENCE, hit);
PyObject **items = _PyList_ITEMS(seq);
for (int i = oparg; --i >= 0; ) {
@@ -1122,7 +1128,7 @@
PyObject **top = stack_pointer + totalargs - 1;
int res = _PyEval_UnpackIterable(tstate, seq, oparg & 0xFF, oparg >> 8, top);
Py_DECREF(seq);
- if (res == 0) goto pop_1_error_tier_two;
+ if (res == 0) JUMP_TO_ERROR();
stack_pointer += (oparg >> 8) + (oparg & 0xFF);
break;
}
@@ -1137,7 +1143,7 @@
int err = PyObject_SetAttr(owner, name, v);
Py_DECREF(v);
Py_DECREF(owner);
- if (err) goto pop_2_error_tier_two;
+ if (err) JUMP_TO_ERROR();
stack_pointer += -2;
break;
}
@@ -1149,7 +1155,7 @@
PyObject *name = GETITEM(FRAME_CO_NAMES, oparg);
int err = PyObject_DelAttr(owner, name);
Py_DECREF(owner);
- if (err) goto pop_1_error_tier_two;
+ if (err) JUMP_TO_ERROR();
stack_pointer += -1;
break;
}
@@ -1161,7 +1167,7 @@
PyObject *name = GETITEM(FRAME_CO_NAMES, oparg);
int err = PyDict_SetItem(GLOBALS(), name, v);
Py_DECREF(v);
- if (err) goto pop_1_error_tier_two;
+ if (err) JUMP_TO_ERROR();
stack_pointer += -1;
break;
}
@@ -1172,12 +1178,12 @@
int err = PyDict_Pop(GLOBALS(), name, NULL);
// Can't use ERROR_IF here.
if (err < 0) {
- GOTO_ERROR(error);
+ JUMP_TO_ERROR();
}
if (err == 0) {
_PyEval_FormatExcCheckArg(tstate, PyExc_NameError,
NAME_ERROR_MSG, name);
- GOTO_ERROR(error);
+ JUMP_TO_ERROR();
}
break;
}
@@ -1188,7 +1194,7 @@
if (locals == NULL) {
_PyErr_SetString(tstate, PyExc_SystemError,
"no locals found");
- if (true) goto error_tier_two;
+ if (true) JUMP_TO_ERROR();
}
Py_INCREF(locals);
stack_pointer[0] = locals;
@@ -1203,21 +1209,21 @@
mod_or_class_dict = stack_pointer[-1];
PyObject *name = GETITEM(FRAME_CO_NAMES, oparg);
if (PyMapping_GetOptionalItem(mod_or_class_dict, name, &v) < 0) {
- GOTO_ERROR(error);
+ JUMP_TO_ERROR();
}
if (v == NULL) {
if (PyDict_GetItemRef(GLOBALS(), name, &v) < 0) {
- GOTO_ERROR(error);
+ JUMP_TO_ERROR();
}
if (v == NULL) {
if (PyMapping_GetOptionalItem(BUILTINS(), name, &v) < 0) {
- GOTO_ERROR(error);
+ JUMP_TO_ERROR();
}
if (v == NULL) {
_PyEval_FormatExcCheckArg(
tstate, PyExc_NameError,
NAME_ERROR_MSG, name);
- GOTO_ERROR(error);
+ JUMP_TO_ERROR();
}
}
}
@@ -1226,39 +1232,7 @@
break;
}
- case _LOAD_NAME: {
- PyObject *v;
- oparg = CURRENT_OPARG();
- PyObject *mod_or_class_dict = LOCALS();
- if (mod_or_class_dict == NULL) {
- _PyErr_SetString(tstate, PyExc_SystemError,
- "no locals found");
- if (true) goto error_tier_two;
- }
- PyObject *name = GETITEM(FRAME_CO_NAMES, oparg);
- if (PyMapping_GetOptionalItem(mod_or_class_dict, name, &v) < 0) {
- GOTO_ERROR(error);
- }
- if (v == NULL) {
- if (PyDict_GetItemRef(GLOBALS(), name, &v) < 0) {
- GOTO_ERROR(error);
- }
- if (v == NULL) {
- if (PyMapping_GetOptionalItem(BUILTINS(), name, &v) < 0) {
- GOTO_ERROR(error);
- }
- if (v == NULL) {
- _PyEval_FormatExcCheckArg(
- tstate, PyExc_NameError,
- NAME_ERROR_MSG, name);
- GOTO_ERROR(error);
- }
- }
- }
- stack_pointer[0] = v;
- stack_pointer += 1;
- break;
- }
+ /* _LOAD_NAME is not a viable micro-op for tier 2 because it has both popping and not-popping errors */
case _LOAD_GLOBAL: {
PyObject *res;
@@ -1278,22 +1252,22 @@
_PyEval_FormatExcCheckArg(tstate, PyExc_NameError,
NAME_ERROR_MSG, name);
}
- if (true) goto error_tier_two;
+ if (true) JUMP_TO_ERROR();
}
Py_INCREF(res);
}
else {
/* Slow-path if globals or builtins is not a dict */
/* namespace 1: globals */
- if (PyMapping_GetOptionalItem(GLOBALS(), name, &res) < 0) goto error_tier_two;
+ if (PyMapping_GetOptionalItem(GLOBALS(), name, &res) < 0) JUMP_TO_ERROR();
if (res == NULL) {
/* namespace 2: builtins */
- if (PyMapping_GetOptionalItem(BUILTINS(), name, &res) < 0) goto error_tier_two;
+ if (PyMapping_GetOptionalItem(BUILTINS(), name, &res) < 0) JUMP_TO_ERROR();
if (res == NULL) {
_PyEval_FormatExcCheckArg(
tstate, PyExc_NameError,
NAME_ERROR_MSG, name);
- if (true) goto error_tier_two;
+ if (true) JUMP_TO_ERROR();
}
}
}
@@ -1307,8 +1281,8 @@
case _GUARD_GLOBALS_VERSION: {
uint16_t version = (uint16_t)CURRENT_OPERAND();
PyDictObject *dict = (PyDictObject *)GLOBALS();
- if (!PyDict_CheckExact(dict)) goto deoptimize;
- if (dict->ma_keys->dk_version != version) goto deoptimize;
+ if (!PyDict_CheckExact(dict)) JUMP_TO_JUMP_TARGET();
+ if (dict->ma_keys->dk_version != version) JUMP_TO_JUMP_TARGET();
assert(DK_IS_UNICODE(dict->ma_keys));
break;
}
@@ -1316,8 +1290,8 @@
case _GUARD_BUILTINS_VERSION: {
uint16_t version = (uint16_t)CURRENT_OPERAND();
PyDictObject *dict = (PyDictObject *)BUILTINS();
- if (!PyDict_CheckExact(dict)) goto deoptimize;
- if (dict->ma_keys->dk_version != version) goto deoptimize;
+ if (!PyDict_CheckExact(dict)) JUMP_TO_JUMP_TARGET();
+ if (dict->ma_keys->dk_version != version) JUMP_TO_JUMP_TARGET();
assert(DK_IS_UNICODE(dict->ma_keys));
break;
}
@@ -1330,7 +1304,7 @@
PyDictObject *dict = (PyDictObject *)GLOBALS();
PyDictUnicodeEntry *entries = DK_UNICODE_ENTRIES(dict->ma_keys);
res = entries[index].me_value;
- if (res == NULL) goto deoptimize;
+ if (res == NULL) JUMP_TO_JUMP_TARGET();
Py_INCREF(res);
STAT_INC(LOAD_GLOBAL, hit);
null = NULL;
@@ -1348,7 +1322,7 @@
PyDictObject *bdict = (PyDictObject *)BUILTINS();
PyDictUnicodeEntry *entries = DK_UNICODE_ENTRIES(bdict->ma_keys);
res = entries[index].me_value;
- if (res == NULL) goto deoptimize;
+ if (res == NULL) JUMP_TO_JUMP_TARGET();
Py_INCREF(res);
STAT_INC(LOAD_GLOBAL, hit);
null = NULL;
@@ -1361,7 +1335,13 @@
case _DELETE_FAST: {
oparg = CURRENT_OPARG();
PyObject *v = GETLOCAL(oparg);
- if (v == NULL) goto unbound_local_error_tier_two;
+ if (v == NULL) {
+ _PyEval_FormatExcCheckArg(tstate, PyExc_UnboundLocalError,
+ UNBOUNDLOCAL_ERROR_MSG,
+ PyTuple_GetItem(_PyFrame_GetCode(frame)->co_localsplusnames, oparg)
+ );
+ if (1) JUMP_TO_ERROR();
+ }
SETLOCAL(oparg, NULL);
break;
}
@@ -1373,7 +1353,7 @@
PyObject *initial = GETLOCAL(oparg);
PyObject *cell = PyCell_New(initial);
if (cell == NULL) {
- GOTO_ERROR(error);
+ JUMP_TO_ERROR();
}
SETLOCAL(oparg, cell);
break;
@@ -1387,7 +1367,7 @@
// Fortunately we don't need its superpower.
if (oldobj == NULL) {
_PyEval_FormatExcUnbound(tstate, _PyFrame_GetCode(frame), oparg);
- GOTO_ERROR(error);
+ JUMP_TO_ERROR();
}
PyCell_SET(cell, NULL);
Py_DECREF(oldobj);
@@ -1404,14 +1384,14 @@
assert(oparg >= 0 && oparg < _PyFrame_GetCode(frame)->co_nlocalsplus);
name = PyTuple_GET_ITEM(_PyFrame_GetCode(frame)->co_localsplusnames, oparg);
if (PyMapping_GetOptionalItem(class_dict, name, &value) < 0) {
- GOTO_ERROR(error);
+ JUMP_TO_ERROR();
}
if (!value) {
PyObject *cell = GETLOCAL(oparg);
value = PyCell_GET(cell);
if (value == NULL) {
_PyEval_FormatExcUnbound(tstate, _PyFrame_GetCode(frame), oparg);
- GOTO_ERROR(error);
+ JUMP_TO_ERROR();
}
Py_INCREF(value);
}
@@ -1427,7 +1407,7 @@
value = PyCell_GET(cell);
if (value == NULL) {
_PyEval_FormatExcUnbound(tstate, _PyFrame_GetCode(frame), oparg);
- if (true) goto error_tier_two;
+ if (true) JUMP_TO_ERROR();
}
Py_INCREF(value);
stack_pointer[0] = value;
@@ -1471,7 +1451,7 @@
for (int _i = oparg; --_i >= 0;) {
Py_DECREF(pieces[_i]);
}
- if (str == NULL) { stack_pointer += -oparg; goto error_tier_two; }
+ if (str == NULL) JUMP_TO_ERROR();
stack_pointer[-oparg] = str;
stack_pointer += 1 - oparg;
break;
@@ -1483,7 +1463,7 @@
oparg = CURRENT_OPARG();
values = &stack_pointer[-oparg];
tup = _PyTuple_FromArraySteal(values, oparg);
- if (tup == NULL) { stack_pointer += -oparg; goto error_tier_two; }
+ if (tup == NULL) JUMP_TO_ERROR();
stack_pointer[-oparg] = tup;
stack_pointer += 1 - oparg;
break;
@@ -1495,7 +1475,7 @@
oparg = CURRENT_OPARG();
values = &stack_pointer[-oparg];
list = _PyList_FromArraySteal(values, oparg);
- if (list == NULL) { stack_pointer += -oparg; goto error_tier_two; }
+ if (list == NULL) JUMP_TO_ERROR();
stack_pointer[-oparg] = list;
stack_pointer += 1 - oparg;
break;
@@ -1518,7 +1498,7 @@
Py_TYPE(iterable)->tp_name);
}
Py_DECREF(iterable);
- if (true) goto pop_1_error_tier_two;
+ if (true) JUMP_TO_ERROR();
}
assert(Py_IsNone(none_val));
Py_DECREF(iterable);
@@ -1534,34 +1514,12 @@
set = stack_pointer[-2 - (oparg-1)];
int err = _PySet_Update(set, iterable);
Py_DECREF(iterable);
- if (err < 0) goto pop_1_error_tier_two;
+ if (err < 0) JUMP_TO_ERROR();
stack_pointer += -1;
break;
}
- case _BUILD_SET: {
- PyObject **values;
- PyObject *set;
- oparg = CURRENT_OPARG();
- values = &stack_pointer[-oparg];
- set = PySet_New(NULL);
- if (set == NULL)
- GOTO_ERROR(error);
- int err = 0;
- for (int i = 0; i < oparg; i++) {
- PyObject *item = values[i];
- if (err == 0)
- err = PySet_Add(set, item);
- Py_DECREF(item);
- }
- if (err != 0) {
- Py_DECREF(set);
- if (true) { stack_pointer += -oparg; goto error_tier_two; }
- }
- stack_pointer[-oparg] = set;
- stack_pointer += 1 - oparg;
- break;
- }
+ /* _BUILD_SET is not a viable micro-op for tier 2 because it has both popping and not-popping errors */
case _BUILD_MAP: {
PyObject **values;
@@ -1575,7 +1533,7 @@
for (int _i = oparg*2; --_i >= 0;) {
Py_DECREF(values[_i]);
}
- if (map == NULL) { stack_pointer += -oparg*2; goto error_tier_two; }
+ if (map == NULL) JUMP_TO_ERROR();
stack_pointer[-oparg*2] = map;
stack_pointer += 1 - oparg*2;
break;
@@ -1587,17 +1545,17 @@
if (LOCALS() == NULL) {
_PyErr_Format(tstate, PyExc_SystemError,
"no locals found when setting up annotations");
- if (true) goto error_tier_two;
+ if (true) JUMP_TO_ERROR();
}
/* check if __annotations__ in locals()... */
- if (PyMapping_GetOptionalItem(LOCALS(), &_Py_ID(__annotations__), &ann_dict) < 0) goto error_tier_two;
+ if (PyMapping_GetOptionalItem(LOCALS(), &_Py_ID(__annotations__), &ann_dict) < 0) JUMP_TO_ERROR();
if (ann_dict == NULL) {
ann_dict = PyDict_New();
- if (ann_dict == NULL) goto error_tier_two;
+ if (ann_dict == NULL) JUMP_TO_ERROR();
err = PyObject_SetItem(LOCALS(), &_Py_ID(__annotations__),
ann_dict);
Py_DECREF(ann_dict);
- if (err) goto error_tier_two;
+ if (err) JUMP_TO_ERROR();
}
else {
Py_DECREF(ann_dict);
@@ -1612,12 +1570,8 @@
oparg = CURRENT_OPARG();
keys = stack_pointer[-1];
values = &stack_pointer[-1 - oparg];
- if (!PyTuple_CheckExact(keys) ||
- PyTuple_GET_SIZE(keys) != (Py_ssize_t)oparg) {
- _PyErr_SetString(tstate, PyExc_SystemError,
- "bad BUILD_CONST_KEY_MAP keys argument");
- GOTO_ERROR(error); // Pop the keys and values.
- }
+ assert(PyTuple_CheckExact(keys));
+ assert(PyTuple_GET_SIZE(keys) == (Py_ssize_t)oparg);
map = _PyDict_FromItems(
&PyTuple_GET_ITEM(keys, 0), 1,
values, 1, oparg);
@@ -1625,7 +1579,7 @@
Py_DECREF(values[_i]);
}
Py_DECREF(keys);
- if (map == NULL) { stack_pointer += -1 - oparg; goto error_tier_two; }
+ if (map == NULL) JUMP_TO_ERROR();
stack_pointer[-1 - oparg] = map;
stack_pointer += -oparg;
break;
@@ -1644,7 +1598,7 @@
Py_TYPE(update)->tp_name);
}
Py_DECREF(update);
- if (true) goto pop_1_error_tier_two;
+ if (true) JUMP_TO_ERROR();
}
Py_DECREF(update);
stack_pointer += -1;
@@ -1662,7 +1616,7 @@
if (_PyDict_MergeEx(dict, update, 2) < 0) {
_PyEval_FormatKwargsError(tstate, callable, update);
Py_DECREF(update);
- if (true) goto pop_1_error_tier_two;
+ if (true) JUMP_TO_ERROR();
}
Py_DECREF(update);
stack_pointer += -1;
@@ -1680,12 +1634,12 @@
assert(PyDict_CheckExact(dict));
/* dict[key] = value */
// Do not DECREF INPUTS because the function steals the references
- if (_PyDict_SetItem_Take2((PyDictObject *)dict, key, value) != 0) goto pop_2_error_tier_two;
+ if (_PyDict_SetItem_Take2((PyDictObject *)dict, key, value) != 0) JUMP_TO_ERROR();
stack_pointer += -2;
break;
}
- /* _INSTRUMENTED_LOAD_SUPER_ATTR is not a viable micro-op for tier 2 */
+ /* _INSTRUMENTED_LOAD_SUPER_ATTR is not a viable micro-op for tier 2 because it is instrumented */
case _LOAD_SUPER_ATTR_ATTR: {
PyObject *self;
@@ -1697,15 +1651,15 @@
class = stack_pointer[-2];
global_super = stack_pointer[-3];
assert(!(oparg & 1));
- if (global_super != (PyObject *)&PySuper_Type) goto deoptimize;
- if (!PyType_Check(class)) goto deoptimize;
+ if (global_super != (PyObject *)&PySuper_Type) JUMP_TO_JUMP_TARGET();
+ if (!PyType_Check(class)) JUMP_TO_JUMP_TARGET();
STAT_INC(LOAD_SUPER_ATTR, hit);
PyObject *name = GETITEM(FRAME_CO_NAMES, oparg >> 2);
attr = _PySuper_Lookup((PyTypeObject *)class, self, name, NULL);
Py_DECREF(global_super);
Py_DECREF(class);
Py_DECREF(self);
- if (attr == NULL) goto pop_3_error_tier_two;
+ if (attr == NULL) JUMP_TO_ERROR();
stack_pointer[-3] = attr;
stack_pointer += -2;
break;
@@ -1722,8 +1676,8 @@
class = stack_pointer[-2];
global_super = stack_pointer[-3];
assert(oparg & 1);
- if (global_super != (PyObject *)&PySuper_Type) goto deoptimize;
- if (!PyType_Check(class)) goto deoptimize;
+ if (global_super != (PyObject *)&PySuper_Type) JUMP_TO_JUMP_TARGET();
+ if (!PyType_Check(class)) JUMP_TO_JUMP_TARGET();
STAT_INC(LOAD_SUPER_ATTR, hit);
PyObject *name = GETITEM(FRAME_CO_NAMES, oparg >> 2);
PyTypeObject *cls = (PyTypeObject *)class;
@@ -1734,7 +1688,7 @@
Py_DECREF(class);
if (attr == NULL) {
Py_DECREF(self);
- if (true) goto pop_3_error_tier_two;
+ if (true) JUMP_TO_ERROR();
}
if (method_found) {
self_or_null = self; // transfer ownership
@@ -1774,7 +1728,7 @@
meth | NULL | arg1 | ... | argN
*/
Py_DECREF(owner);
- if (attr == NULL) goto pop_1_error_tier_two;
+ if (attr == NULL) JUMP_TO_ERROR();
self_or_null = NULL;
}
}
@@ -1782,7 +1736,7 @@
/* Classic, pushes one value. */
attr = PyObject_GetAttr(owner, name);
Py_DECREF(owner);
- if (attr == NULL) goto pop_1_error_tier_two;
+ if (attr == NULL) JUMP_TO_ERROR();
}
stack_pointer[-1] = attr;
if (oparg & 1) stack_pointer[0] = self_or_null;
@@ -1796,7 +1750,7 @@
uint32_t type_version = (uint32_t)CURRENT_OPERAND();
PyTypeObject *tp = Py_TYPE(owner);
assert(type_version != 0);
- if (tp->tp_version_tag != type_version) goto side_exit;
+ if (tp->tp_version_tag != type_version) JUMP_TO_JUMP_TARGET();
break;
}
@@ -1806,7 +1760,7 @@
assert(Py_TYPE(owner)->tp_dictoffset < 0);
assert(Py_TYPE(owner)->tp_flags & Py_TPFLAGS_MANAGED_DICT);
PyDictOrValues *dorv = _PyObject_DictOrValuesPointer(owner);
- if (!_PyDictOrValues_IsValues(*dorv) && !_PyObject_MakeInstanceAttributesFromDict(owner, dorv)) goto deoptimize;
+ if (!_PyDictOrValues_IsValues(*dorv) && !_PyObject_MakeInstanceAttributesFromDict(owner, dorv)) JUMP_TO_JUMP_TARGET();
break;
}
@@ -1819,7 +1773,7 @@
uint16_t index = (uint16_t)CURRENT_OPERAND();
PyDictOrValues dorv = *_PyObject_DictOrValuesPointer(owner);
attr = _PyDictOrValues_GetValues(dorv)->values[index];
- if (attr == NULL) goto deoptimize;
+ if (attr == NULL) JUMP_TO_JUMP_TARGET();
STAT_INC(LOAD_ATTR, hit);
Py_INCREF(attr);
null = NULL;
@@ -1837,7 +1791,7 @@
uint16_t index = (uint16_t)CURRENT_OPERAND();
PyDictOrValues dorv = *_PyObject_DictOrValuesPointer(owner);
attr = _PyDictOrValues_GetValues(dorv)->values[index];
- if (attr == NULL) goto deoptimize;
+ if (attr == NULL) JUMP_TO_JUMP_TARGET();
STAT_INC(LOAD_ATTR, hit);
Py_INCREF(attr);
null = NULL;
@@ -1854,10 +1808,10 @@
PyObject *owner;
owner = stack_pointer[-1];
uint32_t dict_version = (uint32_t)CURRENT_OPERAND();
- if (!PyModule_CheckExact(owner)) goto deoptimize;
+ if (!PyModule_CheckExact(owner)) JUMP_TO_JUMP_TARGET();
PyDictObject *dict = (PyDictObject *)((PyModuleObject *)owner)->md_dict;
assert(dict != NULL);
- if (dict->ma_keys->dk_version != dict_version) goto deoptimize;
+ if (dict->ma_keys->dk_version != dict_version) JUMP_TO_JUMP_TARGET();
break;
}
@@ -1873,7 +1827,7 @@
assert(index < dict->ma_keys->dk_nentries);
PyDictUnicodeEntry *ep = DK_UNICODE_ENTRIES(dict->ma_keys) + index;
attr = ep->me_value;
- if (attr == NULL) goto deoptimize;
+ if (attr == NULL) JUMP_TO_JUMP_TARGET();
STAT_INC(LOAD_ATTR, hit);
Py_INCREF(attr);
null = NULL;
@@ -1889,9 +1843,9 @@
owner = stack_pointer[-1];
assert(Py_TYPE(owner)->tp_flags & Py_TPFLAGS_MANAGED_DICT);
PyDictOrValues dorv = *_PyObject_DictOrValuesPointer(owner);
- if (_PyDictOrValues_IsValues(dorv)) goto deoptimize;
+ if (_PyDictOrValues_IsValues(dorv)) JUMP_TO_JUMP_TARGET();
PyDictObject *dict = (PyDictObject *)_PyDictOrValues_GetDict(dorv);
- if (dict == NULL) goto deoptimize;
+ if (dict == NULL) JUMP_TO_JUMP_TARGET();
assert(PyDict_CheckExact((PyObject *)dict));
break;
}
@@ -1905,19 +1859,19 @@
uint16_t hint = (uint16_t)CURRENT_OPERAND();
PyDictOrValues dorv = *_PyObject_DictOrValuesPointer(owner);
PyDictObject *dict = (PyDictObject *)_PyDictOrValues_GetDict(dorv);
- if (hint >= (size_t)dict->ma_keys->dk_nentries) goto deoptimize;
+ if (hint >= (size_t)dict->ma_keys->dk_nentries) JUMP_TO_JUMP_TARGET();
PyObject *name = GETITEM(FRAME_CO_NAMES, oparg>>1);
if (DK_IS_UNICODE(dict->ma_keys)) {
PyDictUnicodeEntry *ep = DK_UNICODE_ENTRIES(dict->ma_keys) + hint;
- if (ep->me_key != name) goto deoptimize;
+ if (ep->me_key != name) JUMP_TO_JUMP_TARGET();
attr = ep->me_value;
}
else {
PyDictKeyEntry *ep = DK_ENTRIES(dict->ma_keys) + hint;
- if (ep->me_key != name) goto deoptimize;
+ if (ep->me_key != name) JUMP_TO_JUMP_TARGET();
attr = ep->me_value;
}
- if (attr == NULL) goto deoptimize;
+ if (attr == NULL) JUMP_TO_JUMP_TARGET();
STAT_INC(LOAD_ATTR, hit);
Py_INCREF(attr);
null = NULL;
@@ -1937,7 +1891,7 @@
uint16_t index = (uint16_t)CURRENT_OPERAND();
char *addr = (char *)owner + index;
attr = *(PyObject **)addr;
- if (attr == NULL) goto deoptimize;
+ if (attr == NULL) JUMP_TO_JUMP_TARGET();
STAT_INC(LOAD_ATTR, hit);
Py_INCREF(attr);
null = NULL;
@@ -1955,7 +1909,7 @@
uint16_t index = (uint16_t)CURRENT_OPERAND();
char *addr = (char *)owner + index;
attr = *(PyObject **)addr;
- if (attr == NULL) goto deoptimize;
+ if (attr == NULL) JUMP_TO_JUMP_TARGET();
STAT_INC(LOAD_ATTR, hit);
Py_INCREF(attr);
null = NULL;
@@ -1972,9 +1926,9 @@
PyObject *owner;
owner = stack_pointer[-1];
uint32_t type_version = (uint32_t)CURRENT_OPERAND();
- if (!PyType_Check(owner)) goto deoptimize;
+ if (!PyType_Check(owner)) JUMP_TO_JUMP_TARGET();
assert(type_version != 0);
- if (((PyTypeObject *)owner)->tp_version_tag != type_version) goto deoptimize;
+ if (((PyTypeObject *)owner)->tp_version_tag != type_version) JUMP_TO_JUMP_TARGET();
break;
}
@@ -2014,16 +1968,16 @@
/* _LOAD_ATTR_CLASS is split on (oparg & 1) */
- /* _LOAD_ATTR_PROPERTY is not a viable micro-op for tier 2 */
+ /* _LOAD_ATTR_PROPERTY is not a viable micro-op for tier 2 because it uses the 'this_instr' variable */
- /* _LOAD_ATTR_GETATTRIBUTE_OVERRIDDEN is not a viable micro-op for tier 2 */
+ /* _LOAD_ATTR_GETATTRIBUTE_OVERRIDDEN is not a viable micro-op for tier 2 because it uses the 'this_instr' variable */
case _GUARD_DORV_VALUES: {
PyObject *owner;
owner = stack_pointer[-1];
assert(Py_TYPE(owner)->tp_flags & Py_TPFLAGS_MANAGED_DICT);
PyDictOrValues dorv = *_PyObject_DictOrValuesPointer(owner);
- if (!_PyDictOrValues_IsValues(dorv)) goto deoptimize;
+ if (!_PyDictOrValues_IsValues(dorv)) JUMP_TO_JUMP_TARGET();
break;
}
@@ -2049,7 +2003,7 @@
break;
}
- /* _STORE_ATTR_WITH_HINT is not a viable micro-op for tier 2 */
+ /* _STORE_ATTR_WITH_HINT is not a viable micro-op for tier 2 because it has unused cache entries */
case _STORE_ATTR_SLOT: {
PyObject *owner;
@@ -2078,11 +2032,11 @@
res = PyObject_RichCompare(left, right, oparg >> 5);
Py_DECREF(left);
Py_DECREF(right);
- if (res == NULL) goto pop_2_error_tier_two;
+ if (res == NULL) JUMP_TO_ERROR();
if (oparg & 16) {
int res_bool = PyObject_IsTrue(res);
Py_DECREF(res);
- if (res_bool < 0) goto pop_2_error_tier_two;
+ if (res_bool < 0) JUMP_TO_ERROR();
res = res_bool ? Py_True : Py_False;
}
stack_pointer[-2] = res;
@@ -2118,8 +2072,8 @@
oparg = CURRENT_OPARG();
right = stack_pointer[-1];
left = stack_pointer[-2];
- if (!_PyLong_IsCompact((PyLongObject *)left)) goto deoptimize;
- if (!_PyLong_IsCompact((PyLongObject *)right)) goto deoptimize;
+ if (!_PyLong_IsCompact((PyLongObject *)left)) JUMP_TO_JUMP_TARGET();
+ if (!_PyLong_IsCompact((PyLongObject *)right)) JUMP_TO_JUMP_TARGET();
STAT_INC(COMPARE_OP, hit);
assert(_PyLong_DigitCount((PyLongObject *)left) <= 1 &&
_PyLong_DigitCount((PyLongObject *)right) <= 1);
@@ -2184,7 +2138,7 @@
int res = PySequence_Contains(right, left);
Py_DECREF(left);
Py_DECREF(right);
- if (res < 0) goto pop_2_error_tier_two;
+ if (res < 0) JUMP_TO_ERROR();
b = (res ^ oparg) ? Py_True : Py_False;
stack_pointer[-2] = b;
stack_pointer += -1;
@@ -2198,13 +2152,13 @@
oparg = CURRENT_OPARG();
right = stack_pointer[-1];
left = stack_pointer[-2];
- if (!(PySet_CheckExact(right) || PyFrozenSet_CheckExact(right))) goto deoptimize;
+ if (!(PySet_CheckExact(right) || PyFrozenSet_CheckExact(right))) JUMP_TO_JUMP_TARGET();
STAT_INC(CONTAINS_OP, hit);
// Note: both set and frozenset use the same seq_contains method!
int res = _PySet_Contains((PySetObject *)right, left);
Py_DECREF(left);
Py_DECREF(right);
- if (res < 0) goto pop_2_error_tier_two;
+ if (res < 0) JUMP_TO_ERROR();
b = (res ^ oparg) ? Py_True : Py_False;
stack_pointer[-2] = b;
stack_pointer += -1;
@@ -2218,12 +2172,12 @@
oparg = CURRENT_OPARG();
right = stack_pointer[-1];
left = stack_pointer[-2];
- if (!PyDict_CheckExact(right)) goto deoptimize;
+ if (!PyDict_CheckExact(right)) JUMP_TO_JUMP_TARGET();
STAT_INC(CONTAINS_OP, hit);
int res = PyDict_Contains(right, left);
Py_DECREF(left);
Py_DECREF(right);
- if (res < 0) goto pop_2_error_tier_two;
+ if (res < 0) JUMP_TO_ERROR();
b = (res ^ oparg) ? Py_True : Py_False;
stack_pointer[-2] = b;
stack_pointer += -1;
@@ -2240,7 +2194,7 @@
if (_PyEval_CheckExceptStarTypeValid(tstate, match_type) < 0) {
Py_DECREF(exc_value);
Py_DECREF(match_type);
- if (true) goto pop_2_error_tier_two;
+ if (true) JUMP_TO_ERROR();
}
match = NULL;
rest = NULL;
@@ -2248,9 +2202,9 @@
&match, &rest);
Py_DECREF(exc_value);
Py_DECREF(match_type);
- if (res < 0) goto pop_2_error_tier_two;
+ if (res < 0) JUMP_TO_ERROR();
assert((match == NULL) == (rest == NULL));
- if (match == NULL) goto pop_2_error_tier_two;
+ if (match == NULL) JUMP_TO_ERROR();
if (!Py_IsNone(match)) {
PyErr_SetHandledException(match);
}
@@ -2268,7 +2222,7 @@
assert(PyExceptionInstance_Check(left));
if (_PyEval_CheckExceptTypeValid(tstate, right) < 0) {
Py_DECREF(right);
- if (true) goto pop_1_error_tier_two;
+ if (true) JUMP_TO_ERROR();
}
int res = PyErr_GivenExceptionMatches(left, right);
Py_DECREF(right);
@@ -2277,9 +2231,9 @@
break;
}
- /* _POP_JUMP_IF_FALSE is not a viable micro-op for tier 2 */
+ /* _POP_JUMP_IF_FALSE is not a viable micro-op for tier 2 because it is replaced */
- /* _POP_JUMP_IF_TRUE is not a viable micro-op for tier 2 */
+ /* _POP_JUMP_IF_TRUE is not a viable micro-op for tier 2 because it is replaced */
case _IS_NONE: {
PyObject *value;
@@ -2302,9 +2256,9 @@
obj = stack_pointer[-1];
// PUSH(len(TOS))
Py_ssize_t len_i = PyObject_Length(obj);
- if (len_i < 0) goto error_tier_two;
+ if (len_i < 0) JUMP_TO_ERROR();
len_o = PyLong_FromSsize_t(len_i);
- if (len_o == NULL) goto error_tier_two;
+ if (len_o == NULL) JUMP_TO_ERROR();
stack_pointer[0] = len_o;
stack_pointer += 1;
break;
@@ -2330,7 +2284,7 @@
assert(PyTuple_CheckExact(attrs)); // Success!
}
else {
- if (_PyErr_Occurred(tstate)) goto pop_3_error_tier_two;
+ if (_PyErr_Occurred(tstate)) JUMP_TO_ERROR();
// Error!
attrs = Py_None; // Failure!
}
@@ -2369,7 +2323,7 @@
subject = stack_pointer[-2];
// On successful match, PUSH(values). Otherwise, PUSH(None).
values_or_none = _PyEval_MatchKeys(tstate, subject, keys);
- if (values_or_none == NULL) goto error_tier_two;
+ if (values_or_none == NULL) JUMP_TO_ERROR();
stack_pointer[0] = values_or_none;
stack_pointer += 1;
break;
@@ -2382,7 +2336,7 @@
/* before: [obj]; after [getiter(obj)] */
iter = PyObject_GetIter(iterable);
Py_DECREF(iterable);
- if (iter == NULL) goto pop_1_error_tier_two;
+ if (iter == NULL) JUMP_TO_ERROR();
stack_pointer[-1] = iter;
break;
}
@@ -2400,7 +2354,7 @@
_PyErr_SetString(tstate, PyExc_TypeError,
"cannot 'yield from' a coroutine object "
"in a non-coroutine generator");
- GOTO_ERROR(error);
+ JUMP_TO_ERROR();
}
iter = iterable;
}
@@ -2411,7 +2365,7 @@
/* `iterable` is not a generator. */
iter = PyObject_GetIter(iterable);
if (iter == NULL) {
- GOTO_ERROR(error);
+ JUMP_TO_ERROR();
}
Py_DECREF(iterable);
}
@@ -2419,7 +2373,7 @@
break;
}
- /* _FOR_ITER is not a viable micro-op for tier 2 */
+ /* _FOR_ITER is not a viable micro-op for tier 2 because it is replaced */
case _FOR_ITER_TIER_TWO: {
PyObject *iter;
@@ -2430,7 +2384,7 @@
if (next == NULL) {
if (_PyErr_Occurred(tstate)) {
if (!_PyErr_ExceptionMatches(tstate, PyExc_StopIteration)) {
- GOTO_ERROR(error);
+ JUMP_TO_ERROR();
}
_PyErr_Clear(tstate);
}
@@ -2438,7 +2392,7 @@
Py_DECREF(iter);
STACK_SHRINK(1);
/* The translator sets the deopt target just past END_FOR */
- if (true) goto deoptimize;
+ if (true) JUMP_TO_JUMP_TARGET();
}
// Common case: no jump, leave it to the code generator
stack_pointer[0] = next;
@@ -2446,16 +2400,16 @@
break;
}
- /* _INSTRUMENTED_FOR_ITER is not a viable micro-op for tier 2 */
+ /* _INSTRUMENTED_FOR_ITER is not a viable micro-op for tier 2 because it is instrumented */
case _ITER_CHECK_LIST: {
PyObject *iter;
iter = stack_pointer[-1];
- if (Py_TYPE(iter) != &PyListIter_Type) goto deoptimize;
+ if (Py_TYPE(iter) != &PyListIter_Type) JUMP_TO_JUMP_TARGET();
break;
}
- /* _ITER_JUMP_LIST is not a viable micro-op for tier 2 */
+ /* _ITER_JUMP_LIST is not a viable micro-op for tier 2 because it is replaced */
case _GUARD_NOT_EXHAUSTED_LIST: {
PyObject *iter;
@@ -2463,8 +2417,8 @@
_PyListIterObject *it = (_PyListIterObject *)iter;
assert(Py_TYPE(iter) == &PyListIter_Type);
PyListObject *seq = it->it_seq;
- if (seq == NULL) goto deoptimize;
- if ((size_t)it->it_index >= (size_t)PyList_GET_SIZE(seq)) goto deoptimize;
+ if (seq == NULL) JUMP_TO_JUMP_TARGET();
+ if ((size_t)it->it_index >= (size_t)PyList_GET_SIZE(seq)) JUMP_TO_JUMP_TARGET();
break;
}
@@ -2486,11 +2440,11 @@
case _ITER_CHECK_TUPLE: {
PyObject *iter;
iter = stack_pointer[-1];
- if (Py_TYPE(iter) != &PyTupleIter_Type) goto deoptimize;
+ if (Py_TYPE(iter) != &PyTupleIter_Type) JUMP_TO_JUMP_TARGET();
break;
}
- /* _ITER_JUMP_TUPLE is not a viable micro-op for tier 2 */
+ /* _ITER_JUMP_TUPLE is not a viable micro-op for tier 2 because it is replaced */
case _GUARD_NOT_EXHAUSTED_TUPLE: {
PyObject *iter;
@@ -2498,8 +2452,8 @@
_PyTupleIterObject *it = (_PyTupleIterObject *)iter;
assert(Py_TYPE(iter) == &PyTupleIter_Type);
PyTupleObject *seq = it->it_seq;
- if (seq == NULL) goto deoptimize;
- if (it->it_index >= PyTuple_GET_SIZE(seq)) goto deoptimize;
+ if (seq == NULL) JUMP_TO_JUMP_TARGET();
+ if (it->it_index >= PyTuple_GET_SIZE(seq)) JUMP_TO_JUMP_TARGET();
break;
}
@@ -2522,18 +2476,18 @@
PyObject *iter;
iter = stack_pointer[-1];
_PyRangeIterObject *r = (_PyRangeIterObject *)iter;
- if (Py_TYPE(r) != &PyRangeIter_Type) goto deoptimize;
+ if (Py_TYPE(r) != &PyRangeIter_Type) JUMP_TO_JUMP_TARGET();
break;
}
- /* _ITER_JUMP_RANGE is not a viable micro-op for tier 2 */
+ /* _ITER_JUMP_RANGE is not a viable micro-op for tier 2 because it is replaced */
case _GUARD_NOT_EXHAUSTED_RANGE: {
PyObject *iter;
iter = stack_pointer[-1];
_PyRangeIterObject *r = (_PyRangeIterObject *)iter;
assert(Py_TYPE(r) == &PyRangeIter_Type);
- if (r->len <= 0) goto deoptimize;
+ if (r->len <= 0) JUMP_TO_JUMP_TARGET();
break;
}
@@ -2548,96 +2502,17 @@
r->start = value + r->step;
r->len--;
next = PyLong_FromLong(value);
- if (next == NULL) goto error_tier_two;
+ if (next == NULL) JUMP_TO_ERROR();
stack_pointer[0] = next;
stack_pointer += 1;
break;
}
- /* _FOR_ITER_GEN is not a viable micro-op for tier 2 */
+ /* _FOR_ITER_GEN is not a viable micro-op for tier 2 because it uses the 'this_instr' variable */
- case _BEFORE_ASYNC_WITH: {
- PyObject *mgr;
- PyObject *exit;
- PyObject *res;
- mgr = stack_pointer[-1];
- PyObject *enter = _PyObject_LookupSpecial(mgr, &_Py_ID(__aenter__));
- if (enter == NULL) {
- if (!_PyErr_Occurred(tstate)) {
- _PyErr_Format(tstate, PyExc_TypeError,
- "'%.200s' object does not support the "
- "asynchronous context manager protocol",
- Py_TYPE(mgr)->tp_name);
- }
- GOTO_ERROR(error);
- }
- exit = _PyObject_LookupSpecial(mgr, &_Py_ID(__aexit__));
- if (exit == NULL) {
- if (!_PyErr_Occurred(tstate)) {
- _PyErr_Format(tstate, PyExc_TypeError,
- "'%.200s' object does not support the "
- "asynchronous context manager protocol "
- "(missed __aexit__ method)",
- Py_TYPE(mgr)->tp_name);
- }
- Py_DECREF(enter);
- GOTO_ERROR(error);
- }
- Py_DECREF(mgr);
- res = PyObject_CallNoArgs(enter);
- Py_DECREF(enter);
- if (res == NULL) {
- Py_DECREF(exit);
- if (true) goto pop_1_error_tier_two;
- }
- stack_pointer[-1] = exit;
- stack_pointer[0] = res;
- stack_pointer += 1;
- break;
- }
+ /* _BEFORE_ASYNC_WITH is not a viable micro-op for tier 2 because it has both popping and not-popping errors */
- case _BEFORE_WITH: {
- PyObject *mgr;
- PyObject *exit;
- PyObject *res;
- mgr = stack_pointer[-1];
- /* pop the context manager, push its __exit__ and the
- * value returned from calling its __enter__
- */
- PyObject *enter = _PyObject_LookupSpecial(mgr, &_Py_ID(__enter__));
- if (enter == NULL) {
- if (!_PyErr_Occurred(tstate)) {
- _PyErr_Format(tstate, PyExc_TypeError,
- "'%.200s' object does not support the "
- "context manager protocol",
- Py_TYPE(mgr)->tp_name);
- }
- GOTO_ERROR(error);
- }
- exit = _PyObject_LookupSpecial(mgr, &_Py_ID(__exit__));
- if (exit == NULL) {
- if (!_PyErr_Occurred(tstate)) {
- _PyErr_Format(tstate, PyExc_TypeError,
- "'%.200s' object does not support the "
- "context manager protocol "
- "(missed __exit__ method)",
- Py_TYPE(mgr)->tp_name);
- }
- Py_DECREF(enter);
- GOTO_ERROR(error);
- }
- Py_DECREF(mgr);
- res = PyObject_CallNoArgs(enter);
- Py_DECREF(enter);
- if (res == NULL) {
- Py_DECREF(exit);
- if (true) goto pop_1_error_tier_two;
- }
- stack_pointer[-1] = exit;
- stack_pointer[0] = res;
- stack_pointer += 1;
- break;
- }
+ /* _BEFORE_WITH is not a viable micro-op for tier 2 because it has both popping and not-popping errors */
case _WITH_EXCEPT_START: {
PyObject *val;
@@ -2670,7 +2545,7 @@
PyObject *stack[4] = {NULL, exc, val, tb};
res = PyObject_Vectorcall(exit_func, stack + 1,
3 | PY_VECTORCALL_ARGUMENTS_OFFSET, NULL);
- if (res == NULL) goto error_tier_two;
+ if (res == NULL) JUMP_TO_ERROR();
stack_pointer[0] = res;
stack_pointer += 1;
break;
@@ -2700,7 +2575,7 @@
owner = stack_pointer[-1];
assert(Py_TYPE(owner)->tp_flags & Py_TPFLAGS_MANAGED_DICT);
PyDictOrValues *dorv = _PyObject_DictOrValuesPointer(owner);
- if (!_PyDictOrValues_IsValues(*dorv) && !_PyObject_MakeInstanceAttributesFromDict(owner, dorv)) goto deoptimize;
+ if (!_PyDictOrValues_IsValues(*dorv) && !_PyObject_MakeInstanceAttributesFromDict(owner, dorv)) JUMP_TO_JUMP_TARGET();
break;
}
@@ -2710,7 +2585,7 @@
uint32_t keys_version = (uint32_t)CURRENT_OPERAND();
PyTypeObject *owner_cls = Py_TYPE(owner);
PyHeapTypeObject *owner_heap_type = (PyHeapTypeObject *)owner_cls;
- if (owner_heap_type->ht_cached_keys->dk_version != keys_version) goto deoptimize;
+ if (owner_heap_type->ht_cached_keys->dk_version != keys_version) JUMP_TO_JUMP_TARGET();
break;
}
@@ -2792,7 +2667,7 @@
assert(dictoffset > 0);
PyObject *dict = *(PyObject **)((char *)owner + dictoffset);
/* This object has a __dict__, just not yet created */
- if (dict != NULL) goto deoptimize;
+ if (dict != NULL) JUMP_TO_JUMP_TARGET();
break;
}
@@ -2815,9 +2690,9 @@
break;
}
- /* _INSTRUMENTED_CALL is not a viable micro-op for tier 2 */
+ /* _INSTRUMENTED_CALL is not a viable micro-op for tier 2 because it is instrumented */
- /* _CALL is not a viable micro-op for tier 2 */
+ /* _CALL is not a viable micro-op for tier 2 because it uses the 'this_instr' variable */
case _CHECK_PERIODIC: {
CHECK_EVAL_BREAKER();
@@ -2830,8 +2705,8 @@
oparg = CURRENT_OPARG();
null = stack_pointer[-1 - oparg];
callable = stack_pointer[-2 - oparg];
- if (null != NULL) goto deoptimize;
- if (Py_TYPE(callable) != &PyMethod_Type) goto deoptimize;
+ if (null != NULL) JUMP_TO_JUMP_TARGET();
+ if (Py_TYPE(callable) != &PyMethod_Type) JUMP_TO_JUMP_TARGET();
break;
}
@@ -2853,7 +2728,7 @@
}
case _CHECK_PEP_523: {
- if (tstate->interp->eval_frame) goto deoptimize;
+ if (tstate->interp->eval_frame) JUMP_TO_JUMP_TARGET();
break;
}
@@ -2864,11 +2739,11 @@
self_or_null = stack_pointer[-1 - oparg];
callable = stack_pointer[-2 - oparg];
uint32_t func_version = (uint32_t)CURRENT_OPERAND();
- if (!PyFunction_Check(callable)) goto deoptimize;
+ if (!PyFunction_Check(callable)) JUMP_TO_JUMP_TARGET();
PyFunctionObject *func = (PyFunctionObject *)callable;
- if (func->func_version != func_version) goto deoptimize;
+ if (func->func_version != func_version) JUMP_TO_JUMP_TARGET();
PyCodeObject *code = (PyCodeObject *)func->func_code;
- if (code->co_argcount != oparg + (self_or_null != NULL)) goto deoptimize;
+ if (code->co_argcount != oparg + (self_or_null != NULL)) JUMP_TO_JUMP_TARGET();
break;
}
@@ -2878,8 +2753,8 @@
callable = stack_pointer[-2 - oparg];
PyFunctionObject *func = (PyFunctionObject *)callable;
PyCodeObject *code = (PyCodeObject *)func->func_code;
- if (!_PyThreadState_HasStackSpace(tstate, code->co_framesize)) goto deoptimize;
- if (tstate->py_recursion_remaining <= 1) goto deoptimize;
+ if (!_PyThreadState_HasStackSpace(tstate, code->co_framesize)) JUMP_TO_JUMP_TARGET();
+ if (tstate->py_recursion_remaining <= 1) JUMP_TO_JUMP_TARGET();
break;
}
@@ -3049,7 +2924,7 @@
break;
}
- /* _CALL_PY_WITH_DEFAULTS is not a viable micro-op for tier 2 */
+ /* _CALL_PY_WITH_DEFAULTS is not a viable micro-op for tier 2 because it uses the 'this_instr' variable */
case _CALL_TYPE_1: {
PyObject *arg;
@@ -3061,8 +2936,8 @@
null = stack_pointer[-2];
callable = stack_pointer[-3];
assert(oparg == 1);
- if (null != NULL) goto deoptimize;
- if (callable != (PyObject *)&PyType_Type) goto deoptimize;
+ if (null != NULL) JUMP_TO_JUMP_TARGET();
+ if (callable != (PyObject *)&PyType_Type) JUMP_TO_JUMP_TARGET();
STAT_INC(CALL, hit);
res = Py_NewRef(Py_TYPE(arg));
Py_DECREF(arg);
@@ -3081,12 +2956,12 @@
null = stack_pointer[-2];
callable = stack_pointer[-3];
assert(oparg == 1);
- if (null != NULL) goto deoptimize;
- if (callable != (PyObject *)&PyUnicode_Type) goto deoptimize;
+ if (null != NULL) JUMP_TO_JUMP_TARGET();
+ if (callable != (PyObject *)&PyUnicode_Type) JUMP_TO_JUMP_TARGET();
STAT_INC(CALL, hit);
res = PyObject_Str(arg);
Py_DECREF(arg);
- if (res == NULL) goto pop_3_error_tier_two;
+ if (res == NULL) JUMP_TO_ERROR();
stack_pointer[-3] = res;
stack_pointer += -2;
break;
@@ -3102,18 +2977,18 @@
null = stack_pointer[-2];
callable = stack_pointer[-3];
assert(oparg == 1);
- if (null != NULL) goto deoptimize;
- if (callable != (PyObject *)&PyTuple_Type) goto deoptimize;
+ if (null != NULL) JUMP_TO_JUMP_TARGET();
+ if (callable != (PyObject *)&PyTuple_Type) JUMP_TO_JUMP_TARGET();
STAT_INC(CALL, hit);
res = PySequence_Tuple(arg);
Py_DECREF(arg);
- if (res == NULL) goto pop_3_error_tier_two;
+ if (res == NULL) JUMP_TO_ERROR();
stack_pointer[-3] = res;
stack_pointer += -2;
break;
}
- /* _CALL_ALLOC_AND_ENTER_INIT is not a viable micro-op for tier 2 */
+ /* _CALL_ALLOC_AND_ENTER_INIT is not a viable micro-op for tier 2 because it uses the 'this_instr' variable */
case _EXIT_INIT_CHECK: {
PyObject *should_be_none;
@@ -3123,7 +2998,7 @@
PyErr_Format(PyExc_TypeError,
"__init__() should return None, not '%.200s'",
Py_TYPE(should_be_none)->tp_name);
- GOTO_ERROR(error);
+ JUMP_TO_ERROR();
}
stack_pointer += -1;
break;
@@ -3143,9 +3018,9 @@
args--;
total_args++;
}
- if (!PyType_Check(callable)) goto deoptimize;
+ if (!PyType_Check(callable)) JUMP_TO_JUMP_TARGET();
PyTypeObject *tp = (PyTypeObject *)callable;
- if (tp->tp_vectorcall == NULL) goto deoptimize;
+ if (tp->tp_vectorcall == NULL) JUMP_TO_JUMP_TARGET();
STAT_INC(CALL, hit);
res = tp->tp_vectorcall((PyObject *)tp, args, total_args, NULL);
/* Free the arguments. */
@@ -3153,7 +3028,7 @@
Py_DECREF(args[i]);
}
Py_DECREF(tp);
- if (res == NULL) { stack_pointer += -2 - oparg; goto error_tier_two; }
+ if (res == NULL) JUMP_TO_ERROR();
stack_pointer[-2 - oparg] = res;
stack_pointer += -1 - oparg;
break;
@@ -3174,11 +3049,11 @@
args--;
total_args++;
}
- if (total_args != 1) goto deoptimize;
- if (!PyCFunction_CheckExact(callable)) goto deoptimize;
- if (PyCFunction_GET_FLAGS(callable) != METH_O) goto deoptimize;
+ if (total_args != 1) JUMP_TO_JUMP_TARGET();
+ if (!PyCFunction_CheckExact(callable)) JUMP_TO_JUMP_TARGET();
+ if (PyCFunction_GET_FLAGS(callable) != METH_O) JUMP_TO_JUMP_TARGET();
// CPython promises to check all non-vectorcall function calls.
- if (tstate->c_recursion_remaining <= 0) goto deoptimize;
+ if (tstate->c_recursion_remaining <= 0) JUMP_TO_JUMP_TARGET();
STAT_INC(CALL, hit);
PyCFunction cfunc = PyCFunction_GET_FUNCTION(callable);
PyObject *arg = args[0];
@@ -3188,7 +3063,7 @@
assert((res != NULL) ^ (_PyErr_Occurred(tstate) != NULL));
Py_DECREF(arg);
Py_DECREF(callable);
- if (res == NULL) { stack_pointer += -2 - oparg; goto error_tier_two; }
+ if (res == NULL) JUMP_TO_ERROR();
stack_pointer[-2 - oparg] = res;
stack_pointer += -1 - oparg;
break;
@@ -3209,8 +3084,8 @@
args--;
total_args++;
}
- if (!PyCFunction_CheckExact(callable)) goto deoptimize;
- if (PyCFunction_GET_FLAGS(callable) != METH_FASTCALL) goto deoptimize;
+ if (!PyCFunction_CheckExact(callable)) JUMP_TO_JUMP_TARGET();
+ if (PyCFunction_GET_FLAGS(callable) != METH_FASTCALL) JUMP_TO_JUMP_TARGET();
STAT_INC(CALL, hit);
PyCFunction cfunc = PyCFunction_GET_FUNCTION(callable);
/* res = func(self, args, nargs) */
@@ -3224,7 +3099,7 @@
Py_DECREF(args[i]);
}
Py_DECREF(callable);
- if (res == NULL) { stack_pointer += -2 - oparg; goto error_tier_two; }
+ if (res == NULL) JUMP_TO_ERROR();
stack_pointer[-2 - oparg] = res;
stack_pointer += -1 - oparg;
break;
@@ -3245,8 +3120,8 @@
args--;
total_args++;
}
- if (!PyCFunction_CheckExact(callable)) goto deoptimize;
- if (PyCFunction_GET_FLAGS(callable) != (METH_FASTCALL | METH_KEYWORDS)) goto deoptimize;
+ if (!PyCFunction_CheckExact(callable)) JUMP_TO_JUMP_TARGET();
+ if (PyCFunction_GET_FLAGS(callable) != (METH_FASTCALL | METH_KEYWORDS)) JUMP_TO_JUMP_TARGET();
STAT_INC(CALL, hit);
/* res = func(self, args, nargs, kwnames) */
PyCFunctionFastWithKeywords cfunc =
@@ -3259,7 +3134,7 @@
Py_DECREF(args[i]);
}
Py_DECREF(callable);
- if (res == NULL) { stack_pointer += -2 - oparg; goto error_tier_two; }
+ if (res == NULL) JUMP_TO_ERROR();
stack_pointer[-2 - oparg] = res;
stack_pointer += -1 - oparg;
break;
@@ -3280,14 +3155,14 @@
args--;
total_args++;
}
- if (total_args != 1) goto deoptimize;
+ if (total_args != 1) JUMP_TO_JUMP_TARGET();
PyInterpreterState *interp = tstate->interp;
- if (callable != interp->callable_cache.len) goto deoptimize;
+ if (callable != interp->callable_cache.len) JUMP_TO_JUMP_TARGET();
STAT_INC(CALL, hit);
PyObject *arg = args[0];
Py_ssize_t len_i = PyObject_Length(arg);
if (len_i < 0) {
- GOTO_ERROR(error);
+ JUMP_TO_ERROR();
}
res = PyLong_FromSsize_t(len_i);
assert((res != NULL) ^ (_PyErr_Occurred(tstate) != NULL));
@@ -3316,15 +3191,15 @@
args--;
total_args++;
}
- if (total_args != 2) goto deoptimize;
+ if (total_args != 2) JUMP_TO_JUMP_TARGET();
PyInterpreterState *interp = tstate->interp;
- if (callable != interp->callable_cache.isinstance) goto deoptimize;
+ if (callable != interp->callable_cache.isinstance) JUMP_TO_JUMP_TARGET();
STAT_INC(CALL, hit);
PyObject *cls = args[1];
PyObject *inst = args[0];
int retval = PyObject_IsInstance(inst, cls);
if (retval < 0) {
- GOTO_ERROR(error);
+ JUMP_TO_ERROR();
}
res = PyBool_FromLong(retval);
assert((res != NULL) ^ (_PyErr_Occurred(tstate) != NULL));
@@ -3354,15 +3229,15 @@
total_args++;
}
PyMethodDescrObject *method = (PyMethodDescrObject *)callable;
- if (total_args != 2) goto deoptimize;
- if (!Py_IS_TYPE(method, &PyMethodDescr_Type)) goto deoptimize;
+ if (total_args != 2) JUMP_TO_JUMP_TARGET();
+ if (!Py_IS_TYPE(method, &PyMethodDescr_Type)) JUMP_TO_JUMP_TARGET();
PyMethodDef *meth = method->d_method;
- if (meth->ml_flags != METH_O) goto deoptimize;
+ if (meth->ml_flags != METH_O) JUMP_TO_JUMP_TARGET();
// CPython promises to check all non-vectorcall function calls.
- if (tstate->c_recursion_remaining <= 0) goto deoptimize;
+ if (tstate->c_recursion_remaining <= 0) JUMP_TO_JUMP_TARGET();
PyObject *arg = args[1];
PyObject *self = args[0];
- if (!Py_IS_TYPE(self, method->d_common.d_type)) goto deoptimize;
+ if (!Py_IS_TYPE(self, method->d_common.d_type)) JUMP_TO_JUMP_TARGET();
STAT_INC(CALL, hit);
PyCFunction cfunc = meth->ml_meth;
_Py_EnterRecursiveCallTstateUnchecked(tstate);
@@ -3372,7 +3247,7 @@
Py_DECREF(self);
Py_DECREF(arg);
Py_DECREF(callable);
- if (res == NULL) { stack_pointer += -2 - oparg; goto error_tier_two; }
+ if (res == NULL) JUMP_TO_ERROR();
stack_pointer[-2 - oparg] = res;
stack_pointer += -1 - oparg;
break;
@@ -3393,12 +3268,12 @@
total_args++;
}
PyMethodDescrObject *method = (PyMethodDescrObject *)callable;
- if (!Py_IS_TYPE(method, &PyMethodDescr_Type)) goto deoptimize;
+ if (!Py_IS_TYPE(method, &PyMethodDescr_Type)) JUMP_TO_JUMP_TARGET();
PyMethodDef *meth = method->d_method;
- if (meth->ml_flags != (METH_FASTCALL|METH_KEYWORDS)) goto deoptimize;
+ if (meth->ml_flags != (METH_FASTCALL|METH_KEYWORDS)) JUMP_TO_JUMP_TARGET();
PyTypeObject *d_type = method->d_common.d_type;
PyObject *self = args[0];
- if (!Py_IS_TYPE(self, d_type)) goto deoptimize;
+ if (!Py_IS_TYPE(self, d_type)) JUMP_TO_JUMP_TARGET();
STAT_INC(CALL, hit);
int nargs = total_args - 1;
PyCFunctionFastWithKeywords cfunc =
@@ -3410,7 +3285,7 @@
Py_DECREF(args[i]);
}
Py_DECREF(callable);
- if (res == NULL) { stack_pointer += -2 - oparg; goto error_tier_two; }
+ if (res == NULL) JUMP_TO_ERROR();
stack_pointer[-2 - oparg] = res;
stack_pointer += -1 - oparg;
break;
@@ -3431,15 +3306,15 @@
args--;
total_args++;
}
- if (total_args != 1) goto deoptimize;
+ if (total_args != 1) JUMP_TO_JUMP_TARGET();
PyMethodDescrObject *method = (PyMethodDescrObject *)callable;
- if (!Py_IS_TYPE(method, &PyMethodDescr_Type)) goto deoptimize;
+ if (!Py_IS_TYPE(method, &PyMethodDescr_Type)) JUMP_TO_JUMP_TARGET();
PyMethodDef *meth = method->d_method;
PyObject *self = args[0];
- if (!Py_IS_TYPE(self, method->d_common.d_type)) goto deoptimize;
- if (meth->ml_flags != METH_NOARGS) goto deoptimize;
+ if (!Py_IS_TYPE(self, method->d_common.d_type)) JUMP_TO_JUMP_TARGET();
+ if (meth->ml_flags != METH_NOARGS) JUMP_TO_JUMP_TARGET();
// CPython promises to check all non-vectorcall function calls.
- if (tstate->c_recursion_remaining <= 0) goto deoptimize;
+ if (tstate->c_recursion_remaining <= 0) JUMP_TO_JUMP_TARGET();
STAT_INC(CALL, hit);
PyCFunction cfunc = meth->ml_meth;
_Py_EnterRecursiveCallTstateUnchecked(tstate);
@@ -3448,7 +3323,7 @@
assert((res != NULL) ^ (_PyErr_Occurred(tstate) != NULL));
Py_DECREF(self);
Py_DECREF(callable);
- if (res == NULL) { stack_pointer += -2 - oparg; goto error_tier_two; }
+ if (res == NULL) JUMP_TO_ERROR();
stack_pointer[-2 - oparg] = res;
stack_pointer += -1 - oparg;
break;
@@ -3470,11 +3345,11 @@
}
PyMethodDescrObject *method = (PyMethodDescrObject *)callable;
/* Builtin METH_FASTCALL methods, without keywords */
- if (!Py_IS_TYPE(method, &PyMethodDescr_Type)) goto deoptimize;
+ if (!Py_IS_TYPE(method, &PyMethodDescr_Type)) JUMP_TO_JUMP_TARGET();
PyMethodDef *meth = method->d_method;
- if (meth->ml_flags != METH_FASTCALL) goto deoptimize;
+ if (meth->ml_flags != METH_FASTCALL) JUMP_TO_JUMP_TARGET();
PyObject *self = args[0];
- if (!Py_IS_TYPE(self, method->d_common.d_type)) goto deoptimize;
+ if (!Py_IS_TYPE(self, method->d_common.d_type)) JUMP_TO_JUMP_TARGET();
STAT_INC(CALL, hit);
PyCFunctionFast cfunc =
(PyCFunctionFast)(void(*)(void))meth->ml_meth;
@@ -3486,19 +3361,19 @@
Py_DECREF(args[i]);
}
Py_DECREF(callable);
- if (res == NULL) { stack_pointer += -2 - oparg; goto error_tier_two; }
+ if (res == NULL) JUMP_TO_ERROR();
stack_pointer[-2 - oparg] = res;
stack_pointer += -1 - oparg;
break;
}
- /* _INSTRUMENTED_CALL_KW is not a viable micro-op for tier 2 */
+ /* _INSTRUMENTED_CALL_KW is not a viable micro-op for tier 2 because it is instrumented */
- /* _CALL_KW is not a viable micro-op for tier 2 */
+ /* _CALL_KW is not a viable micro-op for tier 2 because it uses the 'this_instr' variable */
- /* _INSTRUMENTED_CALL_FUNCTION_EX is not a viable micro-op for tier 2 */
+ /* _INSTRUMENTED_CALL_FUNCTION_EX is not a viable micro-op for tier 2 because it is instrumented */
- /* _CALL_FUNCTION_EX is not a viable micro-op for tier 2 */
+ /* _CALL_FUNCTION_EX is not a viable micro-op for tier 2 because it uses the 'this_instr' variable */
case _MAKE_FUNCTION: {
PyObject *codeobj;
@@ -3508,7 +3383,7 @@
PyFunction_New(codeobj, GLOBALS());
Py_DECREF(codeobj);
if (func_obj == NULL) {
- GOTO_ERROR(error);
+ JUMP_TO_ERROR();
}
_PyFunction_SetVersion(
func_obj, ((PyCodeObject *)codeobj)->co_version);
@@ -3565,7 +3440,7 @@
Py_DECREF(start);
Py_DECREF(stop);
Py_XDECREF(step);
- if (slice == NULL) { stack_pointer += -2 - ((oparg == 3) ? 1 : 0); goto error_tier_two; }
+ if (slice == NULL) JUMP_TO_ERROR();
stack_pointer[-2 - ((oparg == 3) ? 1 : 0)] = slice;
stack_pointer += -1 - ((oparg == 3) ? 1 : 0);
break;
@@ -3581,7 +3456,7 @@
conv_fn = _PyEval_ConversionFuncs[oparg];
result = conv_fn(value);
Py_DECREF(value);
- if (result == NULL) goto pop_1_error_tier_two;
+ if (result == NULL) JUMP_TO_ERROR();
stack_pointer[-1] = result;
break;
}
@@ -3595,7 +3470,7 @@
if (!PyUnicode_CheckExact(value)) {
res = PyObject_Format(value, NULL);
Py_DECREF(value);
- if (res == NULL) goto pop_1_error_tier_two;
+ if (res == NULL) JUMP_TO_ERROR();
}
else {
res = value;
@@ -3613,7 +3488,7 @@
res = PyObject_Format(value, fmt_spec);
Py_DECREF(value);
Py_DECREF(fmt_spec);
- if (res == NULL) goto pop_2_error_tier_two;
+ if (res == NULL) JUMP_TO_ERROR();
stack_pointer[-2] = res;
stack_pointer += -1;
break;
@@ -3642,7 +3517,7 @@
res = _PyEval_BinaryOps[oparg](lhs, rhs);
Py_DECREF(lhs);
Py_DECREF(rhs);
- if (res == NULL) goto pop_2_error_tier_two;
+ if (res == NULL) JUMP_TO_ERROR();
stack_pointer[-2] = res;
stack_pointer += -1;
break;
@@ -3660,25 +3535,25 @@
break;
}
- /* _INSTRUMENTED_INSTRUCTION is not a viable micro-op for tier 2 */
+ /* _INSTRUMENTED_INSTRUCTION is not a viable micro-op for tier 2 because it is instrumented */
- /* _INSTRUMENTED_JUMP_FORWARD is not a viable micro-op for tier 2 */
+ /* _INSTRUMENTED_JUMP_FORWARD is not a viable micro-op for tier 2 because it is instrumented */
- /* _INSTRUMENTED_JUMP_BACKWARD is not a viable micro-op for tier 2 */
+ /* _INSTRUMENTED_JUMP_BACKWARD is not a viable micro-op for tier 2 because it is instrumented */
- /* _INSTRUMENTED_POP_JUMP_IF_TRUE is not a viable micro-op for tier 2 */
+ /* _INSTRUMENTED_POP_JUMP_IF_TRUE is not a viable micro-op for tier 2 because it is instrumented */
- /* _INSTRUMENTED_POP_JUMP_IF_FALSE is not a viable micro-op for tier 2 */
+ /* _INSTRUMENTED_POP_JUMP_IF_FALSE is not a viable micro-op for tier 2 because it is instrumented */
- /* _INSTRUMENTED_POP_JUMP_IF_NONE is not a viable micro-op for tier 2 */
+ /* _INSTRUMENTED_POP_JUMP_IF_NONE is not a viable micro-op for tier 2 because it is instrumented */
- /* _INSTRUMENTED_POP_JUMP_IF_NOT_NONE is not a viable micro-op for tier 2 */
+ /* _INSTRUMENTED_POP_JUMP_IF_NOT_NONE is not a viable micro-op for tier 2 because it is instrumented */
case _GUARD_IS_TRUE_POP: {
PyObject *flag;
flag = stack_pointer[-1];
stack_pointer += -1;
- if (!Py_IsTrue(flag)) goto side_exit;
+ if (!Py_IsTrue(flag)) JUMP_TO_JUMP_TARGET();
assert(Py_IsTrue(flag));
break;
}
@@ -3687,7 +3562,7 @@
PyObject *flag;
flag = stack_pointer[-1];
stack_pointer += -1;
- if (!Py_IsFalse(flag)) goto side_exit;
+ if (!Py_IsFalse(flag)) JUMP_TO_JUMP_TARGET();
assert(Py_IsFalse(flag));
break;
}
@@ -3698,7 +3573,7 @@
stack_pointer += -1;
if (!Py_IsNone(val)) {
Py_DECREF(val);
- if (1) goto side_exit;
+ if (1) JUMP_TO_JUMP_TARGET();
}
break;
}
@@ -3707,7 +3582,7 @@
PyObject *val;
val = stack_pointer[-1];
stack_pointer += -1;
- if (Py_IsNone(val)) goto side_exit;
+ if (Py_IsNone(val)) JUMP_TO_JUMP_TARGET();
Py_DECREF(val);
break;
}
@@ -3738,12 +3613,12 @@
}
case _EXIT_TRACE: {
- if (1) goto side_exit;
+ if (1) JUMP_TO_JUMP_TARGET();
break;
}
case _CHECK_VALIDITY: {
- if (!current_executor->vm_data.valid) goto deoptimize;
+ if (!current_executor->vm_data.valid) JUMP_TO_JUMP_TARGET();
break;
}
@@ -3803,7 +3678,7 @@
case _CHECK_FUNCTION: {
uint32_t func_version = (uint32_t)CURRENT_OPERAND();
assert(PyFunction_Check(frame->f_funcobj));
- if (((PyFunctionObject *)frame->f_funcobj)->func_version != func_version) goto deoptimize;
+ if (((PyFunctionObject *)frame->f_funcobj)->func_version != func_version) JUMP_TO_JUMP_TARGET();
break;
}
@@ -3838,7 +3713,7 @@
if (optimized < 0) {
Py_DECREF(previous);
tstate->previous_executor = Py_None;
- if (1) goto error_tier_two;
+ GOTO_UNWIND();
}
GOTO_TIER_ONE(target);
}
@@ -3869,9 +3744,26 @@
case _CHECK_VALIDITY_AND_SET_IP: {
PyObject *instr_ptr = (PyObject *)CURRENT_OPERAND();
- if (!current_executor->vm_data.valid) goto deoptimize;
+ if (!current_executor->vm_data.valid) JUMP_TO_JUMP_TARGET();
frame->instr_ptr = (_Py_CODEUNIT *)instr_ptr;
break;
}
+ case _DEOPT: {
+ EXIT_TO_TIER1();
+ break;
+ }
+
+ case _SIDE_EXIT: {
+ EXIT_TO_TRACE();
+ break;
+ }
+
+ case _ERROR_POP_N: {
+ oparg = CURRENT_OPARG();
+ stack_pointer += -oparg;
+ GOTO_UNWIND();
+ break;
+ }
+
#undef TIER_TWO
diff --git a/Python/generated_cases.c.h b/Python/generated_cases.c.h
index 2996ee7..c66eb67 100644
--- a/Python/generated_cases.c.h
+++ b/Python/generated_cases.c.h
@@ -25,7 +25,7 @@
"asynchronous context manager protocol",
Py_TYPE(mgr)->tp_name);
}
- GOTO_ERROR(error);
+ goto error;
}
exit = _PyObject_LookupSpecial(mgr, &_Py_ID(__aexit__));
if (exit == NULL) {
@@ -37,7 +37,7 @@
Py_TYPE(mgr)->tp_name);
}
Py_DECREF(enter);
- GOTO_ERROR(error);
+ goto error;
}
Py_DECREF(mgr);
res = PyObject_CallNoArgs(enter);
@@ -71,7 +71,7 @@
"context manager protocol",
Py_TYPE(mgr)->tp_name);
}
- GOTO_ERROR(error);
+ goto error;
}
exit = _PyObject_LookupSpecial(mgr, &_Py_ID(__exit__));
if (exit == NULL) {
@@ -83,7 +83,7 @@
Py_TYPE(mgr)->tp_name);
}
Py_DECREF(enter);
- GOTO_ERROR(error);
+ goto error;
}
Py_DECREF(mgr);
res = PyObject_CallNoArgs(enter);
@@ -605,12 +605,8 @@
PyObject *map;
keys = stack_pointer[-1];
values = &stack_pointer[-1 - oparg];
- if (!PyTuple_CheckExact(keys) ||
- PyTuple_GET_SIZE(keys) != (Py_ssize_t)oparg) {
- _PyErr_SetString(tstate, PyExc_SystemError,
- "bad BUILD_CONST_KEY_MAP keys argument");
- GOTO_ERROR(error); // Pop the keys and values.
- }
+ assert(PyTuple_CheckExact(keys));
+ assert(PyTuple_GET_SIZE(keys) == (Py_ssize_t)oparg);
map = _PyDict_FromItems(
&PyTuple_GET_ITEM(keys, 0), 1,
values, 1, oparg);
@@ -667,7 +663,7 @@
values = &stack_pointer[-oparg];
set = PySet_New(NULL);
if (set == NULL)
- GOTO_ERROR(error);
+ goto error;
int err = 0;
for (int i = 0; i < oparg; i++) {
PyObject *item = values[i];
@@ -808,7 +804,7 @@
// The frame has stolen all the arguments from the stack,
// so there is no need to clean them up.
if (new_frame == NULL) {
- GOTO_ERROR(error);
+ goto error;
}
frame->return_offset = (uint16_t)(next_instr - this_instr);
DISPATCH_INLINED(new_frame);
@@ -882,7 +878,7 @@
STAT_INC(CALL, hit);
PyObject *self = _PyType_NewManagedObject(tp);
if (self == NULL) {
- GOTO_ERROR(error);
+ goto error;
}
Py_DECREF(tp);
_PyInterpreterFrame *shim = _PyFrame_PushTrampolineUnchecked(
@@ -1213,11 +1209,11 @@
assert(kwargs == NULL || PyDict_CheckExact(kwargs));
if (!PyTuple_CheckExact(callargs)) {
if (check_args_iterable(tstate, func, callargs) < 0) {
- GOTO_ERROR(error);
+ goto error;
}
PyObject *tuple = PySequence_Tuple(callargs);
if (tuple == NULL) {
- GOTO_ERROR(error);
+ goto error;
}
Py_SETREF(callargs, tuple);
}
@@ -1229,7 +1225,7 @@
int err = _Py_call_instrumentation_2args(
tstate, PY_MONITORING_EVENT_CALL,
frame, this_instr, func, arg);
- if (err) GOTO_ERROR(error);
+ if (err) goto error;
result = PyObject_Call(func, callargs, kwargs);
if (!PyFunction_Check(func) && !PyMethod_Check(func)) {
if (result == NULL) {
@@ -1261,7 +1257,7 @@
// Need to manually shrink the stack since we exit with DISPATCH_INLINED.
STACK_SHRINK(oparg + 3);
if (new_frame == NULL) {
- GOTO_ERROR(error);
+ goto error;
}
assert(next_instr - this_instr == 1);
frame->return_offset = 1;
@@ -1342,7 +1338,7 @@
PyObject *inst = args[0];
int retval = PyObject_IsInstance(inst, cls);
if (retval < 0) {
- GOTO_ERROR(error);
+ goto error;
}
res = PyBool_FromLong(retval);
assert((res != NULL) ^ (_PyErr_Occurred(tstate) != NULL));
@@ -1407,7 +1403,7 @@
// The frame has stolen all the arguments from the stack,
// so there is no need to clean them up.
if (new_frame == NULL) {
- GOTO_ERROR(error);
+ goto error;
}
assert(next_instr - this_instr == 1);
frame->return_offset = 1;
@@ -1475,7 +1471,7 @@
PyObject *arg = args[0];
Py_ssize_t len_i = PyObject_Length(arg);
if (len_i < 0) {
- GOTO_ERROR(error);
+ goto error;
}
res = PyLong_FromSsize_t(len_i);
assert((res != NULL) ^ (_PyErr_Occurred(tstate) != NULL));
@@ -2329,7 +2325,7 @@
// Fortunately we don't need its superpower.
if (oldobj == NULL) {
_PyEval_FormatExcUnbound(tstate, _PyFrame_GetCode(frame), oparg);
- GOTO_ERROR(error);
+ goto error;
}
PyCell_SET(cell, NULL);
Py_DECREF(oldobj);
@@ -2341,7 +2337,13 @@
next_instr += 1;
INSTRUCTION_STATS(DELETE_FAST);
PyObject *v = GETLOCAL(oparg);
- if (v == NULL) goto unbound_local_error;
+ if (v == NULL) {
+ _PyEval_FormatExcCheckArg(tstate, PyExc_UnboundLocalError,
+ UNBOUNDLOCAL_ERROR_MSG,
+ PyTuple_GetItem(_PyFrame_GetCode(frame)->co_localsplusnames, oparg)
+ );
+ if (1) goto error;
+ }
SETLOCAL(oparg, NULL);
DISPATCH();
}
@@ -2354,12 +2356,12 @@
int err = PyDict_Pop(GLOBALS(), name, NULL);
// Can't use ERROR_IF here.
if (err < 0) {
- GOTO_ERROR(error);
+ goto error;
}
if (err == 0) {
_PyEval_FormatExcCheckArg(tstate, PyExc_NameError,
NAME_ERROR_MSG, name);
- GOTO_ERROR(error);
+ goto error;
}
DISPATCH();
}
@@ -2374,7 +2376,7 @@
if (ns == NULL) {
_PyErr_Format(tstate, PyExc_SystemError,
"no locals when deleting %R", name);
- GOTO_ERROR(error);
+ goto error;
}
err = PyObject_DelItem(ns, name);
// Can't use ERROR_IF here.
@@ -2382,7 +2384,7 @@
_PyEval_FormatExcCheckArg(tstate, PyExc_NameError,
NAME_ERROR_MSG,
name);
- GOTO_ERROR(error);
+ goto error;
}
DISPATCH();
}
@@ -2523,7 +2525,7 @@
PyErr_Format(PyExc_TypeError,
"__init__() should return None, not '%.200s'",
Py_TYPE(should_be_none)->tp_name);
- GOTO_ERROR(error);
+ goto error;
}
stack_pointer += -1;
DISPATCH();
@@ -2610,7 +2612,7 @@
if (next == NULL) {
if (_PyErr_Occurred(tstate)) {
if (!_PyErr_ExceptionMatches(tstate, PyExc_StopIteration)) {
- GOTO_ERROR(error);
+ goto error;
}
monitor_raise(tstate, frame, this_instr);
_PyErr_Clear(tstate);
@@ -2841,7 +2843,7 @@
if (PyAsyncGen_CheckExact(aiter)) {
awaitable = type->tp_as_async->am_anext(aiter);
if (awaitable == NULL) {
- GOTO_ERROR(error);
+ goto error;
}
} else {
if (type->tp_as_async != NULL){
@@ -2850,7 +2852,7 @@
if (getter != NULL) {
next_iter = (*getter)(aiter);
if (next_iter == NULL) {
- GOTO_ERROR(error);
+ goto error;
}
}
else {
@@ -2858,7 +2860,7 @@
"'async for' requires an iterator with "
"__anext__ method, got %.100s",
type->tp_name);
- GOTO_ERROR(error);
+ goto error;
}
awaitable = _PyCoro_GetAwaitableIter(next_iter);
if (awaitable == NULL) {
@@ -2868,7 +2870,7 @@
"from __anext__: %.100s",
Py_TYPE(next_iter)->tp_name);
Py_DECREF(next_iter);
- GOTO_ERROR(error);
+ goto error;
} else {
Py_DECREF(next_iter);
}
@@ -2956,7 +2958,7 @@
_PyErr_SetString(tstate, PyExc_TypeError,
"cannot 'yield from' a coroutine object "
"in a non-coroutine generator");
- GOTO_ERROR(error);
+ goto error;
}
iter = iterable;
}
@@ -2967,7 +2969,7 @@
/* `iterable` is not a generator. */
iter = PyObject_GetIter(iterable);
if (iter == NULL) {
- GOTO_ERROR(error);
+ goto error;
}
Py_DECREF(iterable);
}
@@ -3066,7 +3068,7 @@
if (PyGen_Check(receiver)) {
PyErr_SetObject(PyExc_StopIteration, value);
if (monitor_stop_iteration(tstate, frame, this_instr)) {
- GOTO_ERROR(error);
+ goto error;
}
PyErr_SetRaisedException(NULL);
}
@@ -3087,7 +3089,7 @@
if (PyGen_Check(receiver) || PyCoro_CheckExact(receiver)) {
PyErr_SetObject(PyExc_StopIteration, value);
if (monitor_stop_iteration(tstate, frame, this_instr)) {
- GOTO_ERROR(error);
+ goto error;
}
PyErr_SetRaisedException(NULL);
}
@@ -3113,7 +3115,7 @@
else {
if (_PyErr_Occurred(tstate)) {
if (!_PyErr_ExceptionMatches(tstate, PyExc_StopIteration)) {
- GOTO_ERROR(error);
+ goto error;
}
monitor_raise(tstate, frame, this_instr);
_PyErr_Clear(tstate);
@@ -3268,7 +3270,7 @@
uintptr_t code_version = _PyFrame_GetCode(frame)->_co_instrumentation_version;
if (code_version != global_version) {
if (_Py_Instrument(_PyFrame_GetCode(frame), tstate->interp)) {
- GOTO_ERROR(error);
+ goto error;
}
next_instr = this_instr;
}
@@ -3299,7 +3301,7 @@
int err = _Py_call_instrumentation_arg(
tstate, PY_MONITORING_EVENT_PY_RETURN,
frame, this_instr, retval);
- if (err) GOTO_ERROR(error);
+ if (err) goto error;
Py_INCREF(retval);
assert(EMPTY());
_PyFrame_SetStackPointer(frame, stack_pointer);
@@ -3324,7 +3326,7 @@
int err = _Py_call_instrumentation_arg(
tstate, PY_MONITORING_EVENT_PY_RETURN,
frame, this_instr, retval);
- if (err) GOTO_ERROR(error);
+ if (err) goto error;
STACK_SHRINK(1);
assert(EMPTY());
_PyFrame_SetStackPointer(frame, stack_pointer);
@@ -3356,7 +3358,7 @@
int err = _Py_call_instrumentation_arg(
tstate, PY_MONITORING_EVENT_PY_YIELD,
frame, this_instr, retval);
- if (err) GOTO_ERROR(error);
+ if (err) goto error;
tstate->exc_info = gen->gi_exc_state.previous_item;
gen->gi_exc_state.previous_item = NULL;
_Py_LeaveRecursiveCallPy(tstate);
@@ -4138,7 +4140,13 @@
INSTRUCTION_STATS(LOAD_FAST_CHECK);
PyObject *value;
value = GETLOCAL(oparg);
- if (value == NULL) goto unbound_local_error;
+ if (value == NULL) {
+ _PyEval_FormatExcCheckArg(tstate, PyExc_UnboundLocalError,
+ UNBOUNDLOCAL_ERROR_MSG,
+ PyTuple_GetItem(_PyFrame_GetCode(frame)->co_localsplusnames, oparg)
+ );
+ if (1) goto error;
+ }
Py_INCREF(value);
stack_pointer[0] = value;
stack_pointer += 1;
@@ -4175,14 +4183,14 @@
assert(oparg >= 0 && oparg < _PyFrame_GetCode(frame)->co_nlocalsplus);
name = PyTuple_GET_ITEM(_PyFrame_GetCode(frame)->co_localsplusnames, oparg);
if (PyMapping_GetOptionalItem(class_dict, name, &value) < 0) {
- GOTO_ERROR(error);
+ goto error;
}
if (!value) {
PyObject *cell = GETLOCAL(oparg);
value = PyCell_GET(cell);
if (value == NULL) {
_PyEval_FormatExcUnbound(tstate, _PyFrame_GetCode(frame), oparg);
- GOTO_ERROR(error);
+ goto error;
}
Py_INCREF(value);
}
@@ -4200,21 +4208,21 @@
mod_or_class_dict = stack_pointer[-1];
PyObject *name = GETITEM(FRAME_CO_NAMES, oparg);
if (PyMapping_GetOptionalItem(mod_or_class_dict, name, &v) < 0) {
- GOTO_ERROR(error);
+ goto error;
}
if (v == NULL) {
if (PyDict_GetItemRef(GLOBALS(), name, &v) < 0) {
- GOTO_ERROR(error);
+ goto error;
}
if (v == NULL) {
if (PyMapping_GetOptionalItem(BUILTINS(), name, &v) < 0) {
- GOTO_ERROR(error);
+ goto error;
}
if (v == NULL) {
_PyEval_FormatExcCheckArg(
tstate, PyExc_NameError,
NAME_ERROR_MSG, name);
- GOTO_ERROR(error);
+ goto error;
}
}
}
@@ -4398,21 +4406,21 @@
}
PyObject *name = GETITEM(FRAME_CO_NAMES, oparg);
if (PyMapping_GetOptionalItem(mod_or_class_dict, name, &v) < 0) {
- GOTO_ERROR(error);
+ goto error;
}
if (v == NULL) {
if (PyDict_GetItemRef(GLOBALS(), name, &v) < 0) {
- GOTO_ERROR(error);
+ goto error;
}
if (v == NULL) {
if (PyMapping_GetOptionalItem(BUILTINS(), name, &v) < 0) {
- GOTO_ERROR(error);
+ goto error;
}
if (v == NULL) {
_PyEval_FormatExcCheckArg(
tstate, PyExc_NameError,
NAME_ERROR_MSG, name);
- GOTO_ERROR(error);
+ goto error;
}
}
}
@@ -4574,7 +4582,7 @@
PyObject *initial = GETLOCAL(oparg);
PyObject *cell = PyCell_New(initial);
if (cell == NULL) {
- GOTO_ERROR(error);
+ goto error;
}
SETLOCAL(oparg, cell);
DISPATCH();
@@ -4591,7 +4599,7 @@
PyFunction_New(codeobj, GLOBALS());
Py_DECREF(codeobj);
if (func_obj == NULL) {
- GOTO_ERROR(error);
+ goto error;
}
_PyFunction_SetVersion(
func_obj, ((PyCodeObject *)codeobj)->co_version);
@@ -4910,7 +4918,7 @@
else {
assert(PyLong_Check(lasti));
_PyErr_SetString(tstate, PyExc_SystemError, "lasti is not an int");
- GOTO_ERROR(error);
+ goto error;
}
}
assert(exc && PyExceptionInstance_Check(exc));
@@ -5017,7 +5025,7 @@
PyFunctionObject *func = (PyFunctionObject *)frame->f_funcobj;
PyGenObject *gen = (PyGenObject *)_Py_MakeCoro(func);
if (gen == NULL) {
- GOTO_ERROR(error);
+ goto error;
}
assert(EMPTY());
_PyFrame_SetStackPointer(frame, stack_pointer);
@@ -5126,7 +5134,7 @@
JUMPBY(oparg);
}
else {
- GOTO_ERROR(error);
+ goto error;
}
}
Py_DECREF(v);
diff --git a/Python/jit.c b/Python/jit.c
index f67d641..03bcf11 100644
--- a/Python/jit.c
+++ b/Python/jit.c
@@ -381,11 +381,13 @@ int
_PyJIT_Compile(_PyExecutorObject *executor, const _PyUOpInstruction *trace, size_t length)
{
// Loop once to find the total compiled size:
- size_t code_size = 0;
- size_t data_size = 0;
+ uint32_t instruction_starts[UOP_MAX_TRACE_LENGTH];
+ uint32_t code_size = 0;
+ uint32_t data_size = 0;
for (size_t i = 0; i < length; i++) {
_PyUOpInstruction *instruction = (_PyUOpInstruction *)&trace[i];
const StencilGroup *group = &stencil_groups[instruction->opcode];
+ instruction_starts[i] = code_size;
code_size += group->code.body_size;
data_size += group->data.body_size;
}
@@ -403,11 +405,7 @@ _PyJIT_Compile(_PyExecutorObject *executor, const _PyUOpInstruction *trace, size
// Loop again to emit the code:
unsigned char *code = memory;
unsigned char *data = memory + code_size;
- unsigned char *top = code;
- if (trace[0].opcode == _START_EXECUTOR) {
- // Don't want to execute this more than once:
- top += stencil_groups[_START_EXECUTOR].code.body_size;
- }
+ assert(trace[0].opcode == _START_EXECUTOR || trace[0].opcode == _COLD_EXIT);
for (size_t i = 0; i < length; i++) {
_PyUOpInstruction *instruction = (_PyUOpInstruction *)&trace[i];
const StencilGroup *group = &stencil_groups[instruction->opcode];
@@ -419,8 +417,29 @@ _PyJIT_Compile(_PyExecutorObject *executor, const _PyUOpInstruction *trace, size
patches[HoleValue_EXECUTOR] = (uint64_t)executor;
patches[HoleValue_OPARG] = instruction->oparg;
patches[HoleValue_OPERAND] = instruction->operand;
- patches[HoleValue_TARGET] = instruction->target;
- patches[HoleValue_TOP] = (uint64_t)top;
+ switch (instruction->format) {
+ case UOP_FORMAT_TARGET:
+ patches[HoleValue_TARGET] = instruction->target;
+ break;
+ case UOP_FORMAT_EXIT:
+ assert(instruction->exit_index < executor->exit_count);
+ patches[HoleValue_EXIT_INDEX] = instruction->exit_index;
+ if (instruction->error_target < length) {
+ patches[HoleValue_ERROR_TARGET] = (uint64_t)memory + instruction_starts[instruction->error_target];
+ }
+ break;
+ case UOP_FORMAT_JUMP:
+ assert(instruction->jump_target < length);
+ patches[HoleValue_JUMP_TARGET] = (uint64_t)memory + instruction_starts[instruction->jump_target];
+ if (instruction->error_target < length) {
+ patches[HoleValue_ERROR_TARGET] = (uint64_t)memory + instruction_starts[instruction->error_target];
+ }
+ break;
+ default:
+ assert(0);
+ Py_FatalError("Illegal instruction format");
+ }
+ patches[HoleValue_TOP] = (uint64_t)memory + instruction_starts[1];
patches[HoleValue_ZERO] = 0;
emit(group, patches);
code += group->code.body_size;
diff --git a/Python/optimizer.c b/Python/optimizer.c
index f8c1390..38ab6d3 100644
--- a/Python/optimizer.c
+++ b/Python/optimizer.c
@@ -154,13 +154,19 @@ PyUnstable_GetOptimizer(void)
}
static _PyExecutorObject *
-make_executor_from_uops(_PyUOpInstruction *buffer, const _PyBloomFilter *dependencies);
+make_executor_from_uops(_PyUOpInstruction *buffer, int length, const _PyBloomFilter *dependencies);
static int
init_cold_exit_executor(_PyExecutorObject *executor, int oparg);
+/* It is impossible for the number of exits to reach 1/4 of the total length,
+ * as the number of exits cannot reach 1/3 of the number of non-exits, due to
+ * the presence of CHECK_VALIDITY checks and instructions to produce the values
+ * being checked in exits. */
+#define COLD_EXIT_COUNT (UOP_MAX_TRACE_LENGTH/4)
+
static int cold_exits_initialized = 0;
-static _PyExecutorObject COLD_EXITS[UOP_MAX_TRACE_LENGTH] = { 0 };
+static _PyExecutorObject COLD_EXITS[COLD_EXIT_COUNT] = { 0 };
static const _PyBloomFilter EMPTY_FILTER = { 0 };
@@ -172,7 +178,7 @@ _Py_SetOptimizer(PyInterpreterState *interp, _PyOptimizerObject *optimizer)
}
else if (cold_exits_initialized == 0) {
cold_exits_initialized = 1;
- for (int i = 0; i < UOP_MAX_TRACE_LENGTH; i++) {
+ for (int i = 0; i < COLD_EXIT_COUNT; i++) {
if (init_cold_exit_executor(&COLD_EXITS[i], i)) {
return NULL;
}
@@ -313,10 +319,33 @@ _PyUOpPrint(const _PyUOpInstruction *uop)
else {
printf("%s", name);
}
- printf(" (%d, target=%d, operand=%#" PRIx64 ")",
- uop->oparg,
- uop->target,
- (uint64_t)uop->operand);
+ switch(uop->format) {
+ case UOP_FORMAT_TARGET:
+ printf(" (%d, target=%d, operand=%#" PRIx64,
+ uop->oparg,
+ uop->target,
+ (uint64_t)uop->operand);
+ break;
+ case UOP_FORMAT_JUMP:
+ printf(" (%d, jump_target=%d, operand=%#" PRIx64,
+ uop->oparg,
+ uop->jump_target,
+ (uint64_t)uop->operand);
+ break;
+ case UOP_FORMAT_EXIT:
+ printf(" (%d, exit_index=%d, operand=%#" PRIx64,
+ uop->oparg,
+ uop->exit_index,
+ (uint64_t)uop->operand);
+ break;
+ default:
+ printf(" (%d, Unknown format)", uop->oparg);
+ }
+ if (_PyUop_Flags[uop->opcode] & HAS_ERROR_FLAG) {
+ printf(", error_target=%d", uop->error_target);
+ }
+
+ printf(")");
}
#endif
@@ -432,28 +461,36 @@ BRANCH_TO_GUARD[4][2] = {
#endif
-// Beware: Macro arg order differs from struct member order
+static inline int
+add_to_trace(
+ _PyUOpInstruction *trace,
+ int trace_length,
+ uint16_t opcode,
+ uint16_t oparg,
+ uint64_t operand,
+ uint32_t target)
+{
+ trace[trace_length].opcode = opcode;
+ trace[trace_length].format = UOP_FORMAT_TARGET;
+ trace[trace_length].target = target;
+ trace[trace_length].oparg = oparg;
+ trace[trace_length].operand = operand;
+ return trace_length + 1;
+}
+
#ifdef Py_DEBUG
#define ADD_TO_TRACE(OPCODE, OPARG, OPERAND, TARGET) \
assert(trace_length < max_length); \
- trace[trace_length].opcode = (OPCODE); \
- trace[trace_length].oparg = (OPARG); \
- trace[trace_length].target = (TARGET); \
- trace[trace_length].operand = (OPERAND); \
+ trace_length = add_to_trace(trace, trace_length, (OPCODE), (OPARG), (OPERAND), (TARGET)); \
if (lltrace >= 2) { \
printf("%4d ADD_TO_TRACE: ", trace_length); \
- _PyUOpPrint(&trace[trace_length]); \
+ _PyUOpPrint(&trace[trace_length-1]); \
printf("\n"); \
- } \
- trace_length++;
+ }
#else
#define ADD_TO_TRACE(OPCODE, OPARG, OPERAND, TARGET) \
assert(trace_length < max_length); \
- trace[trace_length].opcode = (OPCODE); \
- trace[trace_length].oparg = (OPARG); \
- trace[trace_length].target = (TARGET); \
- trace[trace_length].operand = (OPERAND); \
- trace_length++;
+ trace_length = add_to_trace(trace, trace_length, (OPCODE), (OPARG), (OPERAND), (TARGET));
#endif
#define INSTR_IP(INSTR, CODE) \
@@ -476,8 +513,7 @@ BRANCH_TO_GUARD[4][2] = {
if (trace_stack_depth >= TRACE_STACK_SIZE) { \
DPRINTF(2, "Trace stack overflow\n"); \
OPT_STAT_INC(trace_stack_overflow); \
- ADD_TO_TRACE(uop, oparg, operand, target); \
- ADD_TO_TRACE(_EXIT_TRACE, 0, 0, 0); \
+ trace_length = 0; \
goto done; \
} \
assert(func == NULL || func->func_code == (PyObject *)code); \
@@ -495,7 +531,7 @@ BRANCH_TO_GUARD[4][2] = {
assert(func == NULL || func->func_code == (PyObject *)code); \
instr = trace_stack[trace_stack_depth].instr;
-/* Returns 1 on success,
+/* Returns the length of the trace on success,
* 0 if it failed to produce a worthwhile trace,
* and -1 on an error.
*/
@@ -515,7 +551,8 @@ translate_bytecode_to_trace(
_Py_BloomFilter_Add(dependencies, initial_code);
_Py_CODEUNIT *initial_instr = instr;
int trace_length = 0;
- int max_length = buffer_size;
+ // Leave space for possible trailing _EXIT_TRACE
+ int max_length = buffer_size-2;
struct {
PyFunctionObject *func;
PyCodeObject *code;
@@ -538,13 +575,16 @@ translate_bytecode_to_trace(
PyUnicode_AsUTF8(code->co_filename),
code->co_firstlineno,
2 * INSTR_IP(initial_instr, code));
+ ADD_TO_TRACE(_START_EXECUTOR, 0, (uintptr_t)instr, INSTR_IP(instr, code));
uint32_t target = 0;
top: // Jump here after _PUSH_FRAME or likely branches
for (;;) {
target = INSTR_IP(instr, code);
- RESERVE_RAW(2, "epilogue"); // Always need space for _SET_IP, _CHECK_VALIDITY and _EXIT_TRACE
+ RESERVE_RAW(2, "_CHECK_VALIDITY_AND_SET_IP");
ADD_TO_TRACE(_CHECK_VALIDITY_AND_SET_IP, 0, (uintptr_t)instr, target);
+ // Need space for _DEOPT
+ max_length--;
uint32_t opcode = instr->op.code;
uint32_t oparg = instr->op.arg;
@@ -582,13 +622,22 @@ top: // Jump here after _PUSH_FRAME or likely branches
continue;
}
else {
- if (OPCODE_HAS_DEOPT(opcode)) {
+ if (OPCODE_HAS_EXIT(opcode) || OPCODE_HAS_DEOPT(opcode)) {
opcode = _PyOpcode_Deopt[opcode];
}
+ assert(!OPCODE_HAS_EXIT(opcode));
assert(!OPCODE_HAS_DEOPT(opcode));
}
}
+ if (OPCODE_HAS_EXIT(opcode)) {
+ // Make space for exit code
+ max_length--;
+ }
+ if (OPCODE_HAS_ERROR(opcode)) {
+ // Make space for error code
+ max_length--;
+ }
switch (opcode) {
case POP_JUMP_IF_NONE:
case POP_JUMP_IF_NOT_NONE:
@@ -624,10 +673,10 @@ top: // Jump here after _PUSH_FRAME or likely branches
DPRINTF(2, "Jump likely (%04x = %d bits), continue at byte offset %d\n",
instr[1].cache, bitcount, 2 * INSTR_IP(target_instr, code));
instr = target_instr;
- ADD_TO_TRACE(uopcode, max_length, 0, INSTR_IP(next_instr, code));
+ ADD_TO_TRACE(uopcode, 0, 0, INSTR_IP(next_instr, code));
goto top;
}
- ADD_TO_TRACE(uopcode, max_length, 0, INSTR_IP(target_instr, code));
+ ADD_TO_TRACE(uopcode, 0, 0, INSTR_IP(target_instr, code));
break;
}
@@ -849,7 +898,9 @@ done:
progress_needed ? "no progress" : "too short");
return 0;
}
- ADD_TO_TRACE(_EXIT_TRACE, 0, 0, target);
+ if (trace[trace_length-1].opcode != _JUMP_TO_TOP) {
+ ADD_TO_TRACE(_EXIT_TRACE, 0, 0, target);
+ }
DPRINTF(1,
"Created a proto-trace for %s (%s:%d) at byte offset %d -- length %d\n",
PyUnicode_AsUTF8(code->co_qualname),
@@ -857,8 +908,8 @@ done:
code->co_firstlineno,
2 * INSTR_IP(initial_instr, code),
trace_length);
- OPT_HIST(trace_length + buffer_size - max_length, trace_length_hist);
- return 1;
+ OPT_HIST(trace_length, trace_length_hist);
+ return trace_length;
}
#undef RESERVE
@@ -871,43 +922,86 @@ done:
#define SET_BIT(array, bit) (array[(bit)>>5] |= (1<<((bit)&31)))
#define BIT_IS_SET(array, bit) (array[(bit)>>5] & (1<<((bit)&31)))
-/* Count the number of used uops, and mark them in the bit vector `used`.
- * This can be done in a single pass using simple reachability analysis,
- * as there are no backward jumps.
- * NOPs are excluded from the count.
+/* Count the number of unused uops and exits
*/
static int
-compute_used(_PyUOpInstruction *buffer, uint32_t *used, int *exit_count_ptr)
+count_exits(_PyUOpInstruction *buffer, int length)
{
- int count = 0;
int exit_count = 0;
- SET_BIT(used, 0);
- for (int i = 0; i < UOP_MAX_TRACE_LENGTH; i++) {
- if (!BIT_IS_SET(used, i)) {
- continue;
- }
- count++;
+ for (int i = 0; i < length; i++) {
int opcode = buffer[i].opcode;
- if (_PyUop_Flags[opcode] & HAS_EXIT_FLAG) {
+ if (opcode == _SIDE_EXIT) {
exit_count++;
}
- if (opcode == _JUMP_TO_TOP || opcode == _EXIT_TRACE) {
- continue;
+ }
+ return exit_count;
+}
+
+static void make_exit(_PyUOpInstruction *inst, int opcode, int target)
+{
+ inst->opcode = opcode;
+ inst->oparg = 0;
+ inst->format = UOP_FORMAT_TARGET;
+ inst->target = target;
+}
+
+/* Convert implicit exits, errors and deopts
+ * into explicit ones. */
+static int
+prepare_for_execution(_PyUOpInstruction *buffer, int length)
+{
+ int32_t current_jump = -1;
+ int32_t current_jump_target = -1;
+ int32_t current_error = -1;
+ int32_t current_error_target = -1;
+ int32_t current_popped = -1;
+ /* Leaving in NOPs slows down the interpreter and messes up the stats */
+ _PyUOpInstruction *copy_to = &buffer[0];
+ for (int i = 0; i < length; i++) {
+ _PyUOpInstruction *inst = &buffer[i];
+ if (inst->opcode != _NOP) {
+ if (copy_to != inst) {
+ *copy_to = *inst;
+ }
+ copy_to++;
}
- /* All other micro-ops fall through, so i+1 is reachable */
- SET_BIT(used, i+1);
- assert(opcode <= MAX_UOP_ID);
- if (_PyUop_Flags[opcode] & HAS_JUMP_FLAG) {
- /* Mark target as reachable */
- SET_BIT(used, buffer[i].oparg);
+ }
+ length = (int)(copy_to - buffer);
+ int next_spare = length;
+ for (int i = 0; i < length; i++) {
+ _PyUOpInstruction *inst = &buffer[i];
+ int opcode = inst->opcode;
+ int32_t target = (int32_t)uop_get_target(inst);
+ if (_PyUop_Flags[opcode] & (HAS_EXIT_FLAG | HAS_DEOPT_FLAG)) {
+ if (target != current_jump_target) {
+ uint16_t exit_op = (_PyUop_Flags[opcode] & HAS_EXIT_FLAG) ? _SIDE_EXIT : _DEOPT;
+ make_exit(&buffer[next_spare], exit_op, target);
+ current_jump_target = target;
+ current_jump = next_spare;
+ next_spare++;
+ }
+ buffer[i].jump_target = current_jump;
+ buffer[i].format = UOP_FORMAT_JUMP;
}
- if (opcode == NOP) {
- count--;
- UNSET_BIT(used, i);
+ if (_PyUop_Flags[opcode] & HAS_ERROR_FLAG) {
+ int popped = (_PyUop_Flags[opcode] & HAS_ERROR_NO_POP_FLAG) ?
+ 0 : _PyUop_num_popped(opcode, inst->oparg);
+ if (target != current_error_target || popped != current_popped) {
+ current_popped = popped;
+ current_error = next_spare;
+ current_error_target = target;
+ make_exit(&buffer[next_spare], _ERROR_POP_N, 0);
+ buffer[next_spare].oparg = popped;
+ next_spare++;
+ }
+ buffer[i].error_target = current_error;
+ if (buffer[i].format == UOP_FORMAT_TARGET) {
+ buffer[i].format = UOP_FORMAT_JUMP;
+ buffer[i].jump_target = 0;
+ }
}
}
- *exit_count_ptr = exit_count;
- return count;
+ return next_spare;
}
/* Executor side exits */
@@ -926,61 +1020,118 @@ allocate_executor(int exit_count, int length)
return res;
}
+#ifdef Py_DEBUG
+
+#define CHECK(PRED) \
+if (!(PRED)) { \
+ printf(#PRED " at %d\n", i); \
+ assert(0); \
+}
+
+static int
+target_unused(int opcode)
+{
+ return (_PyUop_Flags[opcode] & (HAS_ERROR_FLAG | HAS_EXIT_FLAG | HAS_DEOPT_FLAG)) == 0;
+}
+
+static void
+sanity_check(_PyExecutorObject *executor)
+{
+ for (uint32_t i = 0; i < executor->exit_count; i++) {
+ _PyExitData *exit = &executor->exits[i];
+ CHECK(exit->target < (1 << 25));
+ }
+ bool ended = false;
+ uint32_t i = 0;
+ CHECK(executor->trace[0].opcode == _START_EXECUTOR || executor->trace[0].opcode == _COLD_EXIT);
+ for (; i < executor->code_size; i++) {
+ const _PyUOpInstruction *inst = &executor->trace[i];
+ uint16_t opcode = inst->opcode;
+ CHECK(opcode <= MAX_UOP_ID);
+ CHECK(_PyOpcode_uop_name[opcode] != NULL);
+ switch(inst->format) {
+ case UOP_FORMAT_TARGET:
+ CHECK(target_unused(opcode));
+ break;
+ case UOP_FORMAT_EXIT:
+ CHECK(opcode == _SIDE_EXIT);
+ CHECK(inst->exit_index < executor->exit_count);
+ break;
+ case UOP_FORMAT_JUMP:
+ CHECK(inst->jump_target < executor->code_size);
+ break;
+ case UOP_FORMAT_UNUSED:
+ CHECK(0);
+ break;
+ }
+ if (_PyUop_Flags[opcode] & HAS_ERROR_FLAG) {
+ CHECK(inst->format == UOP_FORMAT_JUMP);
+ CHECK(inst->error_target < executor->code_size);
+ }
+ if (opcode == _JUMP_TO_TOP || opcode == _EXIT_TRACE || opcode == _COLD_EXIT) {
+ ended = true;
+ i++;
+ break;
+ }
+ }
+ CHECK(ended);
+ for (; i < executor->code_size; i++) {
+ const _PyUOpInstruction *inst = &executor->trace[i];
+ uint16_t opcode = inst->opcode;
+ CHECK(
+ opcode == _DEOPT ||
+ opcode == _SIDE_EXIT ||
+ opcode == _ERROR_POP_N);
+ if (opcode == _SIDE_EXIT) {
+ CHECK(inst->format == UOP_FORMAT_EXIT);
+ }
+ }
+}
+
+#undef CHECK
+#endif
+
/* Makes an executor from a buffer of uops.
* Account for the buffer having gaps and NOPs by computing a "used"
* bit vector and only copying the used uops. Here "used" means reachable
* and not a NOP.
*/
static _PyExecutorObject *
-make_executor_from_uops(_PyUOpInstruction *buffer, const _PyBloomFilter *dependencies)
+make_executor_from_uops(_PyUOpInstruction *buffer, int length, const _PyBloomFilter *dependencies)
{
- uint32_t used[(UOP_MAX_TRACE_LENGTH + 31)/32] = { 0 };
- int exit_count;
- int length = compute_used(buffer, used, &exit_count);
- length += 1; // For _START_EXECUTOR
+ int exit_count = count_exits(buffer, length);
_PyExecutorObject *executor = allocate_executor(exit_count, length);
if (executor == NULL) {
return NULL;
}
- OPT_HIST(length, optimized_trace_length_hist);
/* Initialize exits */
+ assert(exit_count < COLD_EXIT_COUNT);
for (int i = 0; i < exit_count; i++) {
executor->exits[i].executor = &COLD_EXITS[i];
executor->exits[i].temperature = 0;
}
int next_exit = exit_count-1;
- _PyUOpInstruction *dest = (_PyUOpInstruction *)&executor->trace[length-1];
- /* Scan backwards, so that we see the destinations of jumps before the jumps themselves. */
- for (int i = UOP_MAX_TRACE_LENGTH-1; i >= 0; i--) {
- if (!BIT_IS_SET(used, i)) {
- continue;
- }
- *dest = buffer[i];
+ _PyUOpInstruction *dest = (_PyUOpInstruction *)&executor->trace[length];
+ assert(buffer[0].opcode == _START_EXECUTOR);
+ buffer[0].operand = (uint64_t)executor;
+ for (int i = length-1; i >= 0; i--) {
int opcode = buffer[i].opcode;
- if (opcode == _POP_JUMP_IF_FALSE ||
- opcode == _POP_JUMP_IF_TRUE)
- {
- /* The oparg of the target will already have been set to its new offset */
- int oparg = dest->oparg;
- dest->oparg = buffer[oparg].oparg;
- }
- if (_PyUop_Flags[opcode] & HAS_EXIT_FLAG) {
+ dest--;
+ *dest = buffer[i];
+ assert(opcode != _POP_JUMP_IF_FALSE && opcode != _POP_JUMP_IF_TRUE);
+ if (opcode == _SIDE_EXIT) {
executor->exits[next_exit].target = buffer[i].target;
dest->exit_index = next_exit;
+ dest->format = UOP_FORMAT_EXIT;
next_exit--;
}
- /* Set the oparg to be the destination offset,
- * so that we can set the oparg of earlier jumps correctly. */
- buffer[i].oparg = (uint16_t)(dest - executor->trace);
- dest--;
}
assert(next_exit == -1);
assert(dest == executor->trace);
- dest->opcode = _START_EXECUTOR;
+ assert(dest->opcode == _START_EXECUTOR);
dest->oparg = 0;
dest->target = 0;
- dest->operand = (uintptr_t)executor;
_Py_ExecutorInit(executor, dependencies);
#ifdef Py_DEBUG
char *python_lltrace = Py_GETENV("PYTHON_LLTRACE");
@@ -996,6 +1147,7 @@ make_executor_from_uops(_PyUOpInstruction *buffer, const _PyBloomFilter *depende
printf("\n");
}
}
+ sanity_check(executor);
#endif
#ifdef _Py_JIT
executor->jit_code = NULL;
@@ -1024,6 +1176,9 @@ init_cold_exit_executor(_PyExecutorObject *executor, int oparg)
for (int i = 0; i < BLOOM_FILTER_WORDS; i++) {
assert(executor->vm_data.bloom.bits[i] == 0);
}
+#ifdef Py_DEBUG
+ sanity_check(executor);
+#endif
#ifdef _Py_JIT
executor->jit_code = NULL;
executor->jit_size = 0;
@@ -1034,6 +1189,28 @@ init_cold_exit_executor(_PyExecutorObject *executor, int oparg)
return 0;
}
+#ifdef Py_STATS
+/* Returns the effective trace length.
+ * Ignores NOPs and trailing exit and error handling.*/
+int effective_trace_length(_PyUOpInstruction *buffer, int length)
+{
+ int nop_count = 0;
+ for (int i = 0; i < length; i++) {
+ int opcode = buffer[i].opcode;
+ if (opcode == _NOP) {
+ nop_count++;
+ }
+ if (opcode == _EXIT_TRACE ||
+ opcode == _JUMP_TO_TOP ||
+ opcode == _COLD_EXIT) {
+ return i+1-nop_count;
+ }
+ }
+ Py_FatalError("No terminating instruction");
+ Py_UNREACHABLE();
+}
+#endif
+
static int
uop_optimize(
_PyOptimizerObject *self,
@@ -1046,24 +1223,26 @@ uop_optimize(
_Py_BloomFilter_Init(&dependencies);
_PyUOpInstruction buffer[UOP_MAX_TRACE_LENGTH];
OPT_STAT_INC(attempts);
- int err = translate_bytecode_to_trace(frame, instr, buffer, UOP_MAX_TRACE_LENGTH, &dependencies);
- if (err <= 0) {
+ int length = translate_bytecode_to_trace(frame, instr, buffer, UOP_MAX_TRACE_LENGTH, &dependencies);
+ if (length <= 0) {
// Error or nothing translated
- return err;
+ return length;
}
+ assert(length < UOP_MAX_TRACE_LENGTH);
OPT_STAT_INC(traces_created);
char *env_var = Py_GETENV("PYTHON_UOPS_OPTIMIZE");
if (env_var == NULL || *env_var == '\0' || *env_var > '0') {
- err = _Py_uop_analyze_and_optimize(frame, buffer,
- UOP_MAX_TRACE_LENGTH,
+ length = _Py_uop_analyze_and_optimize(frame, buffer,
+ length,
curr_stackentries, &dependencies);
- if (err <= 0) {
- return err;
+ if (length <= 0) {
+ return length;
}
}
- assert(err == 1);
+ assert(length < UOP_MAX_TRACE_LENGTH);
+ assert(length >= 1);
/* Fix up */
- for (int pc = 0; pc < UOP_MAX_TRACE_LENGTH; pc++) {
+ for (int pc = 0; pc < length; pc++) {
int opcode = buffer[pc].opcode;
int oparg = buffer[pc].oparg;
if (_PyUop_Flags[opcode] & HAS_OPARG_AND_1_FLAG) {
@@ -1078,10 +1257,14 @@ uop_optimize(
assert(_PyOpcode_uop_name[buffer[pc].opcode]);
assert(strncmp(_PyOpcode_uop_name[buffer[pc].opcode], _PyOpcode_uop_name[opcode], strlen(_PyOpcode_uop_name[opcode])) == 0);
}
- _PyExecutorObject *executor = make_executor_from_uops(buffer, &dependencies);
+ OPT_HIST(effective_trace_length(buffer, length), optimized_trace_length_hist);
+ length = prepare_for_execution(buffer, length);
+ assert(length <= UOP_MAX_TRACE_LENGTH);
+ _PyExecutorObject *executor = make_executor_from_uops(buffer, length, &dependencies);
if (executor == NULL) {
return -1;
}
+ assert(length <= UOP_MAX_TRACE_LENGTH);
*exec_ptr = executor;
return 1;
}
@@ -1156,12 +1339,14 @@ counter_optimize(
return 0;
}
_Py_CODEUNIT *target = instr + 1 + _PyOpcode_Caches[JUMP_BACKWARD] - oparg;
- _PyUOpInstruction buffer[3] = {
+ _PyUOpInstruction buffer[5] = {
+ { .opcode = _START_EXECUTOR },
{ .opcode = _LOAD_CONST_INLINE_BORROW, .operand = (uintptr_t)self },
{ .opcode = _INTERNAL_INCREMENT_OPT_COUNTER },
- { .opcode = _EXIT_TRACE, .target = (uint32_t)(target - _PyCode_CODE(code)) }
+ { .opcode = _EXIT_TRACE, .jump_target = 4, .format=UOP_FORMAT_JUMP },
+ { .opcode = _SIDE_EXIT, .target = (uint32_t)(target - _PyCode_CODE(code)), .format=UOP_FORMAT_TARGET }
};
- _PyExecutorObject *executor = make_executor_from_uops(buffer, &EMPTY_FILTER);
+ _PyExecutorObject *executor = make_executor_from_uops(buffer, 5, &EMPTY_FILTER);
if (executor == NULL) {
return -1;
}
diff --git a/Python/optimizer_analysis.c b/Python/optimizer_analysis.c
index 95924a5..6f553f8 100644
--- a/Python/optimizer_analysis.c
+++ b/Python/optimizer_analysis.c
@@ -387,9 +387,9 @@ optimize_uops(
ctx->curr_frame_depth++;
ctx->frame = frame;
- for (_PyUOpInstruction *this_instr = trace;
- this_instr < trace + trace_len && !op_is_end(this_instr->opcode);
- this_instr++) {
+ _PyUOpInstruction *this_instr = NULL;
+ for (int i = 0; i < trace_len; i++) {
+ this_instr = &trace[i];
int oparg = this_instr->oparg;
opcode = this_instr->opcode;
@@ -416,9 +416,8 @@ optimize_uops(
ctx->frame->stack_pointer = stack_pointer;
assert(STACK_LEVEL() >= 0);
}
-
_Py_uop_abstractcontext_fini(ctx);
- return 1;
+ return trace_len;
out_of_space:
DPRINTF(3, "\n");
@@ -447,11 +446,11 @@ done:
/* Cannot optimize further, but there would be no benefit
* in retrying later */
_Py_uop_abstractcontext_fini(ctx);
- return 1;
+ return trace_len;
}
-static void
+static int
remove_unneeded_uops(_PyUOpInstruction *buffer, int buffer_size)
{
/* Remove _SET_IP and _CHECK_VALIDITY where possible.
@@ -506,7 +505,7 @@ remove_unneeded_uops(_PyUOpInstruction *buffer, int buffer_size)
}
case _JUMP_TO_TOP:
case _EXIT_TRACE:
- return;
+ return pc + 1;
default:
{
bool needs_ip = false;
@@ -530,6 +529,8 @@ remove_unneeded_uops(_PyUOpInstruction *buffer, int buffer_size)
}
}
}
+ Py_FatalError("No terminating instruction");
+ Py_UNREACHABLE();
}
static void
@@ -582,43 +583,36 @@ peephole_opt(_PyInterpreterFrame *frame, _PyUOpInstruction *buffer, int buffer_s
// 0 - failure, no error raised, just fall back to Tier 1
// -1 - failure, and raise error
-// 1 - optimizer success
+// > 0 - length of optimized trace
int
_Py_uop_analyze_and_optimize(
_PyInterpreterFrame *frame,
_PyUOpInstruction *buffer,
- int buffer_size,
+ int length,
int curr_stacklen,
_PyBloomFilter *dependencies
)
{
OPT_STAT_INC(optimizer_attempts);
- int err = remove_globals(frame, buffer, buffer_size, dependencies);
- if (err == 0) {
- goto not_ready;
- }
- if (err < 0) {
- goto error;
+ int err = remove_globals(frame, buffer, length, dependencies);
+ if (err <= 0) {
+ return err;
}
- peephole_opt(frame, buffer, buffer_size);
+ peephole_opt(frame, buffer, length);
- err = optimize_uops(
+ length = optimize_uops(
_PyFrame_GetCode(frame), buffer,
- buffer_size, curr_stacklen, dependencies);
+ length, curr_stacklen, dependencies);
- if (err == 0) {
- goto not_ready;
+ if (length <= 0) {
+ return length;
}
- assert(err == 1);
- remove_unneeded_uops(buffer, buffer_size);
+ length = remove_unneeded_uops(buffer, length);
+ assert(length > 0);
OPT_STAT_INC(optimizer_successes);
- return 1;
-not_ready:
- return 0;
-error:
- return -1;
+ return length;
}
diff --git a/Python/optimizer_cases.c.h b/Python/optimizer_cases.c.h
index 6aeea51..df73cc0 100644
--- a/Python/optimizer_cases.c.h
+++ b/Python/optimizer_cases.c.h
@@ -769,14 +769,7 @@
break;
}
- case _LOAD_NAME: {
- _Py_UopsSymbol *v;
- v = sym_new_not_null(ctx);
- if (v == NULL) goto out_of_space;
- stack_pointer[0] = v;
- stack_pointer += 1;
- break;
- }
+ /* _LOAD_NAME is not a viable micro-op for tier 2 */
case _LOAD_GLOBAL: {
_Py_UopsSymbol *res;
@@ -900,14 +893,7 @@
break;
}
- case _BUILD_SET: {
- _Py_UopsSymbol *set;
- set = sym_new_not_null(ctx);
- if (set == NULL) goto out_of_space;
- stack_pointer[-oparg] = set;
- stack_pointer += 1 - oparg;
- break;
- }
+ /* _BUILD_SET is not a viable micro-op for tier 2 */
case _BUILD_MAP: {
_Py_UopsSymbol *map;
@@ -1408,31 +1394,9 @@
/* _FOR_ITER_GEN is not a viable micro-op for tier 2 */
- case _BEFORE_ASYNC_WITH: {
- _Py_UopsSymbol *exit;
- _Py_UopsSymbol *res;
- exit = sym_new_not_null(ctx);
- if (exit == NULL) goto out_of_space;
- res = sym_new_not_null(ctx);
- if (res == NULL) goto out_of_space;
- stack_pointer[-1] = exit;
- stack_pointer[0] = res;
- stack_pointer += 1;
- break;
- }
+ /* _BEFORE_ASYNC_WITH is not a viable micro-op for tier 2 */
- case _BEFORE_WITH: {
- _Py_UopsSymbol *exit;
- _Py_UopsSymbol *res;
- exit = sym_new_not_null(ctx);
- if (exit == NULL) goto out_of_space;
- res = sym_new_not_null(ctx);
- if (res == NULL) goto out_of_space;
- stack_pointer[-1] = exit;
- stack_pointer[0] = res;
- stack_pointer += 1;
- break;
- }
+ /* _BEFORE_WITH is not a viable micro-op for tier 2 */
case _WITH_EXCEPT_START: {
_Py_UopsSymbol *res;
@@ -2029,3 +1993,16 @@
break;
}
+ case _DEOPT: {
+ break;
+ }
+
+ case _SIDE_EXIT: {
+ break;
+ }
+
+ case _ERROR_POP_N: {
+ stack_pointer += -oparg;
+ break;
+ }
+