summaryrefslogtreecommitdiffstats
path: root/Python
diff options
context:
space:
mode:
authorDiego Russo <diego.russo@arm.com>2024-11-12 01:20:10 (GMT)
committerGitHub <noreply@github.com>2024-11-12 01:20:10 (GMT)
commitc45be8aa71ad886e12e8c897274498e4d828c9a5 (patch)
tree16ee725ebb57a2e59de0401fb6fcab947c6cfb8a /Python
parent494360afd00dc8f6b549f160525c3e86ec14905d (diff)
downloadcpython-c45be8aa71ad886e12e8c897274498e4d828c9a5.zip
cpython-c45be8aa71ad886e12e8c897274498e4d828c9a5.tar.gz
cpython-c45be8aa71ad886e12e8c897274498e4d828c9a5.tar.bz2
GH-126195: Use M1 JIT memory protection APIs (GH-126196)
Diffstat (limited to 'Python')
-rw-r--r--Python/jit.c18
1 files changed, 16 insertions, 2 deletions
diff --git a/Python/jit.c b/Python/jit.c
index 90f693d..7dd0da7 100644
--- a/Python/jit.c
+++ b/Python/jit.c
@@ -58,7 +58,12 @@ jit_alloc(size_t size)
int failed = memory == NULL;
#else
int flags = MAP_ANONYMOUS | MAP_PRIVATE;
- unsigned char *memory = mmap(NULL, size, PROT_READ | PROT_WRITE, flags, -1, 0);
+ int prot = PROT_READ | PROT_WRITE;
+# ifdef MAP_JIT
+ flags |= MAP_JIT;
+ prot |= PROT_EXEC;
+# endif
+ unsigned char *memory = mmap(NULL, size, prot, flags, -1, 0);
int failed = memory == MAP_FAILED;
#endif
if (failed) {
@@ -102,8 +107,11 @@ mark_executable(unsigned char *memory, size_t size)
int old;
int failed = !VirtualProtect(memory, size, PAGE_EXECUTE_READ, &old);
#else
+ int failed = 0;
__builtin___clear_cache((char *)memory, (char *)memory + size);
- int failed = mprotect(memory, size, PROT_EXEC | PROT_READ);
+#ifndef MAP_JIT
+ failed = mprotect(memory, size, PROT_EXEC | PROT_READ);
+#endif
#endif
if (failed) {
jit_error("unable to protect executable memory");
@@ -499,6 +507,9 @@ _PyJIT_Compile(_PyExecutorObject *executor, const _PyUOpInstruction trace[], siz
if (memory == NULL) {
return -1;
}
+#ifdef MAP_JIT
+ pthread_jit_write_protect_np(0);
+#endif
// Update the offsets of each instruction:
for (size_t i = 0; i < length; i++) {
state.instruction_starts[i] += (uintptr_t)memory;
@@ -529,6 +540,9 @@ _PyJIT_Compile(_PyExecutorObject *executor, const _PyUOpInstruction trace[], siz
data += group->data_size;
assert(code == memory + code_size);
assert(data == memory + code_size + data_size);
+#ifdef MAP_JIT
+ pthread_jit_write_protect_np(1);
+#endif
if (mark_executable(memory, total_size)) {
jit_free(memory, total_size);
return -1;