diff options
| author | Alex Waygood <Alex.Waygood@Gmail.com> | 2023-08-04 13:28:13 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-08-04 13:28:13 (GMT) |
| commit | 7eba274fb3fb959261c6b8fdf0cee10c82004f0e (patch) | |
| tree | 24bc2073bf7d2cfc1910dd71ef8ab400aacd36be /Tools/clinic | |
| parent | ac7605ed197e8b2336d44c8ac8aeae6faa90a768 (diff) | |
| download | cpython-7eba274fb3fb959261c6b8fdf0cee10c82004f0e.zip cpython-7eba274fb3fb959261c6b8fdf0cee10c82004f0e.tar.gz cpython-7eba274fb3fb959261c6b8fdf0cee10c82004f0e.tar.bz2 | |
gh-104146: Argument clinic: Remove dead code flagged by mypy's `truthy-bool` check (#107627)
Diffstat (limited to 'Tools/clinic')
| -rwxr-xr-x | Tools/clinic/clinic.py | 8 | ||||
| -rw-r--r-- | Tools/clinic/mypy.ini | 2 |
2 files changed, 3 insertions, 7 deletions
diff --git a/Tools/clinic/clinic.py b/Tools/clinic/clinic.py index ee5e0ef..6c5a2c7 100755 --- a/Tools/clinic/clinic.py +++ b/Tools/clinic/clinic.py @@ -886,9 +886,7 @@ class CLanguage(Language): converters = [p.converter for p in parameters] has_option_groups = parameters and (parameters[0].group or parameters[-1].group) - default_return_converter = (not f.return_converter or - f.return_converter.type == 'PyObject *') - + default_return_converter = f.return_converter.type == 'PyObject *' new_or_init = f.kind.new_or_init vararg: int | str = NO_VARARG @@ -4428,7 +4426,7 @@ class DSLParser: keyword_only: bool positional_only: bool group: int - parameter_state: int + parameter_state: ParamState seen_positional_with_default: bool indent: IndentStack kind: FunctionKind @@ -4790,8 +4788,6 @@ class DSLParser: if not return_converter: return_converter = CReturnConverter() - if not module: - fail("Undefined module used in declaration of {full_name.strip()!r}.") self.function = Function(name=function_name, full_name=full_name, module=module, cls=cls, c_basename=c_basename, return_converter=return_converter, kind=self.kind, coexist=self.coexist) self.block.signatures.append(self.function) diff --git a/Tools/clinic/mypy.ini b/Tools/clinic/mypy.ini index 4cfc05b..b1fdad6 100644 --- a/Tools/clinic/mypy.ini +++ b/Tools/clinic/mypy.ini @@ -8,5 +8,5 @@ python_version = 3.10 # and be strict! strict = True strict_concatenate = True -enable_error_code = ignore-without-code,redundant-expr +enable_error_code = ignore-without-code,redundant-expr,truthy-bool warn_unreachable = True |