summaryrefslogtreecommitdiffstats
path: root/configure
diff options
context:
space:
mode:
authorPaul Ganssle <paul@ganssle.io>2021-01-12 18:17:52 (GMT)
committerGitHub <noreply@github.com>2021-01-12 18:17:52 (GMT)
commit0f66498fd8ee8644be6df963b86a1523f6069ddd (patch)
treeeabd48e262e7ffd165e7e49aa3e27c233b988594 /configure
parent4db8988420e0a122d617df741381b0c385af032c (diff)
downloadcpython-0f66498fd8ee8644be6df963b86a1523f6069ddd.zip
cpython-0f66498fd8ee8644be6df963b86a1523f6069ddd.tar.gz
cpython-0f66498fd8ee8644be6df963b86a1523f6069ddd.tar.bz2
bpo-42874: Remove grep -qE options for Solaris 10 compatibility (GH-24200)
According to [bpo-42874](), some versions of grep do not support the `-q` and `-E` options. Although both options are used elsewhere in the configure script, this particular bit of validation can be achieved without them, so there's no real harm in using a grep call with no flags. Would be good to get some people taking advantage of the `--with-tzpath` arguments in the wild to try this out.. Local testing seems to indicate that this does the same thing, but I don't know that we have any buildbots using this option. Maybe @pablogsal? [bpo-42874]():
Diffstat (limited to 'configure')
-rwxr-xr-xconfigure2
1 files changed, 1 insertions, 1 deletions
diff --git a/configure b/configure
index 5691c27..1d81c00 100755
--- a/configure
+++ b/configure
@@ -10252,7 +10252,7 @@ validate_tzpath() {
fi
# Bad paths are those that don't start with /
- if ( echo $1 | grep -qE '(^|:)([^/]|$)' ); then
+ if ( echo $1 | grep '\(^\|:\)\([^/]\|$\)' > /dev/null); then
as_fn_error $? "--with-tzpath must contain only absolute paths, not $1" "$LINENO" 5
return 1;
fi