diff options
| -rw-r--r-- | Lib/test/test_urllib2.py | 12 | ||||
| -rw-r--r-- | Lib/urllib/request.py | 3 | ||||
| -rw-r--r-- | Misc/NEWS | 3 |
3 files changed, 17 insertions, 1 deletions
diff --git a/Lib/test/test_urllib2.py b/Lib/test/test_urllib2.py index a5281d8..008c751 100644 --- a/Lib/test/test_urllib2.py +++ b/Lib/test/test_urllib2.py @@ -13,7 +13,8 @@ import urllib.request # proxy config data structure but is testable on all platforms. from urllib.request import (Request, OpenerDirector, HTTPBasicAuthHandler, HTTPPasswordMgrWithPriorAuth, _parse_proxy, - _proxy_bypass_macosx_sysconf) + _proxy_bypass_macosx_sysconf, + AbstractDigestAuthHandler) from urllib.parse import urlparse import urllib.error import http.client @@ -1680,6 +1681,15 @@ class MiscTests(unittest.TestCase): self.assertRaises(ValueError, _parse_proxy, 'file:/ftp.example.com'), + def test_unsupported_algorithm(self): + handler = AbstractDigestAuthHandler() + with self.assertRaises(ValueError) as exc: + handler.get_algorithm_impls('invalid') + self.assertEqual( + str(exc.exception), + "Unsupported digest authentication algorithm 'invalid'" + ) + class RequestTests(unittest.TestCase): class PutRequest(Request): diff --git a/Lib/urllib/request.py b/Lib/urllib/request.py index 4c16518..fc8ef7f 100644 --- a/Lib/urllib/request.py +++ b/Lib/urllib/request.py @@ -1111,6 +1111,9 @@ class AbstractDigestAuthHandler: elif algorithm == 'SHA': H = lambda x: hashlib.sha1(x.encode("ascii")).hexdigest() # XXX MD5-sess + else: + raise ValueError("Unsupported digest authentication " + "algorithm %r" % algorithm) KD = lambda s, d: H("%s:%s" % (s, d)) return H, KD @@ -91,6 +91,9 @@ Core and Builtins Library ------- +- Issue #2202: Fix UnboundLocalError in + AbstractDigestAuthHandler.get_algorithm_impls. Initial patch by Mathieu Dupuy. + - Issue #25718: Fixed pickling and copying the accumulate() iterator with total is None. |