summaryrefslogtreecommitdiffstats
path: root/Lib
diff options
context:
space:
mode:
Diffstat (limited to 'Lib')
-rw-r--r--Lib/test/test_ttk/test_widgets.py22
-rw-r--r--Lib/tkinter/__init__.py7
2 files changed, 27 insertions, 2 deletions
diff --git a/Lib/test/test_ttk/test_widgets.py b/Lib/test/test_ttk/test_widgets.py
index fd1a748..e3e440c 100644
--- a/Lib/test/test_ttk/test_widgets.py
+++ b/Lib/test/test_ttk/test_widgets.py
@@ -285,9 +285,29 @@ class CheckbuttonTest(AbstractLabelTest, unittest.TestCase):
b.pack()
buttons.append(b)
variables = [str(b['variable']) for b in buttons]
- print(variables)
self.assertEqual(len(set(variables)), 4, variables)
+ def test_unique_variables2(self):
+ buttons = []
+ f = ttk.Frame(self.root)
+ f.pack()
+ f = ttk.Frame(self.root)
+ f.pack()
+ for j in 'AB':
+ b = tkinter.Checkbutton(f, text=j)
+ b.pack()
+ buttons.append(b)
+ # Should be larger than the number of all previously created
+ # tkinter.Checkbutton widgets:
+ for j in range(100):
+ b = ttk.Checkbutton(f, text=str(j))
+ b.pack()
+ buttons.append(b)
+ names = [str(b) for b in buttons]
+ self.assertEqual(len(set(names)), len(buttons), names)
+ variables = [str(b['variable']) for b in buttons]
+ self.assertEqual(len(set(variables)), len(buttons), variables)
+
@add_standard_options(IntegerSizeTests, StandardTtkOptionsTests)
class EntryTest(AbstractWidgetTest, unittest.TestCase):
diff --git a/Lib/tkinter/__init__.py b/Lib/tkinter/__init__.py
index 8b8fdfe..43b0cbe 100644
--- a/Lib/tkinter/__init__.py
+++ b/Lib/tkinter/__init__.py
@@ -3074,11 +3074,16 @@ class Checkbutton(Widget):
Widget.__init__(self, master, 'checkbutton', cnf, kw)
def _setup(self, master, cnf):
+ # Because Checkbutton defaults to a variable with the same name as
+ # the widget, Checkbutton default names must be globally unique,
+ # not just unique within the parent widget.
if not cnf.get('name'):
global _checkbutton_count
name = self.__class__.__name__.lower()
_checkbutton_count += 1
- cnf['name'] = f'!{name}{_checkbutton_count}'
+ # To avoid collisions with ttk.Checkbutton, use the different
+ # name template.
+ cnf['name'] = f'!{name}-{_checkbutton_count}'
super()._setup(master, cnf)
def deselect(self):