summaryrefslogtreecommitdiffstats
path: root/Objects/exceptions.c
diff options
context:
space:
mode:
Diffstat (limited to 'Objects/exceptions.c')
-rw-r--r--Objects/exceptions.c31
1 files changed, 15 insertions, 16 deletions
diff --git a/Objects/exceptions.c b/Objects/exceptions.c
index 7bec739..f376ff2 100644
--- a/Objects/exceptions.c
+++ b/Objects/exceptions.c
@@ -207,22 +207,21 @@ BaseException_add_note(PyObject *self, PyObject *note)
return NULL;
}
- if (!PyObject_HasAttr(self, &_Py_ID(__notes__))) {
- PyObject *new_notes = PyList_New(0);
- if (new_notes == NULL) {
+ PyObject *notes;
+ if (_PyObject_LookupAttr(self, &_Py_ID(__notes__), &notes) < 0) {
+ return NULL;
+ }
+ if (notes == NULL) {
+ notes = PyList_New(0);
+ if (notes == NULL) {
return NULL;
}
- if (PyObject_SetAttr(self, &_Py_ID(__notes__), new_notes) < 0) {
- Py_DECREF(new_notes);
+ if (PyObject_SetAttr(self, &_Py_ID(__notes__), notes) < 0) {
+ Py_DECREF(notes);
return NULL;
}
- Py_DECREF(new_notes);
}
- PyObject *notes = PyObject_GetAttr(self, &_Py_ID(__notes__));
- if (notes == NULL) {
- return NULL;
- }
- if (!PyList_Check(notes)) {
+ else if (!PyList_Check(notes)) {
Py_DECREF(notes);
PyErr_SetString(PyExc_TypeError, "Cannot add note: __notes__ is not a list");
return NULL;
@@ -941,11 +940,11 @@ exceptiongroup_subset(
PyException_SetContext(eg, PyException_GetContext(orig));
PyException_SetCause(eg, PyException_GetCause(orig));
- if (PyObject_HasAttr(orig, &_Py_ID(__notes__))) {
- PyObject *notes = PyObject_GetAttr(orig, &_Py_ID(__notes__));
- if (notes == NULL) {
- goto error;
- }
+ PyObject *notes;
+ if (_PyObject_LookupAttr(orig, &_Py_ID(__notes__), &notes) < 0) {
+ goto error;
+ }
+ if (notes) {
if (PySequence_Check(notes)) {
/* Make a copy so the parts have independent notes lists. */
PyObject *notes_copy = PySequence_List(notes);