summaryrefslogtreecommitdiffstats
path: root/googlemock
diff options
context:
space:
mode:
authorAbseil Team <absl-team@google.com>2020-10-27 20:56:33 (GMT)
committervslashg <gfalcon@google.com>2020-10-30 18:10:41 (GMT)
commit2828773179fa425ee406df61890a150577178ea2 (patch)
tree216ce1e8cf9fd2db7ca88bc6c011ca1cbda6bbd6 /googlemock
parent3005672db1d05f2378f642b61faa96f85498befe (diff)
downloadgoogletest-2828773179fa425ee406df61890a150577178ea2.zip
googletest-2828773179fa425ee406df61890a150577178ea2.tar.gz
googletest-2828773179fa425ee406df61890a150577178ea2.tar.bz2
Googletest export
Remove obsolete comment about non-const references. They used to be banned by the C++ style guide, but positions shifted, and this comment is no longer up to date. There's another reference (heh) on lines 816-819 to how gmock is a "general framework", with the possible implication that support for non-const references was weird in some way and only there to be "general", but I left it alone because I don't really feel I understand what it's saying. PiperOrigin-RevId: 339323428
Diffstat (limited to 'googlemock')
-rw-r--r--googlemock/include/gmock/gmock-matchers.h3
1 files changed, 0 insertions, 3 deletions
diff --git a/googlemock/include/gmock/gmock-matchers.h b/googlemock/include/gmock/gmock-matchers.h
index 13a4671..7db65a4 100644
--- a/googlemock/include/gmock/gmock-matchers.h
+++ b/googlemock/include/gmock/gmock-matchers.h
@@ -1717,9 +1717,6 @@ class FloatingEqMatcher {
// The following 3 type conversion operators allow FloatEq(expected) and
// NanSensitiveFloatEq(expected) to be used as a Matcher<float>, a
// Matcher<const float&>, or a Matcher<float&>, but nothing else.
- // (While Google's C++ coding style doesn't allow arguments passed
- // by non-const reference, we may see them in code not conforming to
- // the style. Therefore Google Mock needs to support them.)
operator Matcher<FloatType>() const {
return MakeMatcher(
new Impl<FloatType>(expected_, nan_eq_nan_, max_abs_error_));