summaryrefslogtreecommitdiffstats
path: root/googletest/src/gtest-typed-test.cc
diff options
context:
space:
mode:
authorShahbaz Youssefi <syoussefi@google.com>2019-12-10 15:01:25 (GMT)
committerShahbaz Youssefi <syoussefi@chromium.org>2019-12-16 18:01:59 (GMT)
commit1800a38fb7d8d4f923fc450875afa3bc16f01151 (patch)
tree944119bf036d3169cc2cbfa0c01930d0ee75f362 /googletest/src/gtest-typed-test.cc
parent4b7809c2f5236b16a2e3b45e2b5ade48fb6a3c0c (diff)
downloadgoogletest-1800a38fb7d8d4f923fc450875afa3bc16f01151.zip
googletest-1800a38fb7d8d4f923fc450875afa3bc16f01151.tar.gz
googletest-1800a38fb7d8d4f923fc450875afa3bc16f01151.tar.bz2
Revert "Googletest export": disallow empty prefixrefs/pull/2624/head
This reverts commit 20b5b8ecc7a81d23b4716e22a2b35fd53379c8c6. Reason for revert: Breaks existing applications, such as ANGLE (angleproject.org), requires adding an extra prefix that needs to be typed for no reason (when testing from command line) and increases the logs' sizes by a non-trivial amount due to the very large number of tests ANGLE runs. Original commit message: Add a compile time check to ensure that the parameters to TEST_P and INSTANTIATE_TEST_SUITE_P are not empty. Some compilers already fail in that case and, even where it works, it's likely to result in technically invalid code by virtue of creating reserved identifiers: https://en.cppreference.com/w/cpp/language/identifiers First, every project is perfectly capable of adding a prefix if they want to support such a compiler. This change penalizes every project. Second, using a prefix such as `_p` also results in reserved identifiers, so this change is not really solving the problem. For that matter, instead of generating `gtest_##prefix##...`, you can generate `gtest_x##prefix##...` to correctly fix the issue, including when empty prefixes are used.
Diffstat (limited to 'googletest/src/gtest-typed-test.cc')
0 files changed, 0 insertions, 0 deletions