diff options
author | vladlosev <vladlosev@861a406c-534a-0410-8894-cb66d6ee9925> | 2011-02-02 10:07:04 (GMT) |
---|---|---|
committer | vladlosev <vladlosev@861a406c-534a-0410-8894-cb66d6ee9925> | 2011-02-02 10:07:04 (GMT) |
commit | 9d7455f9844e293dff8b7902f0c2553094f2f976 (patch) | |
tree | dfb2f65d0932332b217c19dd22ed62d18e70e2c9 /include | |
parent | 40d0ba7a62a8bc749fbaf0747621b0aa10ddf1b9 (diff) | |
download | googletest-9d7455f9844e293dff8b7902f0c2553094f2f976.zip googletest-9d7455f9844e293dff8b7902f0c2553094f2f976.tar.gz googletest-9d7455f9844e293dff8b7902f0c2553094f2f976.tar.bz2 |
Adds null check for file locations in XML output printer.
Diffstat (limited to 'include')
-rw-r--r-- | include/gtest/internal/gtest-internal.h | 14 | ||||
-rw-r--r-- | include/gtest/internal/gtest-port.h | 10 |
2 files changed, 10 insertions, 14 deletions
diff --git a/include/gtest/internal/gtest-internal.h b/include/gtest/internal/gtest-internal.h index 23fcef7..9f890fa 100644 --- a/include/gtest/internal/gtest-internal.h +++ b/include/gtest/internal/gtest-internal.h @@ -536,20 +536,6 @@ GTEST_API_ AssertionResult IsHRESULTFailure(const char* expr, #endif // GTEST_OS_WINDOWS -// Formats a source file path and a line number as they would appear -// in a compiler error message. -inline String FormatFileLocation(const char* file, int line) { - const char* const file_name = file == NULL ? "unknown file" : file; - if (line < 0) { - return String::Format("%s:", file_name); - } -#ifdef _MSC_VER - return String::Format("%s(%d):", file_name, line); -#else - return String::Format("%s:%d:", file_name, line); -#endif // _MSC_VER -} - // Types of SetUpTestCase() and TearDownTestCase() functions. typedef void (*SetUpTestCaseFunc)(); typedef void (*TearDownTestCaseFunc)(); diff --git a/include/gtest/internal/gtest-port.h b/include/gtest/internal/gtest-port.h index be2297e..228c468 100644 --- a/include/gtest/internal/gtest-port.h +++ b/include/gtest/internal/gtest-port.h @@ -848,6 +848,16 @@ class GTEST_API_ RE { GTEST_DISALLOW_ASSIGN_(RE); }; +// Formats a source file path and a line number as they would appear +// in an error message from the compiler used to compile this code. +GTEST_API_ ::std::string FormatFileLocation(const char* file, int line); + +// Formats a file location for compiler-independent XML output. +// Although this function is not platform dependent, we put it next to +// FormatFileLocation in order to contrast the two functions. +GTEST_API_ ::std::string FormatCompilerIndependentFileLocation(const char* file, + int line); + // Defines logging utilities: // GTEST_LOG_(severity) - logs messages at the specified severity level. The // message itself is streamed into the macro. |