summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJason Evans <jasone@canonware.com>2016-04-17 19:33:39 (GMT)
committerJason Evans <jasone@canonware.com>2016-04-17 20:44:58 (GMT)
commitd9394d0ca870fc20b48ee7c57c69d48effe51041 (patch)
treecd5c34ec5cd5fbf58e0875873536d9356f2ec19d
parent22884243250a0f7d412ca745fbf7231d69abe771 (diff)
downloadjemalloc-d9394d0ca870fc20b48ee7c57c69d48effe51041.zip
jemalloc-d9394d0ca870fc20b48ee7c57c69d48effe51041.tar.gz
jemalloc-d9394d0ca870fc20b48ee7c57c69d48effe51041.tar.bz2
Convert base_mtx locking protocol comments to assertions.
-rw-r--r--src/base.c22
1 files changed, 12 insertions, 10 deletions
diff --git a/src/base.c b/src/base.c
index 87b376b..901553a 100644
--- a/src/base.c
+++ b/src/base.c
@@ -13,12 +13,13 @@ static size_t base_mapped;
/******************************************************************************/
-/* base_mtx must be held. */
static extent_node_t *
-base_node_try_alloc(void)
+base_node_try_alloc(tsd_t *tsd)
{
extent_node_t *node;
+ malloc_mutex_assert_owner(tsd, &base_mtx);
+
if (base_nodes == NULL)
return (NULL);
node = base_nodes;
@@ -27,33 +28,34 @@ base_node_try_alloc(void)
return (node);
}
-/* base_mtx must be held. */
static void
-base_node_dalloc(extent_node_t *node)
+base_node_dalloc(tsd_t *tsd, extent_node_t *node)
{
+ malloc_mutex_assert_owner(tsd, &base_mtx);
+
JEMALLOC_VALGRIND_MAKE_MEM_UNDEFINED(node, sizeof(extent_node_t));
*(extent_node_t **)node = base_nodes;
base_nodes = node;
}
-/* base_mtx must be held. */
static extent_node_t *
-base_chunk_alloc(size_t minsize)
+base_chunk_alloc(tsd_t *tsd, size_t minsize)
{
extent_node_t *node;
size_t csize, nsize;
void *addr;
+ malloc_mutex_assert_owner(tsd, &base_mtx);
assert(minsize != 0);
- node = base_node_try_alloc();
+ node = base_node_try_alloc(tsd);
/* Allocate enough space to also carve a node out if necessary. */
nsize = (node == NULL) ? CACHELINE_CEILING(sizeof(extent_node_t)) : 0;
csize = CHUNK_CEILING(minsize + nsize);
addr = chunk_alloc_base(csize);
if (addr == NULL) {
if (node != NULL)
- base_node_dalloc(node);
+ base_node_dalloc(tsd, node);
return (NULL);
}
base_mapped += csize;
@@ -98,7 +100,7 @@ base_alloc(tsd_t *tsd, size_t size)
extent_tree_szad_remove(&base_avail_szad, node);
} else {
/* Try to allocate more space. */
- node = base_chunk_alloc(csize);
+ node = base_chunk_alloc(tsd, csize);
}
if (node == NULL) {
ret = NULL;
@@ -111,7 +113,7 @@ base_alloc(tsd_t *tsd, size_t size)
extent_node_size_set(node, extent_node_size_get(node) - csize);
extent_tree_szad_insert(&base_avail_szad, node);
} else
- base_node_dalloc(node);
+ base_node_dalloc(tsd, node);
if (config_stats) {
base_allocated += csize;
/*