summaryrefslogtreecommitdiffstats
path: root/jemalloc/src
Commit message (Collapse)AuthorAgeFilesLines
* Move repo contents in jemalloc/ to top level.Jason Evans2011-04-0121-11560/+0
|
* Fix a build error for --disable-tcache.Jason Evans2011-03-301-0/+2
| | | | | Add a missing #ifdef to conditionally exclude code that is relevant only to the tcache feature.
* Revert "Add support for libunwind backtrace caching."Jason Evans2011-03-231-79/+15
| | | | | | | This reverts commit adc675c8ef55b59bb2facf795a3c26411cfbf3ed. The original commit added support for a non-standard libunwind API, so it was not of general utility.
* Fix an assertion in arena_purge().Jason Evans2011-03-241-3/+6
| | | | | arena_purge() may be called even when there are no dirty pages, so loosen an assertion accordingly.
* Add support for libunwind backtrace caching.je@facebook.com2011-03-241-15/+79
| | | | Use libunwind's unw_tdep_trace() if it is available.
* Fix error detection for ipalloc() when profiling.Jason Evans2011-03-233-41/+67
| | | | | | | | | sa2u() returns 0 on overflow, but the profiling code was blindly calling sa2u() and allowing the error to silently propagate, ultimately ending in a later assertion failure. Refactor all ipalloc() callers to call sa2u(), check for overflow before calling ipalloc(), and pass usize rather than size. This allows ipalloc() to avoid calling sa2u() in the common case.
* Fix rallocm() rsize bug.Jason Evans2011-03-231-0/+2
| | | | Add code to set *rsize even when profiling is enabled.
* Fix bootstrapping order bug.Jason Evans2011-03-231-5/+5
| | | | | Initialize arenas_tsd earlier, so that the non-TLS case works when profiling is enabled.
* Avoid overflow in arena_run_regind().Jason Evans2011-03-221-1/+11
| | | | | | | | | | | Fix a regression due to: Remove an arena_bin_run_size_calc() constraint. 2a6f2af6e446a98a635caadd281a23ca09a491cb The removed constraint required that small run headers fit in one page, which indirectly limited runs such that they would not cause overflow in arena_run_regind(). Add an explicit constraint to arena_bin_run_size_calc() based on the largest number of regions that arena_run_regind() can handle (2^11 as currently configured).
* Dynamically adjust tcache fill count.Jason Evans2011-03-212-6/+6
| | | | | | | | Dynamically adjust tcache fill count (number of objects allocated per tcache refill) such that if GC has to flush inactive objects, the fill count gradually decreases. Conversely, if refills occur while the fill count is depressed, the fill count gradually increases back to its maximum value.
* Use OSSpinLock*() for locking on OS X.Jason Evans2011-03-192-1/+13
| | | | | | pthread_mutex_lock() can call malloc() on OS X (!!!), which causes deadlock. Work around this by using spinlocks that are built of more primitive stuff.
* Add atomic.[ch].Jason Evans2011-03-191-0/+2
| | | | Add atomic.[ch], which should have been part of the previous commit.
* Add the "stats.cactive" mallctl.Jason Evans2011-03-199-8/+57
| | | | | | Add the "stats.cactive" mallctl, which can be used to efficiently and repeatedly query approximately how much active memory the application is utilizing.
* Improve thread-->arena assignment.Jason Evans2011-03-184-13/+76
| | | | | | | | Rather than blindly assigning threads to arenas in round-robin fashion, choose the lowest-numbered arena that currently has the smallest number of threads assigned to it. Add the "stats.arenas.<i>.nthreads" mallctl.
* Reverse tcache fill order.Jason Evans2011-03-181-1/+2
| | | | | | Refill the thread cache such that low regions get used first. This fixes a regression due to the recent transition to bitmap-based region management.
* Use bitmaps to track small regions.Jason Evans2011-03-175-101/+242
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous free list implementation, which embedded singly linked lists in available regions, had the unfortunate side effect of causing many cache misses during thread cache fills. Fix this in two places: - arena_run_t: Use a new bitmap implementation to track which regions are available. Furthermore, revert to preferring the lowest available region (as jemalloc did with its old bitmap-based approach). - tcache_t: Move read-only tcache_bin_t metadata into tcache_bin_info_t, and add a contiguous array of pointers to tcache_t in order to track cached objects. This substantially increases the size of tcache_t, but results in much higher data locality for common tcache operations. As a side benefit, it is again possible to efficiently flush the least recently used cached objects, so this change changes flushing from MRU to LRU. The new bitmap implementation uses a multi-level summary approach to make finding the lowest available region very fast. In practice, bitmaps only have one or two levels, though the implementation is general enough to handle extremely large bitmaps, mainly so that large page sizes can still be entertained. Fix tcache_bin_flush_large() to always flush statistics, in the same way that tcache_bin_flush_small() was recently fixed. Use JEMALLOC_DEBUG rather than NDEBUG. Add dassert(), and use it for debug-only asserts.
* Improve backtracing-related configuration.Jason Evans2011-03-161-38/+40
| | | | | | | | | | Clean up configuration for backtracing when profiling is enabled, and document the configuration logic in INSTALL. Disable libgcc-based backtracing except on x64 (where it is known to work). Add the --disable-prof-gcc option.
* Add missing error checks.Jason Evans2011-03-152-2/+6
| | | | | Add missing error checks for pthread_mutex_init() calls. In practice, mutex initialization never fails, so this is merely good hygiene.
* Create arena_bin_info_t.Jason Evans2011-03-153-184/+254
| | | | | Move read-only fields from arena_bin_t into arena_bin_info_t, primarily in order to avoid false cacheline sharing.
* Reduce size of small_size2bin lookup table.Jason Evans2011-03-151-38/+42
| | | | | | | Convert all direct small_size2bin[...] accesses to SMALL_SIZE2BIN(...) macro calls, and use a couple of cheap math operations to allow compacting the table by 4X or 8X, on 32- and 64-bit systems, respectively.
* Fix a thread cache stats merging bug.Jason Evans2011-03-141-0/+19
| | | | | | | | | | When a thread cache flushes objects to their arenas due to an abundance of cached objects, it merges the allocation request count for the associated size class, and increments a flush counter. If none of the flushed objects came from the thread's assigned arena, then the merging wouldn't happen (though the counter would typically eventually be merged), nor would the flush counter be incremented (a hard bug). Fix this via extra conditional code just after the flush loop.
* Fix a "thread.arena" mallctl bug.Jason Evans2011-03-141-2/+2
| | | | Fix a variable reversal bug in mallctl("thread.arena", ...).
* Fix style nits.Jason Evans2011-02-141-2/+4
|
* Fix "thread.{de,}allocatedp" mallctl.Jason Evans2011-02-142-2/+24
| | | | | | | | | For the non-TLS case (as on OS X), if the "thread.{de,}allocatedp" mallctl was called before any allocation occurred for that thread, the TSD was still NULL, thus putting the application at risk of dereferencing NULL. Fix this by refactoring the initialization code, and making it part of the conditional logic for all per thread allocation counter accesses.
* Fix an alignment-related bug in huge_ralloc().Jason Evans2011-02-011-3/+3
| | | | | | | Fix huge_ralloc() to call huge_palloc() only if alignment requires it. This bug caused under-sized allocation for aligned huge reallocation (via rallocm()) if the requested alignment was less than the chunk size (4 MiB by default).
* Fix assertion typos.Jason Evans2011-01-151-7/+7
| | | | s/=/==/ in several assertions, as well as fixing spelling errors.
* Fix a heap dumping deadlock.Jason Evans2011-01-151-8/+22
| | | | | | | | | | | Restructure the ctx initialization code such that the ctx isn't locked across portions of the initialization code where allocation could occur. Instead artificially inflate the cnt_merged.curobjs field, just as is done elsewhere to avoid similar races to the one that would otherwise be created by the reduction in locking scope. This bug affected interval- and growth-triggered heap dumping, but not manual heap dumping.
* Fix a "thread.arena" mallctl bug.Jason Evans2010-12-291-0/+5
| | | | | | When setting a new arena association for the calling thread, also update the tcache's cached arena pointer, primarily so that tcache_alloc_small_hard() uses the intended arena.
* Update various comments.Jason Evans2010-12-181-2/+2
|
* Remove an arena_bin_run_size_calc() constraint.Jason Evans2010-12-161-3/+1
| | | | | | Remove the constraint that small run headers fit in one page. This constraint was necessary to avoid dirty page purging issues for unused pages within runs for medium size classes (which no longer exist).
* Remove high_water from tcache_bin_t.Jason Evans2010-12-161-2/+0
| | | | | Remove the high_water field from tcache_bin_t, since it is not useful for anything.
* Add the "thread.[de]allocatedp" mallctl's.Jason Evans2010-12-031-1/+7
|
* Use mremap(2) for huge realloc().Jason Evans2010-12-014-14/+93
| | | | | | | | | | If mremap(2) is available and supports MREMAP_FIXED, use it for huge realloc(). Initialize rtree later during bootstrapping, so that --enable-debug --enable-dss works. Fix a minor swap_avail stats bug.
* Push down ctl_mtx.Jason Evans2010-11-241-74/+124
| | | | | | | Many mallctl*() end points require no locking, so push the locking down to just the functions that need it. This is of particular import for "thread.allocated" and "thread.deallocated", which are intended as a low-overhead way to introspect per thread allocation activity.
* Fix prof bugs.Jason Evans2010-10-281-6/+29
| | | | | | | Fix a race condition in ctx destruction that could cause undefined behavior (deadlock observed). Add mutex unlocks to some OOM error paths.
* Fix compilation error.Jason Evans2010-10-251-1/+3
| | | | Don't declare loop variable inside for (...) clause.
* Use madvise(..., MADV_FREE) on OS X.Jason Evans2010-10-241-3/+0
| | | | | Use madvise(..., MADV_FREE) rather than msync(..., MS_KILLPAGES) on OS X, since it works for at least OS X 10.5 and 10.6.
* Add missing #ifdef JEMALLOC_PROF.Jason Evans2010-10-241-0/+2
| | | | Only call prof_boot0() if profiling is enabled.
* Replace JEMALLOC_OPTIONS with MALLOC_CONF.Jason Evans2010-10-247-497/+575
| | | | | | | | | | | Replace the single-character run-time flags with key/value pairs, which can be set via the malloc_conf global, /etc/malloc.conf, and the MALLOC_CONF environment variable. Replace the JEMALLOC_PROF_PREFIX environment variable with the "opt.prof_prefix" option. Replace umax2s() with u2s().
* Fix heap profiling bugs.Jason Evans2010-10-223-66/+40
| | | | | | | | | | | | | Fix a regression due to the recent heap profiling accuracy improvements: prof_{m,re}alloc() must set the object's profiling context regardless of whether it is sampled. Fix management of the CHUNK_MAP_CLASS chunk map bits, such that all large object (re-)allocation paths correctly initialize the bits. Prior to this fix, in-place realloc() cleared the bits, resulting in incorrect reported object size from arena_salloc_demote(). After this fix the non-demoted bit pattern is all zeros (instead of all ones), which makes it easier to assure that the bits are properly set.
* Fix a heap profiling regression.Jason Evans2010-10-211-99/+0
| | | | | | Call prof_ctx_set() in all paths through prof_{m,re}alloc(). Inline arena_prof_ctx_get().
* Inline the fast path for heap sampling.Jason Evans2010-10-211-479/+74
| | | | | | | | Inline the heap sampling code that is executed for every allocation event (regardless of whether a sample is taken). Combine all prof TLS data into a single data structure, in order to reduce the TLS lookup volume.
* Add per thread allocation counters, and enhance heap sampling.Jason Evans2010-10-214-67/+262
| | | | | | | | | | | | | | | | | | | Add the "thread.allocated" and "thread.deallocated" mallctls, which can be used to query the total number of bytes ever allocated/deallocated by the calling thread. Add s2u() and sa2u(), which can be used to compute the usable size that will result from an allocation request of a particular size/alignment. Re-factor ipalloc() to use sa2u(). Enhance the heap profiler to trigger samples based on usable size, rather than request size. This has a subtle, but important, impact on the accuracy of heap sampling. For example, previous to this change, 16- and 17-byte objects were sampled at nearly the same rate, but 17-byte objects actually consume 32 bytes each. Therefore it was possible for the sample to be somewhat skewed compared to actual memory usage of the allocated objects.
* Fix a bug in arena_dalloc_bin_run().Jason Evans2010-10-191-13/+53
| | | | | | | | | | | Fix the newsize argument to arena_run_trim_tail() that arena_dalloc_bin_run() passes. Previously, oldsize-newsize (i.e. the complement) was passed, which could erroneously cause dirty pages to be returned to the clean available runs tree. Prior to the CHUNK_MAP_ZEROED --> CHUNK_MAP_UNZEROED conversion, this bug merely caused dirty pages to be unaccounted for (and therefore never get purged), but with CHUNK_MAP_UNZEROED, this could cause dirty pages to be treated as zeroed (i.e. memory corruption).
* Fix arena bugs.Jason Evans2010-10-181-6/+19
| | | | | | | | | Split arena_dissociate_bin_run() out of arena_dalloc_bin_run(), so that arena_bin_malloc_hard() can avoid dissociation when recovering from losing a race. This fixes a bug introduced by a recent attempted fix. Fix a regression in arena_ralloc_large_grow() that was introduced by recent fixes.
* Fix arena bugs.Jason Evans2010-10-181-43/+58
| | | | | | | | | Move part of arena_bin_lower_run() into the callers, since the conditions under which it should be called differ slightly between callers. Fix arena_chunk_purge() to omit run size in the last map entry for each run it temporarily allocates.
* Add assertions to run coalescing.Jason Evans2010-10-181-7/+17
| | | | | Assert that the chunk map bits at the ends of the runs that participate in coalescing are self-consistent.
* Fix numerous arena bugs.Jason Evans2010-10-181-76/+170
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In arena_ralloc_large_grow(), update the map element for the end of the newly grown run, rather than the interior map element that was the beginning of the appended run. This is a long-standing bug, and it had the potential to cause massive corruption, but triggering it required roughly the following sequence of events: 1) Large in-place growing realloc(), with left-over space in the run that followed the large object. 2) Allocation of the remainder run left over from (1). 3) Deallocation of the remainder run *before* deallocation of the large run, with unfortunate interior map state left over from previous run allocation/deallocation activity, such that one or more pages of allocated memory would be treated as part of the remainder run during run coalescing. In summary, this was a bad bug, but it was difficult to trigger. In arena_bin_malloc_hard(), if another thread wins the race to allocate a bin run, dispose of the spare run via arena_bin_lower_run() rather than arena_run_dalloc(), since the run has already been prepared for use as a bin run. This bug has existed since March 14, 2010: e00572b384c81bd2aba57fac32f7077a34388915 mmap()/munmap() without arena->lock or bin->lock. Fix bugs in arena_dalloc_bin_run(), arena_trim_head(), arena_trim_tail(), and arena_ralloc_large_grow() that could cause the CHUNK_MAP_UNZEROED map bit to become corrupted. These are all long-standing bugs, but the chances of them actually causing problems was much lower before the CHUNK_MAP_ZEROED --> CHUNK_MAP_UNZEROED conversion. Fix a large run statistics regression in arena_ralloc_large_grow() that was introduced on September 17, 2010: 8e3c3c61b5bb676a705450708e7e79698cdc9e0c Add {,r,s,d}allocm(). Add debug code to validate that supposedly pre-zeroed memory really is.
* Preserve CHUNK_MAP_UNZEROED for small runs.Jason Evans2010-10-161-4/+8
| | | | | | | | | Preserve CHUNK_MAP_UNZEROED when allocating small runs, because it is possible that untouched pages will be returned to the tree of clean runs, where the CHUNK_MAP_UNZEROED flag matters. Prior to the conversion from CHUNK_MAP_ZEROED, this was already a bug, but in the worst case extra zeroing occurred. After the conversion, this bug made it possible to incorrectly treat pages as pre-zeroed.
* Fix a regression in CHUNK_MAP_UNZEROED change.Jason Evans2010-10-141-2/+3
| | | | | | | | | | | | Fix a regression added by revision: 3377ffa1f4f8e67bce1e36624285e5baf5f9ecef Change CHUNK_MAP_ZEROED to CHUNK_MAP_UNZEROED. A modified chunk->map dereference was missing the subtraction of map_bias, which caused incorrect chunk map initialization, as well as potential corruption of the first non-header page of memory within each chunk.
generated by cgit v0.12 at 2025-04-21 19:51:04 (GMT)