diff options
author | Tony Theodore <tonyt@logyst.com> | 2016-04-11 11:06:46 (GMT) |
---|---|---|
committer | Tony Theodore <tonyt@logyst.com> | 2016-04-11 22:26:26 (GMT) |
commit | 580828183a8c888f3e5454a2171faf292d998ff4 (patch) | |
tree | c802733f6d6fcbb98adb687ad440f6c17936d57b | |
parent | 632085f2f7d7aa9ae525a72f41ffae281a0ca760 (diff) | |
download | mxe-580828183a8c888f3e5454a2171faf292d998ff4.zip mxe-580828183a8c888f3e5454a2171faf292d998ff4.tar.gz mxe-580828183a8c888f3e5454a2171faf292d998ff4.tar.bz2 |
clarify rationale for env whitelist entries
* add EDITOR, PS1, TERM for basic functionality of interactive shells
* separate mxe related variables
* identify source of ACLOCAL_PATH and LD_LIBRARY_PATH
-rw-r--r-- | Makefile | 11 |
1 files changed, 9 insertions, 2 deletions
@@ -155,8 +155,15 @@ endef PRELOAD_VARS := LD_PRELOAD DYLD_FORCE_FLAT_NAMESPACE DYLD_INSERT_LIBRARIES # use a minimal whitelist of safe environment variables -# HOME is needed for ~/.gitconfig for patch-tool-mxe -ENV_WHITELIST := PATH HOME LANG MAKE% MXE% %PROXY %proxy LD_LIBRARY_PATH $(PRELOAD_VARS) ACLOCAL_PATH +# basic working shell environment and mxe variables +# see http://www.linuxfromscratch.org/lfs/view/stable/chapter04/settingenvironment.html +ENV_WHITELIST := EDITOR HOME LANG PATH %PROXY %proxy PS1 TERM +ENV_WHITELIST += MAKE% MXE% $(PRELOAD_VARS) + +# OS/Distro related issues - "unsafe" but practical +# 1. https://github.com/mxe/mxe/issues/697 +ENV_WHITELIST += ACLOCAL_PATH LD_LIBRARY_PATH + unexport $(filter-out $(ENV_WHITELIST),$(shell env | cut -d '=' -f1)) # disable wine with readonly directory (created by mxe-conf) |