diff options
| author | Tony Theodore <tonyt@logyst.com> | 2013-02-09 07:26:37 (GMT) |
|---|---|---|
| committer | Tony Theodore <tonyt@logyst.com> | 2013-02-09 07:26:37 (GMT) |
| commit | f7133d3145115d7d4fed45ab895d96c1e4ac51ad (patch) | |
| tree | d94968de1102e1eb24ea7c5e53f5ccde4e5fb970 /src | |
| parent | 36555723f57064fb8be79aefe43e8de024d6b58f (diff) | |
| download | mxe-f7133d3145115d7d4fed45ab895d96c1e4ac51ad.zip mxe-f7133d3145115d7d4fed45ab895d96c1e4ac51ad.tar.gz mxe-f7133d3145115d7d4fed45ab895d96c1e4ac51ad.tar.bz2 | |
package sdl_mixer: fix for double-freeing resources with WAV files
Diffstat (limited to 'src')
| -rw-r--r-- | src/sdl_mixer-1-fix-double-free.patch | 35 |
1 files changed, 35 insertions, 0 deletions
diff --git a/src/sdl_mixer-1-fix-double-free.patch b/src/sdl_mixer-1-fix-double-free.patch new file mode 100644 index 0000000..a987ec1 --- /dev/null +++ b/src/sdl_mixer-1-fix-double-free.patch @@ -0,0 +1,35 @@ +This file is part of MXE. +See index.html for further information. + +https://bugs.gentoo.org/show_bug.cgi?id=406739 +Nikos Chantziaras 2012-03-03 03:13:39 EST + +There's a bug in the current version of SDL_mixer where failing to load a WAV sample will result in freeing a resource twice, resulting in an application crash. There is an upstream fix for this: + +http://hg.libsdl.org/SDL_mixer/rev/ea53a85853dd + +Upstream bug: http://bugzilla.libsdl.org/show_bug.cgi?id=1418 + +--- a/mixer.c ++++ b/mixer.c +@@ -610,13 +610,15 @@ + break; + default: + SDL_SetError("Unrecognized sound file type"); +- return(0); ++ if ( freesrc ) { ++ SDL_RWclose(src); ++ } ++ loaded = NULL; ++ break; + } + if ( !loaded ) { ++ /* The individual loaders have closed src if needed */ + SDL_free(chunk); +- if ( freesrc ) { +- SDL_RWclose(src); +- } + return(NULL); + } + + |