summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorandreas_kupries <akupries@shaw.ca>2001-08-23 21:15:59 (GMT)
committerandreas_kupries <akupries@shaw.ca>2001-08-23 21:15:59 (GMT)
commit5bcfdfbedb363aaa3e66ffc61232a83e68a1d46c (patch)
tree28b1859f1de01bf8397cabd990c5b00dcf12c719
parent571e6798ab1268412251c2a343f1a328307d5d68 (diff)
downloadtcl-5bcfdfbedb363aaa3e66ffc61232a83e68a1d46c.zip
tcl-5bcfdfbedb363aaa3e66ffc61232a83e68a1d46c.tar.gz
tcl-5bcfdfbedb363aaa3e66ffc61232a83e68a1d46c.tar.bz2
2001-08-23 Andreas Kupries <andreas_kupries@users.sourceforge.net>
* win/tclWinPipe.c (BuildCommandLine): Fixed tcl Bug [432499]. Part of the code used the non-absolute path to the executable to determine quoting. This failed if the absolute path cotained spaces, but the application name itselfl not. This bug caused no trouble on Win NT 5, but does for other variants in the Win* family. Report and fix due to Ken Poole <kenpoole@users.sourceforge.net>.
-rw-r--r--ChangeLog10
-rw-r--r--win/tclWinPipe.c6
2 files changed, 13 insertions, 3 deletions
diff --git a/ChangeLog b/ChangeLog
index 6d8cbda..bffa486 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+2001-08-23 Andreas Kupries <andreas_kupries@users.sourceforge.net>
+
+ * win/tclWinPipe.c (BuildCommandLine): Fixed tcl Bug
+ [432499]. Part of the code used the non-absolute path to the
+ executable to determine quoting. This failed if the absolute
+ path cotained spaces, but the application name itselfl not. This
+ bug caused no trouble on Win NT 5, but does for other variants
+ in the Win* family. Report and fix due to Ken Poole
+ <kenpoole@users.sourceforge.net>.
+
2001-08-23 Jeff Hobbs <jeffh@ActiveState.com>
* unix/configure:
diff --git a/win/tclWinPipe.c b/win/tclWinPipe.c
index 432d956..578d7eb 100644
--- a/win/tclWinPipe.c
+++ b/win/tclWinPipe.c
@@ -9,7 +9,7 @@
* See the file "license.terms" for information on usage and redistribution
* of this file, and for a DISCLAIMER OF ALL WARRANTIES.
*
- * RCS: @(#) $Id: tclWinPipe.c,v 1.18 2001/07/31 19:12:08 vincentdarley Exp $
+ * RCS: @(#) $Id: tclWinPipe.c,v 1.19 2001/08/23 21:15:59 andreas_kupries Exp $
*/
#include "tclWinInt.h"
@@ -1549,10 +1549,10 @@ BuildCommandLine(
}
quote = 0;
- if (argv[i][0] == '\0') {
+ if (arg[0] == '\0') {
quote = 1;
} else {
- for (start = argv[i]; *start != '\0'; start++) {
+ for (start = arg; *start != '\0'; start++) {
if (isspace(*start)) { /* INTL: ISO space. */
quote = 1;
break;