diff options
| author | dgp <dgp@users.sourceforge.net> | 2011-08-16 19:49:57 (GMT) |
|---|---|---|
| committer | dgp <dgp@users.sourceforge.net> | 2011-08-16 19:49:57 (GMT) |
| commit | 07e716801399c0843c58d8c3c6b43f183f1fd378 (patch) | |
| tree | 65f510076c61ade88ea8d216084b361a8d36816b /generic/tclCompile.c | |
| parent | 754781a8ca6a7ff2617e2dea8f8fc569c868445e (diff) | |
| download | tcl-07e716801399c0843c58d8c3c6b43f183f1fd378.zip tcl-07e716801399c0843c58d8c3c6b43f183f1fd378.tar.gz tcl-07e716801399c0843c58d8c3c6b43f183f1fd378.tar.bz2 | |
3392070 More complete prevention of Tcl_Obj reference cycles
bug_3392070
when producing an intrep of ByteCode.
Diffstat (limited to 'generic/tclCompile.c')
| -rw-r--r-- | generic/tclCompile.c | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/generic/tclCompile.c b/generic/tclCompile.c index ae633ea..026503b 100644 --- a/generic/tclCompile.c +++ b/generic/tclCompile.c @@ -2449,8 +2449,16 @@ TclInitByteCodeObj( * a value contains a literal which is that same value. * If this is allowed to happen, refcount decrements may not * reach zero, and memory may leak. Bugs 467523, 3357771 + * + * NOTE: [Bugs 3392070, 3389764] We make a copy based completely + * on the string value, and do not call Tcl_DuplicateObj() so we + * can be sure we do not have any lingering cycles hiding in + * the intrep. */ - codePtr->objArrayPtr[i] = Tcl_DuplicateObj(objPtr); + int numBytes; + const char *bytes = Tcl_GetStringFromObj(objPtr, &numBytes); + + codePtr->objArrayPtr[i] = Tcl_NewStringObj(bytes, numBytes); Tcl_IncrRefCount(codePtr->objArrayPtr[i]); Tcl_DecrRefCount(objPtr); } else { |