summaryrefslogtreecommitdiffstats
path: root/generic/tclHistory.c
diff options
context:
space:
mode:
authordgp <dgp@noemail.net>2004-10-06 14:59:00 (GMT)
committerdgp <dgp@noemail.net>2004-10-06 14:59:00 (GMT)
commite266385a3977c6a9d35f7f2972055809fcb47d0a (patch)
tree71a0e0114969e45230d047cb6fb0374e8f243c37 /generic/tclHistory.c
parentb4808b5cd1d437bbf1589adc0ce0629c127e5511 (diff)
downloadtcl-e266385a3977c6a9d35f7f2972055809fcb47d0a.zip
tcl-e266385a3977c6a9d35f7f2972055809fcb47d0a.tar.gz
tcl-e266385a3977c6a9d35f7f2972055809fcb47d0a.tar.bz2
* generic/tclBasic.c:
* generic/tclBinary.c: * generic/tclCmdAH.c: * generic/tclCmdIL.c: * generic/tclCmdMZ.c: * generic/tclCompExpr.c: * generic/tclDictObj.c: * generic/tclEncoding.c: * generic/tclExecute.c: * generic/tclFCmd.c: * generic/tclHistory.c: * generic/tclIndexObj.c: * generic/tclInterp.c: It is a poor practice to directly set or append to the value of the objResult of an interp, because that value might be shared, and in that circumstance a Tcl_Panic() will be the result. Searched for example of this practice and replaced with safer alternatives, often using the Tcl_AppendResult() routine that dkf just rehabilitated. FossilOrigin-Name: ee7c709e65fd0e2df636a6d1467bc907a2104da0
Diffstat (limited to 'generic/tclHistory.c')
-rw-r--r--generic/tclHistory.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/generic/tclHistory.c b/generic/tclHistory.c
index 4598a6a..784a31d 100644
--- a/generic/tclHistory.c
+++ b/generic/tclHistory.c
@@ -12,7 +12,7 @@
* See the file "license.terms" for information on usage and redistribution
* of this file, and for a DISCLAIMER OF ALL WARRANTIES.
*
- * RCS: @(#) $Id: tclHistory.c,v 1.6 2004/05/13 12:59:22 dkf Exp $
+ * RCS: @(#) $Id: tclHistory.c,v 1.7 2004/10/06 14:59:02 dgp Exp $
*/
#include "tclInt.h"
@@ -65,8 +65,7 @@ Tcl_RecordAndEval(interp, cmd, flags)
* then reset the object result.
*/
- Tcl_SetResult(interp, TclGetString(Tcl_GetObjResult(interp)),
- TCL_VOLATILE);
+ (void) Tcl_GetStringResult(interp);
/*
* Discard the Tcl object created to hold the command.