diff options
| author | dkf <donal.k.fellows@manchester.ac.uk> | 2010-03-05 14:34:03 (GMT) |
|---|---|---|
| committer | dkf <donal.k.fellows@manchester.ac.uk> | 2010-03-05 14:34:03 (GMT) |
| commit | b501910778714de837dc4367698256e996737e9b (patch) | |
| tree | f2dc6d4861ea238a538f41c4306249dad1ac3ea5 /generic/tclLoad.c | |
| parent | f7a64b3a111891d5f7f79ce94bbb37abedd30176 (diff) | |
| download | tcl-b501910778714de837dc4367698256e996737e9b.zip tcl-b501910778714de837dc4367698256e996737e9b.tar.gz tcl-b501910778714de837dc4367698256e996737e9b.tar.bz2 | |
Code Audit results:
* use do { ... } while (0) in macros
* avoid shadowing one local variable with another
* use clearer 'foo.bar++;' instead of '++foo.bar;' where result not
required (i.e., semantically equivalent)
* follow Engineering Manual rules on spacing and declarations
Diffstat (limited to 'generic/tclLoad.c')
| -rw-r--r-- | generic/tclLoad.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/generic/tclLoad.c b/generic/tclLoad.c index e5b70c3..e6e2ba5 100644 --- a/generic/tclLoad.c +++ b/generic/tclLoad.c @@ -9,7 +9,7 @@ * See the file "license.terms" for information on usage and redistribution of * this file, and for a DISCLAIMER OF ALL WARRANTIES. * - * RCS: @(#) $Id: tclLoad.c,v 1.23 2008/12/19 09:33:16 nijtmans Exp $ + * RCS: @(#) $Id: tclLoad.c,v 1.24 2010/03/05 14:34:04 dkf Exp $ */ #include "tclInt.h" @@ -443,9 +443,9 @@ Tcl_LoadObjCmd( Tcl_MutexLock(&packageMutex); if (Tcl_IsSafe(target)) { - ++pkgPtr->safeInterpRefCount; + pkgPtr->safeInterpRefCount++; } else { - ++pkgPtr->interpRefCount; + pkgPtr->interpRefCount++; } Tcl_MutexUnlock(&packageMutex); @@ -725,9 +725,9 @@ Tcl_UnloadObjCmd( Tcl_MutexUnlock(&packageMutex); if (Tcl_IsSafe(target)) { - --safeRefCount; + safeRefCount--; } else { - --trustedRefCount; + trustedRefCount--; } if (safeRefCount <= 0 && trustedRefCount <= 0) { @@ -747,7 +747,7 @@ Tcl_UnloadObjCmd( Tcl_MutexLock(&packageMutex); if (Tcl_IsSafe(target)) { - --pkgPtr->safeInterpRefCount; + pkgPtr->safeInterpRefCount--; /* * Do not let counter get negative. @@ -757,7 +757,7 @@ Tcl_UnloadObjCmd( pkgPtr->safeInterpRefCount = 0; } } else { - --pkgPtr->interpRefCount; + pkgPtr->interpRefCount--; /* * Do not let counter get negative. |