diff options
author | dgp <dgp@users.sourceforge.net> | 2023-08-21 18:07:48 (GMT) |
---|---|---|
committer | dgp <dgp@users.sourceforge.net> | 2023-08-21 18:07:48 (GMT) |
commit | 1ec6598ede90826c668a7d40db73a95ef3a3edb8 (patch) | |
tree | 4d5b46fc9fa4ddd3aed2224d86f66c65a659bb0f /generic/tclVar.c | |
parent | 8f0801033282ae8543f09d6e82509d8e1ef9122e (diff) | |
download | tcl-1ec6598ede90826c668a7d40db73a95ef3a3edb8.zip tcl-1ec6598ede90826c668a7d40db73a95ef3a3edb8.tar.gz tcl-1ec6598ede90826c668a7d40db73a95ef3a3edb8.tar.bz2 |
The experiment deployment of TclDuplicatePureObj() has been reverted from
the trunk. This branch attempts to prepare a reversion for the
core-8-branch also, via a cherrypick and resolution of conflicts.
Starting an experiment in one new release to reject it
in the next is at best odd. Also, valgrind test runs of core-8-branch
show memory leaks with TclDuplicatePureObj() on the stack trace. This
checkin shows a clean valgrind run.
There are three test failures on this checkin, which I hope someone versed
in the ArithSeries work can resolve. They are the tests:
lseq-3.14
lseq-4.19
lseq-bug-54329e39c7
merge bug-bc7ddc7944 (revert use of TclDuplicatePureObj)
Diffstat (limited to 'generic/tclVar.c')
-rw-r--r-- | generic/tclVar.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/generic/tclVar.c b/generic/tclVar.c index 70ba63b..1ed3eae 100644 --- a/generic/tclVar.c +++ b/generic/tclVar.c @@ -3221,7 +3221,7 @@ ArrayForNRCmd( * loop) don't vanish. */ - varListObj = TclDuplicatePureObj(interp, objv[1], &tclListType); + varListObj = TclListObjCopy(NULL, objv[1]); if (!varListObj) { return TCL_ERROR; } @@ -4196,8 +4196,7 @@ ArraySetCmd( * the loop and return an error. */ - copyListObj = - TclDuplicatePureObj(interp, arrayElemObj, &tclListType); + copyListObj = TclListObjCopy(NULL, arrayElemObj); if (!copyListObj) { return TCL_ERROR; } |