diff options
| author | hobbs <hobbs@noemail.net> | 2002-09-03 19:52:00 (GMT) |
|---|---|---|
| committer | hobbs <hobbs@noemail.net> | 2002-09-03 19:52:00 (GMT) |
| commit | d25b90758ada43772309909eeea8c594a96b408d (patch) | |
| tree | bc6a878a86b02313d228cb8725ce72888e78d772 /generic/tclVar.c | |
| parent | 16295b62232e2e97d40bce62e4fd234e7d72c14b (diff) | |
| download | tcl-d25b90758ada43772309909eeea8c594a96b408d.zip tcl-d25b90758ada43772309909eeea8c594a96b408d.tar.gz tcl-d25b90758ada43772309909eeea8c594a96b408d.tar.bz2 | |
(Tcl_UpVar2): code cleanup to not use goto
FossilOrigin-Name: b47b31db38384387b737d2ed58292f25c8449007
Diffstat (limited to 'generic/tclVar.c')
| -rw-r--r-- | generic/tclVar.c | 15 |
1 files changed, 6 insertions, 9 deletions
diff --git a/generic/tclVar.c b/generic/tclVar.c index 26a1bc2..516a558 100644 --- a/generic/tclVar.c +++ b/generic/tclVar.c @@ -15,7 +15,7 @@ * See the file "license.terms" for information on usage and redistribution * of this file, and for a DISCLAIMER OF ALL WARRANTIES. * - * RCS: @(#) $Id: tclVar.c,v 1.64 2002/09/03 15:04:42 msofer Exp $ + * RCS: @(#) $Id: tclVar.c,v 1.65 2002/09/03 19:52:01 hobbs Exp $ */ #include "tclInt.h" @@ -3639,19 +3639,16 @@ Tcl_UpVar2(interp, frameName, part1, part2, localName, flags) CallFrame *framePtr; Tcl_Obj *part1Ptr; + if (TclGetFrame(interp, frameName, &framePtr) == -1) { + return TCL_ERROR; + } + part1Ptr = Tcl_NewStringObj(part1, -1); Tcl_IncrRefCount(part1Ptr); - - result = TclGetFrame(interp, frameName, &framePtr); - if (result == -1) { - result = TCL_ERROR; - goto done; - } result = ObjMakeUpvar(interp, framePtr, part1Ptr, part2, 0, localName, flags, -1); - - done: TclDecrRefCount(part1Ptr); + return result; } |