summaryrefslogtreecommitdiffstats
path: root/generic
diff options
context:
space:
mode:
authorandreas_kupries <akupries@shaw.ca>2008-07-25 22:11:18 (GMT)
committerandreas_kupries <akupries@shaw.ca>2008-07-25 22:11:18 (GMT)
commite6ab7a094e17c5ecfaed583a37feb06afbc6bd94 (patch)
tree39a2112341211435426b708bc1f762560a383c9a /generic
parent492567dd1a47ceb460e19a20e233ff6d1efeb5ab (diff)
downloadtcl-e6ab7a094e17c5ecfaed583a37feb06afbc6bd94.zip
tcl-e6ab7a094e17c5ecfaed583a37feb06afbc6bd94.tar.gz
tcl-e6ab7a094e17c5ecfaed583a37feb06afbc6bd94.tar.bz2
* tests/info.test: Tests 38.* added, exactly testing the tracking
of location for uplevel scripts. Resolved merge conflict on info-37.0, switched !singleTestInterp constraint to glob matching instead. Ditto info-22.8, removed constraint, more glob matching, and reduced the depth of the stack we check. More is coming, right now I want to commit the bug fixes. * tests/oo.test: Updated oo-22.1 for expanded location tracking. * generic/tclCompile.c (TclInitCompileEnv): Reorganized the initialization of the #280 location information to match the flow in TclEvalObjEx to get more absolute contexts. * generic/tclBasic.c (TclEvalObjEx): Added missing cleanup of extended location information.
Diffstat (limited to 'generic')
-rw-r--r--generic/tclBasic.c9
-rw-r--r--generic/tclCompile.c44
-rw-r--r--generic/tclProc.c4
3 files changed, 36 insertions, 21 deletions
diff --git a/generic/tclBasic.c b/generic/tclBasic.c
index da81e9c..eb5e1c8 100644
--- a/generic/tclBasic.c
+++ b/generic/tclBasic.c
@@ -16,7 +16,7 @@
* See the file "license.terms" for information on usage and redistribution of
* this file, and for a DISCLAIMER OF ALL WARRANTIES.
*
- * RCS: @(#) $Id: tclBasic.c,v 1.330 2008/07/23 20:49:50 andreas_kupries Exp $
+ * RCS: @(#) $Id: tclBasic.c,v 1.331 2008/07/25 22:11:19 andreas_kupries Exp $
*/
#include "tclInt.h"
@@ -1515,6 +1515,10 @@ DeleteInterpProc(
ckfree((char *) eclPtr->loc);
}
+ if (eclPtr->eiloc != NULL) {
+ ckfree((char *) eclPtr->eiloc);
+ }
+
ckfree((char *) eclPtr);
Tcl_DeleteHashEntry(hPtr);
}
@@ -5741,6 +5745,9 @@ TclNREvalObjEx(
* execution speed. This is because it allows us to avoid a setFromAny
* step that would just pack everything into a string and back out again.
*
+ * This also preserves any associations between list elements and location
+ * information for such elements.
+ *
* This restriction has been relaxed a bit by storing in lists whether
* they are "canonical" or not (a canonical list being one that is either
* pure or that has its string rep derived by UpdateStringOfList from the
diff --git a/generic/tclCompile.c b/generic/tclCompile.c
index f484d7b..2d040b4 100644
--- a/generic/tclCompile.c
+++ b/generic/tclCompile.c
@@ -11,7 +11,7 @@
* See the file "license.terms" for information on usage and redistribution of
* this file, and for a DISCLAIMER OF ALL WARRANTIES.
*
- * RCS: @(#) $Id: tclCompile.c,v 1.153 2008/07/23 20:49:52 andreas_kupries Exp $
+ * RCS: @(#) $Id: tclCompile.c,v 1.154 2008/07/25 22:11:20 andreas_kupries Exp $
*/
#include "tclInt.h"
@@ -932,7 +932,23 @@ TclInitCompileEnv(
* ...) which may make change the type as well.
*/
- if ((invoker->nline <= word) || (invoker->line[word] < 0)) {
+ CmdFrame *ctxPtr;
+ int pc = 0;
+
+ ctxPtr = (CmdFrame *) TclStackAlloc(interp, sizeof(CmdFrame));
+ *ctxPtr = *invoker;
+
+ if (invoker->type == TCL_LOCATION_BC) {
+ /*
+ * Note: Type BC => ctx.data.eval.path is not used.
+ * ctx.data.tebc.codePtr is used instead.
+ */
+
+ TclGetSrcInfoForPc(ctxPtr);
+ pc = 1;
+ }
+
+ if ((ctxPtr->nline <= word) || (ctxPtr->line[word] < 0)) {
/*
* Word is not a literal, relative counting.
*/
@@ -940,45 +956,37 @@ TclInitCompileEnv(
envPtr->line = 1;
envPtr->extCmdMapPtr->type =
(envPtr->procPtr ? TCL_LOCATION_PROC : TCL_LOCATION_BC);
- } else {
- CmdFrame *ctxPtr;
- int pc = 0;
-
- ctxPtr = (CmdFrame *) TclStackAlloc(interp, sizeof(CmdFrame));
- *ctxPtr = *invoker;
- if (invoker->type == TCL_LOCATION_BC) {
+ if (pc && (ctxPtr->type == TCL_LOCATION_SOURCE)) {
/*
- * Note: Type BC => ctx.data.eval.path is not used.
- * ctx.data.tebc.codePtr is used instead.
+ * The reference made by 'TclGetSrcInfoForPc' is dead.
*/
-
- TclGetSrcInfoForPc(ctxPtr);
- pc = 1;
+ Tcl_DecrRefCount(ctxPtr->data.eval.path);
}
-
+ } else {
envPtr->line = ctxPtr->line[word];
envPtr->extCmdMapPtr->type = ctxPtr->type;
if (ctxPtr->type == TCL_LOCATION_SOURCE) {
+ envPtr->extCmdMapPtr->path = ctxPtr->data.eval.path;
+
if (pc) {
/*
* The reference 'TclGetSrcInfoForPc' made is transfered.
*/
- envPtr->extCmdMapPtr->path = ctxPtr->data.eval.path;
ctxPtr->data.eval.path = NULL;
} else {
/*
* We have a new reference here.
*/
- envPtr->extCmdMapPtr->path = ctxPtr->data.eval.path;
Tcl_IncrRefCount(envPtr->extCmdMapPtr->path);
}
}
- TclStackFree(interp, ctxPtr);
}
+
+ TclStackFree(interp, ctxPtr);
}
envPtr->auxDataArrayPtr = envPtr->staticAuxDataArraySpace;
diff --git a/generic/tclProc.c b/generic/tclProc.c
index 9947549..63aa7d5 100644
--- a/generic/tclProc.c
+++ b/generic/tclProc.c
@@ -12,7 +12,7 @@
* See the file "license.terms" for information on usage and redistribution of
* this file, and for a DISCLAIMER OF ALL WARRANTIES.
*
- * RCS: @(#) $Id: tclProc.c,v 1.151 2008/07/21 22:50:36 andreas_kupries Exp $
+ * RCS: @(#) $Id: tclProc.c,v 1.152 2008/07/25 22:11:21 andreas_kupries Exp $
*/
#include "tclInt.h"
@@ -2281,7 +2281,7 @@ TclProcCleanupProc(
/*
* TIP #280: Release the location data associated with this Proc
* structure, if any. The interpreter may not exist (For example for
- * procbody structurues created by tbcload.
+ * procbody structures created by tbcload.
*/
if (!iPtr) {